Merge "Settings: fix the NullPointerException when initiating media player" into qt-dev

This commit is contained in:
TreeHugger Robot
2019-04-10 16:42:03 +00:00
committed by Android (Google) Code Review

View File

@@ -220,11 +220,15 @@ public class VideoPreference extends Preference {
private void initMediaPlayer() { private void initMediaPlayer() {
if (mMediaPlayer == null) { if (mMediaPlayer == null) {
mMediaPlayer = MediaPlayer.create(mContext, mVideoPath); mMediaPlayer = MediaPlayer.create(mContext, mVideoPath);
mMediaPlayer.seekTo(0); // when the playback res is invalid or others, MediaPlayer create may fail
mMediaPlayer.setOnSeekCompleteListener(mp -> mVideoReady = true); // and return null, so need add the null judgement.
mMediaPlayer.setOnPreparedListener(mediaPlayer -> mediaPlayer.setLooping(true)); if (mMediaPlayer != null) {
if (mSurface != null) { mMediaPlayer.seekTo(0);
mMediaPlayer.setSurface(mSurface); mMediaPlayer.setOnSeekCompleteListener(mp -> mVideoReady = true);
mMediaPlayer.setOnPreparedListener(mediaPlayer -> mediaPlayer.setLooping(true));
if (mSurface != null) {
mMediaPlayer.setSurface(mSurface);
}
} }
} }
} }