Merge "Settings: fix the NullPointerException when initiating media player" into qt-dev

This commit is contained in:
TreeHugger Robot
2019-04-10 16:42:03 +00:00
committed by Android (Google) Code Review

View File

@@ -220,6 +220,9 @@ public class VideoPreference extends Preference {
private void initMediaPlayer() { private void initMediaPlayer() {
if (mMediaPlayer == null) { if (mMediaPlayer == null) {
mMediaPlayer = MediaPlayer.create(mContext, mVideoPath); mMediaPlayer = MediaPlayer.create(mContext, mVideoPath);
// when the playback res is invalid or others, MediaPlayer create may fail
// and return null, so need add the null judgement.
if (mMediaPlayer != null) {
mMediaPlayer.seekTo(0); mMediaPlayer.seekTo(0);
mMediaPlayer.setOnSeekCompleteListener(mp -> mVideoReady = true); mMediaPlayer.setOnSeekCompleteListener(mp -> mVideoReady = true);
mMediaPlayer.setOnPreparedListener(mediaPlayer -> mediaPlayer.setLooping(true)); mMediaPlayer.setOnPreparedListener(mediaPlayer -> mediaPlayer.setLooping(true));
@@ -228,6 +231,7 @@ public class VideoPreference extends Preference {
} }
} }
} }
}
private void releaseMediaPlayer() { private void releaseMediaPlayer() {
if (mMediaPlayer != null) { if (mMediaPlayer != null) {