PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Should not show loading animation after size loading complete

Browse Source 
SettingsPreferenceFragment#setLoading(boolean loading, boolean animate)
shows loading animation when 'animate' parameter is true.

This change sets 'animate' parameter false to fix this issue.

Bug: 254003456
Test: manual visual
      Settings -> Storage -> Free up space -> back
      then see if loading animation shows.
Change-Id: Ic804bcf950a9c57297ccefd6e942edea0b792a3b
This commit is contained in:
Arc Wang
2022-11-18 17:33:10 +08:00
parent 12d4b78473
commit ccf4fa052a
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/deviceinfo/StorageCategoryFragment.java
View File

@@ -26,7 +26,6 @@ import android.os.Bundle;
import android.os.UserManager; import android.os.UserManager;
import android.os.storage.StorageManager; import android.os.storage.StorageManager;
import android.util.SparseArray; import android.util.SparseArray;
import android.view.View;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.loader.app.LoaderManager; import androidx.loader.app.LoaderManager;
@@ -210,9 +209,7 @@ public class StorageCategoryFragment extends DashboardFragment
return; return;
} }
if (getView().findViewById(R.id.loading_container).getVisibility() == View.VISIBLE) { setLoading(false /* loading */, false /* animate */);
setLoading(false /* loading */, true /* animate */);
}
final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes; final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes;
mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo()); mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo());

2
src/com/android/settings/deviceinfo/StorageDashboardFragment.java
View File

@@ -385,7 +385,7 @@ public class StorageDashboardFragment extends DashboardFragment
return; return;
} }
setLoading(false /* loading */, true /* animate */); setLoading(false /* loading */, false /* animate */);
final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes; final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes;
mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo()); mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo());