diff --git a/res/values/strings.xml b/res/values/strings.xml index 52fae3da49b..703b74ca13a 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -10845,20 +10845,22 @@ Double-tap to check device - - One-Handed - - Enable one-handed mode - - Activity launch to exit - - Timeout - - 4 seconds - - 8 seconds - - 12 seconds + + One-Handed mode + + Use one-handed mode + + Exit when switching apps + + Timeout + + 4 seconds + + 8 seconds + + 12 seconds + + After %1$s of inactivity To check time, notifications, and other info, double-tap your screen. diff --git a/src/com/android/settings/gestures/OneHandedTimeoutPreferenceController.java b/src/com/android/settings/gestures/OneHandedTimeoutPreferenceController.java index 8bb56509c14..50446d3ce41 100644 --- a/src/com/android/settings/gestures/OneHandedTimeoutPreferenceController.java +++ b/src/com/android/settings/gestures/OneHandedTimeoutPreferenceController.java @@ -83,7 +83,11 @@ public class OneHandedTimeoutPreferenceController extends BasePreferenceControll @Override public CharSequence getSummary() { - return mTimeoutMap.get(getTimeoutValue()); + if (OneHandedSettingsUtils.getSettingsOneHandedModeTimeout(mContext) == 0) { + return mContext.getResources().getString(R.string.screensaver_settings_summary_never); + } + return String.format(mContext.getResources().getString( + R.string.one_handed_timeout_summary), mTimeoutMap.get(getTimeoutValue())); } @Override diff --git a/tests/robotests/src/com/android/settings/gestures/OneHandedTimeoutPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/gestures/OneHandedTimeoutPreferenceControllerTest.java index df683c09dd8..7fc10bbfed1 100644 --- a/tests/robotests/src/com/android/settings/gestures/OneHandedTimeoutPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/gestures/OneHandedTimeoutPreferenceControllerTest.java @@ -83,7 +83,7 @@ public class OneHandedTimeoutPreferenceControllerTest { } @Test - public void getSummary_setTimeout_shouldReturnSummary() { + public void getSummary_setTimeoutNever_shouldReturnNeverSummary() { final String[] timeoutTitles = mContext.getResources().getStringArray( R.array.one_handed_timeout_title); @@ -92,11 +92,18 @@ public class OneHandedTimeoutPreferenceControllerTest { assertThat(mController.getSummary()).isEqualTo( timeoutTitles[OneHandedSettingsUtils.OneHandedTimeout.NEVER.ordinal()]); + } + + @Test + public void getSummary_setTimeoutShort_shouldReturnShortSummary() { + final String[] timeoutTitles = mContext.getResources().getStringArray( + R.array.one_handed_timeout_title); OneHandedSettingsUtils.setSettingsOneHandedModeTimeout(mContext, OneHandedSettingsUtils.OneHandedTimeout.SHORT.getValue()); - assertThat(mController.getSummary()).isEqualTo( - timeoutTitles[OneHandedSettingsUtils.OneHandedTimeout.SHORT.ordinal()]); + assertThat(mController.getSummary()).isEqualTo(String.format( + mContext.getResources().getString(R.string.one_handed_timeout_summary), + timeoutTitles[OneHandedSettingsUtils.OneHandedTimeout.SHORT.ordinal()])); } }