From 509fd17515992f5017970a3f612db613df6d64d9 Mon Sep 17 00:00:00 2001 From: Harry Cutts Date: Tue, 31 Dec 2024 15:30:20 +0000 Subject: [PATCH] Touchpad: replace references to "trackpad" with "touchpad" When we first added the touchpad settings we hadn't settled on whether to refer to them as "touchpads" or "trackpads" yet. We've since settled on "touchpad", but that's left us with some Settings code referring to one and some to the other. Let's standardize on "touchpad" since that's consistent with user-facing strings and the rest of the input codebase. This CL doesn't change string identifiers, as I believe that would cause them to get different Translation Console IDs and thus be retranslated. Bug: 245989146 Test: m Test: check strings and icons are still displayed correctly in the touchpad settings and tutorial, and that settings toggles and the tutorial still work Test: atest SettingsRoboTests Flag: EXEMPT refactor Change-Id: I930e9fc85e09e03da3513e5f8443077fa8ea91b0 --- ..._trackpad.xml => ic_settings_touchpad.xml} | 0 ...pad_bordered.xml => touchpad_bordered.xml} | 0 ...d.xml => touchpad_button_done_colored.xml} | 0 ..._bg.xml => touchpad_gesture_dialog_bg.xml} | 0 ...eview.xml => touchpad_gesture_preview.xml} | 10 +++---- res/values/styles.xml | 8 +++--- res/xml/system_dashboard_fragment.xml | 4 +-- res/xml/touchpad_and_mouse_settings.xml | 28 +++++++++---------- res/xml/touchpad_settings.xml | 26 ++++++++--------- .../inputmethod/TouchpadAndMouseSettings.java | 2 +- ...ava => TouchpadGestureDialogFragment.java} | 6 ++-- ...esDisabledFooterPreferenceController.java} | 4 +-- ...esTutorialButtonPreferenceController.java} | 8 +++--- ...hpadPointerSpeedPreferenceController.java} | 4 +-- ...ReverseScrollingPreferenceController.java} | 4 +-- ...adRightClickZonePreferenceController.java} | 4 +-- ...chpadTapDraggingPreferenceController.java} | 4 +-- ...uchpadTapToClickPreferenceController.java} | 4 +-- ...PointerSpeedPreferenceControllerTest.java} | 10 +++---- ...rseScrollingPreferenceControllerTest.java} | 10 +++---- ...ghtClickZonePreferenceControllerTest.java} | 10 +++---- ...adTapToClickPreferenceControllerTest.java} | 10 +++---- 22 files changed, 77 insertions(+), 79 deletions(-) rename res/drawable/{ic_settings_trackpad.xml => ic_settings_touchpad.xml} (100%) rename res/drawable/{trackpad_bordered.xml => touchpad_bordered.xml} (100%) rename res/drawable/{trackpad_button_done_colored.xml => touchpad_button_done_colored.xml} (100%) rename res/drawable/{trackpad_gesture_dialog_bg.xml => touchpad_gesture_dialog_bg.xml} (100%) rename res/layout/{trackpad_gesture_preview.xml => touchpad_gesture_preview.xml} (94%) rename src/com/android/settings/inputmethod/{TrackpadGestureDialogFragment.java => TouchpadGestureDialogFragment.java} (98%) rename src/com/android/settings/inputmethod/{TrackpadGesturesDisabledFooterPreferenceController.java => TouchpadGesturesDisabledFooterPreferenceController.java} (89%) rename src/com/android/settings/inputmethod/{TouchGesturesButtonPreferenceController.java => TouchpadGesturesTutorialButtonPreferenceController.java} (91%) rename src/com/android/settings/inputmethod/{TrackpadPointerSpeedPreferenceController.java => TouchpadPointerSpeedPreferenceController.java} (95%) rename src/com/android/settings/inputmethod/{TrackpadReverseScrollingPreferenceController.java => TouchpadReverseScrollingPreferenceController.java} (93%) rename src/com/android/settings/inputmethod/{TrackpadBottomPreferenceController.java => TouchpadRightClickZonePreferenceController.java} (91%) rename src/com/android/settings/inputmethod/{TrackpadTapDraggingPreferenceController.java => TouchpadTapDraggingPreferenceController.java} (93%) rename src/com/android/settings/inputmethod/{TrackpadTapToClickPreferenceController.java => TouchpadTapToClickPreferenceController.java} (93%) rename tests/robotests/src/com/android/settings/inputmethod/{TrackpadPointerSpeedPreferenceControllerTest.java => TouchpadPointerSpeedPreferenceControllerTest.java} (92%) rename tests/robotests/src/com/android/settings/inputmethod/{TrackpadReverseScrollingPreferenceControllerTest.java => TouchpadReverseScrollingPreferenceControllerTest.java} (93%) rename tests/robotests/src/com/android/settings/inputmethod/{TrackpadBottomPreferenceControllerTest.java => TouchpadRightClickZonePreferenceControllerTest.java} (92%) rename tests/robotests/src/com/android/settings/inputmethod/{TrackpadTapToClickPreferenceControllerTest.java => TouchpadTapToClickPreferenceControllerTest.java} (93%) diff --git a/res/drawable/ic_settings_trackpad.xml b/res/drawable/ic_settings_touchpad.xml similarity index 100% rename from res/drawable/ic_settings_trackpad.xml rename to res/drawable/ic_settings_touchpad.xml diff --git a/res/drawable/trackpad_bordered.xml b/res/drawable/touchpad_bordered.xml similarity index 100% rename from res/drawable/trackpad_bordered.xml rename to res/drawable/touchpad_bordered.xml diff --git a/res/drawable/trackpad_button_done_colored.xml b/res/drawable/touchpad_button_done_colored.xml similarity index 100% rename from res/drawable/trackpad_button_done_colored.xml rename to res/drawable/touchpad_button_done_colored.xml diff --git a/res/drawable/trackpad_gesture_dialog_bg.xml b/res/drawable/touchpad_gesture_dialog_bg.xml similarity index 100% rename from res/drawable/trackpad_gesture_dialog_bg.xml rename to res/drawable/touchpad_gesture_dialog_bg.xml diff --git a/res/layout/trackpad_gesture_preview.xml b/res/layout/touchpad_gesture_preview.xml similarity index 94% rename from res/layout/trackpad_gesture_preview.xml rename to res/layout/touchpad_gesture_preview.xml index 978da06319c..2fdd418beee 100644 --- a/res/layout/trackpad_gesture_preview.xml +++ b/res/layout/touchpad_gesture_preview.xml @@ -17,7 +17,7 @@ @@ -46,7 +46,7 @@ android:layout_alignParentStart="true" android:paddingVertical="14dp" android:drawablePadding="9dp" - style="@style/TrackpadButtonCancel" + style="@style/TouchpadButtonCancel" android:textColor="?android:attr/textColorPrimary" android:text="@string/gesture_button_skip"/> @@ -60,7 +60,7 @@ android:layout_alignParentStart="true" android:paddingVertical="14dp" android:drawablePadding="9dp" - style="@style/TrackpadButtonCancel" + style="@style/TouchpadButtonCancel" android:textColor="?android:attr/textColorPrimary" android:text="@string/gesture_button_restart"/> @@ -81,7 +81,7 @@ android:layout_alignParentEnd="true" android:paddingVertical="14dp" android:drawablePadding="9dp" - style="@style/TrackpadButtonDone" + style="@style/TouchpadButtonDone" android:textColor="@androidprv:color/materialColorOnPrimary" android:text="@string/gesture_button_next"/> @@ -95,7 +95,7 @@ android:layout_alignParentEnd="true" android:paddingVertical="14dp" android:drawablePadding="9dp" - style="@style/TrackpadButtonDone" + style="@style/TouchpadButtonDone" android:textColor="@androidprv:color/materialColorOnPrimary" android:text="@string/gesture_button_done"/> diff --git a/res/values/styles.xml b/res/values/styles.xml index 2f4c1efc48d..29b4aa65739 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -372,15 +372,15 @@ 4dp - -