PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

We should show custom title for suspend app dialog

Browse Source 
BUG: 77523074

Test: Suspend an app, observe the new title.
Test: m -j RunSettingsRoboTest

Change-Id: Ide0329422e68b5ed6418365f2d0b0e0d11f0dec7
This commit is contained in:
Tony Mak
2018-04-03 18:51:39 +01:00
parent 396e91abf0
commit cbc3a6a1de
3 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
res/values/strings.xml
View File

@@ -8775,6 +8775,8 @@
<string name="disabled_by_policy_title_screen_capture">Screenshot not allowed</string> <string name="disabled_by_policy_title_screen_capture">Screenshot not allowed</string>
<!-- Title for dialog displayed to tell user that turning off backups is disallowed by an admin [CHAR LIMIT=50] --> <!-- Title for dialog displayed to tell user that turning off backups is disallowed by an admin [CHAR LIMIT=50] -->
<string name="disabled_by_policy_title_turn_off_backups">Can\'t turn off backups</string> <string name="disabled_by_policy_title_turn_off_backups">Can\'t turn off backups</string>
<!-- Title for dialog displayed to tell user that the app was suspended by an admin [CHAR LIMIT=50] -->
<string name="disabled_by_policy_title_suspend_packages">Can\'t open this app</string>
<!-- Shown when the user tries to change a settings locked by an admin [CHAR LIMIT=200] --> <!-- Shown when the user tries to change a settings locked by an admin [CHAR LIMIT=200] -->
<string name="default_admin_support_msg">If you have questions, contact your IT admin</string> <string name="default_admin_support_msg">If you have questions, contact your IT admin</string>
<!-- Shown in dialog to allow user to see more information about the device admin [CHAR LIMIT=30] --> <!-- Shown in dialog to allow user to see more information about the device admin [CHAR LIMIT=30] -->

3
src/com/android/settings/enterprise/ActionDisabledByAdminDialogHelper.java
View File

@@ -148,6 +148,9 @@ public class ActionDisabledByAdminDialogHelper {
case DevicePolicyManager.POLICY_MANDATORY_BACKUPS: case DevicePolicyManager.POLICY_MANDATORY_BACKUPS:
titleView.setText(R.string.disabled_by_policy_title_turn_off_backups); titleView.setText(R.string.disabled_by_policy_title_turn_off_backups);
break; break;
case DevicePolicyManager.POLICY_SUSPEND_PACKAGES:
titleView.setText(R.string.disabled_by_policy_title_suspend_packages);
break;
default: default:
// Use general text if no specialized title applies // Use general text if no specialized title applies
titleView.setText(R.string.disabled_by_policy_title); titleView.setText(R.string.disabled_by_policy_title);

4
tests/robotests/src/com/android/settings/enterprise/ActionDisabledByAdminDialogHelperTest.java
View File

@@ -128,6 +128,10 @@ public class ActionDisabledByAdminDialogHelperTest {
assertEquals(Shadows.shadowOf(textView).innerText(), assertEquals(Shadows.shadowOf(textView).innerText(),
mActivity.getString(R.string.disabled_by_policy_title_turn_off_backups)); mActivity.getString(R.string.disabled_by_policy_title_turn_off_backups));
mHelper.setAdminSupportTitle(view, DevicePolicyManager.POLICY_SUSPEND_PACKAGES);
assertEquals(Shadows.shadowOf(textView).innerText(),
mActivity.getString(R.string.disabled_by_policy_title_suspend_packages));
mHelper.setAdminSupportTitle(view, "another restriction"); mHelper.setAdminSupportTitle(view, "another restriction");
assertEquals(Shadows.shadowOf(textView).innerText(), assertEquals(Shadows.shadowOf(textView).innerText(),
mActivity.getString(R.string.disabled_by_policy_title)); mActivity.getString(R.string.disabled_by_policy_title));