From cbacfc5753e8a9dfba22b273ddf0762ac8bfac52 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 7 Sep 2018 14:14:47 -0400 Subject: [PATCH] Fix settings crash if launched with null args Test: manual Change-Id: I81990d63606074fc670cc39471c91ee61a73f1fc Fixes: 73666426 --- .../NotificationSettingsBase.java | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/com/android/settings/notification/NotificationSettingsBase.java b/src/com/android/settings/notification/NotificationSettingsBase.java index d06b545869f..ed0b1235ef4 100644 --- a/src/com/android/settings/notification/NotificationSettingsBase.java +++ b/src/com/android/settings/notification/NotificationSettingsBase.java @@ -112,19 +112,22 @@ abstract public class NotificationSettingsBase extends DashboardFragment { mPkgInfo = findPackageInfo(mPkg, mUid); - mUserId = UserHandle.getUserId(mUid); - mSuspendedAppsAdmin = RestrictedLockUtilsInternal.checkIfApplicationIsSuspended( - mContext, mPkg, mUserId); + if (mPkgInfo != null) { + mUserId = UserHandle.getUserId(mUid); + mSuspendedAppsAdmin = RestrictedLockUtilsInternal.checkIfApplicationIsSuspended( + mContext, mPkg, mUserId); - loadChannel(); - loadAppRow(); - loadChannelGroup(); - collectConfigActivities(); - getSettingsLifecycle().addObserver(use(HeaderPreferenceController.class)); + loadChannel(); + loadAppRow(); + loadChannelGroup(); + collectConfigActivities(); - for (NotificationPreferenceController controller : mControllers) { - controller.onResume(mAppRow, mChannel, mChannelGroup, mSuspendedAppsAdmin); + getSettingsLifecycle().addObserver(use(HeaderPreferenceController.class)); + + for (NotificationPreferenceController controller : mControllers) { + controller.onResume(mAppRow, mChannel, mChannelGroup, mSuspendedAppsAdmin); + } } }