From cad5436bbe631103e16edddbf4dfdec441eb5272 Mon Sep 17 00:00:00 2001 From: jasonwshsu Date: Tue, 20 Apr 2021 11:54:25 +0800 Subject: [PATCH] Update accessibility icons for S and using adaptive background * Follow android guideline to use adaptive icon for launcher services/features * Update color-check-baseline.xml * Update assets list: text and display, extra dim, dark theme, magnification, system controls, vibration and haptics, tap assistance, live caption, caption preferences, real time text, audio adjustment, hearing aids, font size, display size, bold text, color correction, color inversion Bug: 174540160 Bug: 183501919 Test: manual test Change-Id: I600d64f97d3a4651ebafb9016a6c8bff9bada0a0 --- color-check-baseline.xml | 492 ++++++++++-------- .../ic_accessibility_magnification.xml | 73 +-- res/drawable/ic_audio_adjustment.xml | 35 ++ res/drawable/ic_captioning.xml | 48 ++ res/drawable/ic_color_inversion.xml | 88 ++-- res/drawable/ic_daltonizer.xml | 64 +-- res/drawable/ic_dark_ui.xml | 36 ++ res/drawable/ic_font_size.xml | 35 ++ res/drawable/ic_force_bold.xml | 35 ++ res/drawable/ic_hearing_aid.xml | 35 ++ res/drawable/ic_live_caption.xml | 35 ++ res/drawable/ic_reduce_bright_colors.xml | 14 +- res/drawable/ic_rtt_settings.xml | 35 ++ res/drawable/ic_screen_zoom.xml | 35 ++ res/drawable/ic_system_controls.xml | 35 ++ res/drawable/ic_tap_assistance.xml | 35 ++ res/drawable/ic_text_and_display.xml | 35 ++ res/drawable/ic_vibration.xml | 35 ++ res/values/colors.xml | 9 +- res/xml/accessibility_settings.xml | 14 +- res/xml/accessibility_text_and_display.xml | 3 + 21 files changed, 875 insertions(+), 351 deletions(-) create mode 100644 res/drawable/ic_audio_adjustment.xml create mode 100644 res/drawable/ic_captioning.xml create mode 100644 res/drawable/ic_dark_ui.xml create mode 100644 res/drawable/ic_font_size.xml create mode 100644 res/drawable/ic_force_bold.xml create mode 100644 res/drawable/ic_hearing_aid.xml create mode 100644 res/drawable/ic_live_caption.xml create mode 100644 res/drawable/ic_rtt_settings.xml create mode 100644 res/drawable/ic_screen_zoom.xml create mode 100644 res/drawable/ic_system_controls.xml create mode 100644 res/drawable/ic_tap_assistance.xml create mode 100644 res/drawable/ic_text_and_display.xml create mode 100644 res/drawable/ic_vibration.xml diff --git a/color-check-baseline.xml b/color-check-baseline.xml index 4cea1a2d343..800d95b8632 100644 --- a/color-check-baseline.xml +++ b/color-check-baseline.xml @@ -1909,11 +1909,59 @@ priority="4" summary="Using hardcoded color" explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app." - errorLine1=" <color name="google_grey_700">#5f6368</color>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <color name="accessibility_feature_background">#5F6368</color> <!-- Google grey 700 -->" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + + + + + + + + + + + + @@ -2085,12 +2133,12 @@ priority="4" summary="Using hardcoded color" explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app." - errorLine1=" <item android:color="#333E2723" android:offset="0"/>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" android:color="@color/accessibility_magnification_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + line="22" + column="13"/> + errorLine1=" android:color="@color/accessibility_feature_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="res/drawable/ic_audio_adjustment.xml" + line="22" + column="13"/> + errorLine1=" android:color="@color/accessibility_feature_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="res/drawable/ic_captioning.xml" + line="22" + column="13"/> - - - - - - - - - - - - + errorLine1=" android:color="@color/accessibility_color_inversion_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + line="22" + column="13"/> - - - - - - - - - - - - + errorLine1=" android:color="@color/accessibility_daltonizer_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + line="22" + column="9"/> + errorLine1=" android:color="@color/accessibility_feature_background"/>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - - - - - - - - + file="res/drawable/ic_dark_ui.xml" + line="22" + column="13"/> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - @@ -3705,7 +3785,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -3721,7 +3801,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -3737,10 +3817,26 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + + + + @@ -3785,7 +3881,7 @@ errorLine2=" ^"> @@ -3801,7 +3897,7 @@ errorLine2=" ^"> @@ -3817,7 +3913,7 @@ errorLine2=" ^"> @@ -3833,7 +3929,7 @@ errorLine2=" ^"> @@ -3849,7 +3945,7 @@ errorLine2=" ^"> @@ -3865,7 +3961,7 @@ errorLine2=" ^"> @@ -3881,7 +3977,7 @@ errorLine2=" ^"> @@ -3897,7 +3993,7 @@ errorLine2=" ^"> @@ -3913,7 +4009,7 @@ errorLine2=" ^"> @@ -3929,7 +4025,7 @@ errorLine2=" ^"> @@ -3945,7 +4041,7 @@ errorLine2=" ^"> @@ -4109,20 +4205,4 @@ column="5"/> - - - - diff --git a/res/drawable/ic_accessibility_magnification.xml b/res/drawable/ic_accessibility_magnification.xml index 0dd3e2e8bbb..0b5c4ddb16a 100644 --- a/res/drawable/ic_accessibility_magnification.xml +++ b/res/drawable/ic_accessibility_magnification.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_audio_adjustment.xml b/res/drawable/ic_audio_adjustment.xml new file mode 100644 index 00000000000..f1c3724284e --- /dev/null +++ b/res/drawable/ic_audio_adjustment.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_captioning.xml b/res/drawable/ic_captioning.xml new file mode 100644 index 00000000000..ee5c617b6c5 --- /dev/null +++ b/res/drawable/ic_captioning.xml @@ -0,0 +1,48 @@ + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_color_inversion.xml b/res/drawable/ic_color_inversion.xml index 5d20d0544b7..cba4dcfd739 100644 --- a/res/drawable/ic_color_inversion.xml +++ b/res/drawable/ic_color_inversion.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + diff --git a/res/drawable/ic_daltonizer.xml b/res/drawable/ic_daltonizer.xml index 38cce69e96c..c3d57d9caa5 100644 --- a/res/drawable/ic_daltonizer.xml +++ b/res/drawable/ic_daltonizer.xml @@ -1,5 +1,5 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_dark_ui.xml b/res/drawable/ic_dark_ui.xml new file mode 100644 index 00000000000..0716cd09ed9 --- /dev/null +++ b/res/drawable/ic_dark_ui.xml @@ -0,0 +1,36 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_font_size.xml b/res/drawable/ic_font_size.xml new file mode 100644 index 00000000000..14217837873 --- /dev/null +++ b/res/drawable/ic_font_size.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_force_bold.xml b/res/drawable/ic_force_bold.xml new file mode 100644 index 00000000000..98b648aef84 --- /dev/null +++ b/res/drawable/ic_force_bold.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_hearing_aid.xml b/res/drawable/ic_hearing_aid.xml new file mode 100644 index 00000000000..302fd95cc67 --- /dev/null +++ b/res/drawable/ic_hearing_aid.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_live_caption.xml b/res/drawable/ic_live_caption.xml new file mode 100644 index 00000000000..fdd90e01be7 --- /dev/null +++ b/res/drawable/ic_live_caption.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_reduce_bright_colors.xml b/res/drawable/ic_reduce_bright_colors.xml index c46a8160bdb..fbcabee04a7 100644 --- a/res/drawable/ic_reduce_bright_colors.xml +++ b/res/drawable/ic_reduce_bright_colors.xml @@ -16,16 +16,12 @@ - - - - + - + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_screen_zoom.xml b/res/drawable/ic_screen_zoom.xml new file mode 100644 index 00000000000..2be1dceec34 --- /dev/null +++ b/res/drawable/ic_screen_zoom.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_system_controls.xml b/res/drawable/ic_system_controls.xml new file mode 100644 index 00000000000..48ee7acf70f --- /dev/null +++ b/res/drawable/ic_system_controls.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_tap_assistance.xml b/res/drawable/ic_tap_assistance.xml new file mode 100644 index 00000000000..63de6b2cd33 --- /dev/null +++ b/res/drawable/ic_tap_assistance.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_text_and_display.xml b/res/drawable/ic_text_and_display.xml new file mode 100644 index 00000000000..476b75346b0 --- /dev/null +++ b/res/drawable/ic_text_and_display.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/drawable/ic_vibration.xml b/res/drawable/ic_vibration.xml new file mode 100644 index 00000000000..9da4b08583d --- /dev/null +++ b/res/drawable/ic_vibration.xml @@ -0,0 +1,35 @@ + + + + + + + + + + + + \ No newline at end of file diff --git a/res/values/colors.xml b/res/values/colors.xml index 736a7dbc217..0aa309f92a3 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -190,9 +190,12 @@ #fff48fb1 #ffef9a9a - - #5f6368 - @*android:color/surface_header_light + + + #5F6368 + #F50D60 + #00BCD4 + #546E7A \ No newline at end of file diff --git a/res/xml/accessibility_settings.xml b/res/xml/accessibility_settings.xml index ec22cf0ac27..ce3f4a226e4 100644 --- a/res/xml/accessibility_settings.xml +++ b/res/xml/accessibility_settings.xml @@ -39,20 +39,22 @@ @@ -76,6 +78,7 @@ @@ -83,12 +86,14 @@ @@ -102,6 +107,7 @@ @@ -130,6 +138,7 @@ diff --git a/res/xml/accessibility_text_and_display.xml b/res/xml/accessibility_text_and_display.xml index 26b119f8c5b..abc5622ee06 100644 --- a/res/xml/accessibility_text_and_display.xml +++ b/res/xml/accessibility_text_and_display.xml @@ -23,6 +23,7 @@