PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use string notifications_disabled instead of off

Browse Source 
notifications_disabled was changed to off in
Change: I5f84d09f223efd478461ded93aeac82bf7b128d8

And reverted from off to notifications_disabled in
Change: Iaad301c5513478fb95e40987ea3ccb4f923d71fa

This usage is branched from AppNotificationPreferenceController.java,
and missed in revert.

Bug: 272603842
Test: Visual
Test: Unit test
Change-Id: I5b8466134c1342e10de7a2ead8c52931e0c19377
This commit is contained in:
Chaohui Wang
2023-04-29 15:41:29 +08:00
parent 24666c9737
commit ca615997ea
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/android/settings/spa/notification/AppNotificationRepository.kt
View File

@@ -123,13 +123,15 @@ class AppNotificationRepository(
} }
override fun getNotificationSummary(app: ApplicationInfo): String { override fun getNotificationSummary(app: ApplicationInfo): String {
if (!isEnabled(app)) return context.getString(R.string.off) if (!isEnabled(app)) return context.getString(R.string.notifications_disabled)
val channelCount = getChannelCount(app) val channelCount = getChannelCount(app)
if (channelCount == 0) { if (channelCount == 0) {
return calculateFrequencySummary(getSentCount(app)) return calculateFrequencySummary(getSentCount(app))
} }
val blockedChannelCount = getBlockedChannelCount(app) val blockedChannelCount = getBlockedChannelCount(app)
if (channelCount == blockedChannelCount) return context.getString(R.string.off) if (channelCount == blockedChannelCount) {
return context.getString(R.string.notifications_disabled)
}
val frequencySummary = calculateFrequencySummary(getSentCount(app)) val frequencySummary = calculateFrequencySummary(getSentCount(app))
if (blockedChannelCount == 0) return frequencySummary if (blockedChannelCount == 0) return frequencySummary
return context.getString( return context.getString(

4
tests/spa_unit/src/com/android/settings/spa/notification/AppNotificationRepositoryTest.kt
View File

@@ -251,7 +251,7 @@ class AppNotificationRepositoryTest {
val summary = repository.getNotificationSummary(APP) val summary = repository.getNotificationSummary(APP)
assertThat(summary).isEqualTo(context.getString(R.string.off)) assertThat(summary).isEqualTo(context.getString(R.string.notifications_disabled))
} }
@Test @Test
@@ -273,7 +273,7 @@ class AppNotificationRepositoryTest {
val summary = repository.getNotificationSummary(APP) val summary = repository.getNotificationSummary(APP)
assertThat(summary).isEqualTo(context.getString(R.string.off)) assertThat(summary).isEqualTo(context.getString(R.string.notifications_disabled))
} }
@Test @Test