From 8416d8efd7c683bf32b84d0a884a10739be01c95 Mon Sep 17 00:00:00 2001 From: Kevin Chang Date: Wed, 8 Jan 2020 18:44:58 +0800 Subject: [PATCH] Modify the code logic of OnLayoutChangeListener in Caption preferences Remove the listener and add statement to refresh the text when the caption turns on. Bug: 142632389 Test: Manual Change-Id: Ic5711309c5b8af9834e5439d825b4cb2ed55fe01 --- .../accessibility/CaptionAppearanceFragment.java | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/accessibility/CaptionAppearanceFragment.java b/src/com/android/settings/accessibility/CaptionAppearanceFragment.java index 5771ffecdc3..1672d5e2067 100644 --- a/src/com/android/settings/accessibility/CaptionAppearanceFragment.java +++ b/src/com/android/settings/accessibility/CaptionAppearanceFragment.java @@ -92,6 +92,17 @@ public class CaptionAppearanceFragment extends SettingsPreferenceFragment private final List mPreferenceList = new ArrayList<>(); + private final View.OnLayoutChangeListener mLayoutChangeListener = + new View.OnLayoutChangeListener() { + @Override + public void onLayoutChange(View v, int left, int top, int right, int bottom, + int oldLeft, int oldTop, int oldRight, int oldBottom) { + // Remove the listener once the callback is triggered. + mPreviewViewport.removeOnLayoutChangeListener(this); + refreshPreviewText(); + } + }; + @Override public int getMetricsCategory() { return SettingsEnums.ACCESSIBILITY_CAPTION_PROPERTIES; @@ -198,9 +209,7 @@ public class CaptionAppearanceFragment extends SettingsPreferenceFragment mPreviewWindow = captionPreview.findViewById(R.id.preview_window); mPreviewViewport = captionPreview.findViewById(R.id.preview_viewport); - mPreviewViewport.addOnLayoutChangeListener( - (v, left, top, right, bottom, oldLeft, oldTop, oldRight, oldBottom) - -> refreshPreviewText()); + mPreviewViewport.addOnLayoutChangeListener(mLayoutChangeListener); final Resources res = getResources(); final int[] presetValues = res.getIntArray(R.array.captioning_preset_selector_values);