From c9b9898e9aafe76594323a41e8954cb08d02818f Mon Sep 17 00:00:00 2001 From: Fyodor Kupolov Date: Wed, 13 Jul 2016 18:11:59 -0700 Subject: [PATCH] Application names are now lazily loaded Previously when SmsApplication.getDefaultApplication was called, application names were loaded for all candidate apps. The problem with that approach that names are expensive to load and not always needed. The implementation has been changed to only load application name when it's requested by getApplicationName(Context). Bug: 26237300 Change-Id: Ia711b7db8b979af8f7a1be7eefbce20f3e0ab1df --- src/com/android/settings/SmsDefaultDialog.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/SmsDefaultDialog.java b/src/com/android/settings/SmsDefaultDialog.java index e38c9b8f46d..830187ccab5 100644 --- a/src/com/android/settings/SmsDefaultDialog.java +++ b/src/com/android/settings/SmsDefaultDialog.java @@ -109,11 +109,11 @@ public final class SmsDefaultDialog extends AlertActivity implements // Compose dialog; get if (oldSmsApplicationData != null) { p.mMessage = getString(R.string.sms_change_default_dialog_text, - mNewSmsApplicationData.mApplicationName, - oldSmsApplicationData.mApplicationName); + mNewSmsApplicationData.getApplicationName(this), + oldSmsApplicationData.getApplicationName(this)); } else { p.mMessage = getString(R.string.sms_change_default_no_previous_dialog_text, - mNewSmsApplicationData.mApplicationName); + mNewSmsApplicationData.getApplicationName(this)); } p.mPositiveButtonText = getString(R.string.yes); p.mNegativeButtonText = getString(R.string.no);