From ec96dc15422e0c1f6506b91cdc1f2478a17852ad Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Wed, 16 Aug 2017 10:29:13 -0700 Subject: [PATCH] Remove "saved networks" from search indexing Change-Id: Ic8c1f8cee2c2a325ba3518d52d0c35b230a6abfd Fixes: 64755091 Test: robotests --- .../wifi/SavedAccessPointsWifiSettings.java | 53 +------------------ ...randfather_not_implementing_index_provider | 1 + 2 files changed, 2 insertions(+), 52 deletions(-) diff --git a/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java b/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java index 33fdf2d68f5..5c8e42be387 100644 --- a/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java +++ b/src/com/android/settings/wifi/SavedAccessPointsWifiSettings.java @@ -18,13 +18,9 @@ package com.android.settings.wifi; import android.app.Dialog; import android.content.Context; -import android.content.res.Resources; import android.icu.text.Collator; -import android.net.wifi.WifiConfiguration; import android.net.wifi.WifiManager; -import android.net.wifi.hotspot2.PasspointConfiguration; import android.os.Bundle; -import android.provider.SearchIndexableResource; import android.support.v7.preference.Preference; import android.support.v7.preference.PreferenceScreen; import android.util.Log; @@ -33,15 +29,11 @@ import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto.MetricsEvent; import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; -import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.Indexable; -import com.android.settings.search.SearchIndexableRaw; import com.android.settingslib.wifi.AccessPoint; import com.android.settingslib.wifi.AccessPointPreference; import com.android.settingslib.wifi.WifiSavedConfigUtils; -import java.util.ArrayList; -import java.util.Arrays; import java.util.Collections; import java.util.Comparator; import java.util.List; @@ -51,7 +43,7 @@ import java.util.List; */ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment implements Indexable, WifiDialog.WifiDialogListener { - private static final String TAG = "SavedAccessPointsWifiSettings"; + private static final String TAG = "SavedAccessPoints"; private static final Comparator SAVED_NETWORK_COMPARATOR = new Comparator() { final Collator mCollator = Collator.getInstance(); @@ -239,47 +231,4 @@ public class SavedAccessPointsWifiSettings extends SettingsPreferenceFragment return super.onPreferenceTreeClick(preference); } } - - /** - * For search. - */ - public static final SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider() { - @Override - public List getXmlResourcesToIndex(Context context, - boolean enabled) { - SearchIndexableResource sir = new SearchIndexableResource(context); - sir.xmlResId = R.xml.wifi_display_saved_access_points; - return Arrays.asList(sir); - } - - @Override - public List getRawDataToIndex(Context context, boolean enabled) { - final List result = new ArrayList(); - final Resources res = context.getResources(); - final String title = res.getString(R.string.wifi_saved_access_points_titlebar); - - // Add fragment title - SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = title; - data.screenTitle = title; - data.enabled = enabled; - result.add(data); - - // Add available Wi-Fi access points - final List accessPoints = WifiSavedConfigUtils.getAllConfigs( - context, context.getSystemService(WifiManager.class)); - - final int accessPointsSize = accessPoints.size(); - for (int i = 0; i < accessPointsSize; ++i){ - data = new SearchIndexableRaw(context); - data.title = accessPoints.get(i).getSsidStr(); - data.screenTitle = title; - data.enabled = enabled; - result.add(data); - } - - return result; - } - }; } diff --git a/tests/robotests/assets/grandfather_not_implementing_index_provider b/tests/robotests/assets/grandfather_not_implementing_index_provider index 462388941c8..c6d4bdac0f5 100644 --- a/tests/robotests/assets/grandfather_not_implementing_index_provider +++ b/tests/robotests/assets/grandfather_not_implementing_index_provider @@ -13,3 +13,4 @@ com.android.settings.enterprise.ApplicationListFragment$AdminGrantedPermissionMi com.android.settings.enterprise.ApplicationListFragment$EnterpriseInstalledPackages com.android.settings.enterprise.EnterpriseSetDefaultAppsListFragment com.android.settings.wifi.tether.WifiTetherSettings +com.android.settings.wifi.SavedAccessPointsWifiSettings