PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make AirplaneModePrefController.isAvailable static.

Browse Source 
Allows calling without instantiating the pref controller.
Also some minor cleanup of MobileNetworkPrefController.

Bug: 62022517
Test: robotests
Change-Id: I34ff5d3729d06158bff3cc125de4c114bf4861d5
This commit is contained in:
Andrew Sapperstein
2017-07-24 13:42:19 -07:00
parent 6666bf5605
commit c8c42838ca
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/network/AirplaneModePreferenceController.java
View File

@@ -45,7 +45,6 @@ public class AirplaneModePreferenceController extends PreferenceController
private final Fragment mFragment; private final Fragment mFragment;
private final MetricsFeatureProvider mMetricsFeatureProvider; private final MetricsFeatureProvider mMetricsFeatureProvider;
private final PackageManager mPackageManager;
private AirplaneModeEnabler mAirplaneModeEnabler; private AirplaneModeEnabler mAirplaneModeEnabler;
private SwitchPreference mAirplaneModePreference; private SwitchPreference mAirplaneModePreference;
@@ -53,7 +52,6 @@ public class AirplaneModePreferenceController extends PreferenceController
public AirplaneModePreferenceController(Context context, Fragment hostFragment) { public AirplaneModePreferenceController(Context context, Fragment hostFragment) {
super(context); super(context);
mFragment = hostFragment; mFragment = hostFragment;
mPackageManager = context.getPackageManager();
mMetricsFeatureProvider = FeatureFactory.getFactory(context).getMetricsFeatureProvider(); mMetricsFeatureProvider = FeatureFactory.getFactory(context).getMetricsFeatureProvider();
} }
@@ -88,7 +86,11 @@ public class AirplaneModePreferenceController extends PreferenceController
@Override @Override
public boolean isAvailable() { public boolean isAvailable() {
return !mPackageManager.hasSystemFeature(PackageManager.FEATURE_TELEVISION); return isAvailable(mContext);
}
public static boolean isAvailable(Context context) {
return !context.getPackageManager().hasSystemFeature(PackageManager.FEATURE_TELEVISION);
} }
@Override @Override

7
src/com/android/settings/network/MobileNetworkPreferenceController.java
View File

@@ -39,18 +39,17 @@ public class MobileNetworkPreferenceController extends PreferenceController impl
private static final String KEY_MOBILE_NETWORK_SETTINGS = "mobile_network_settings"; private static final String KEY_MOBILE_NETWORK_SETTINGS = "mobile_network_settings";
private final UserManager mUserManager;
private final boolean mIsSecondaryUser; private final boolean mIsSecondaryUser;
private final TelephonyManager mTelephonyManager; private final TelephonyManager mTelephonyManager;
private Preference mPreference; private Preference mPreference;
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) @VisibleForTesting
PhoneStateListener mPhoneStateListener; PhoneStateListener mPhoneStateListener;
public MobileNetworkPreferenceController(Context context) { public MobileNetworkPreferenceController(Context context) {
super(context); super(context);
mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE); UserManager userManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
mTelephonyManager = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE); mTelephonyManager = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE);
mIsSecondaryUser = !mUserManager.isAdminUser(); mIsSecondaryUser = !userManager.isAdminUser();
} }
@Override @Override