From c8b9240535d169c0420220ce8916d2bd50f30491 Mon Sep 17 00:00:00 2001 From: Suprabh Shukla Date: Wed, 17 Feb 2021 18:00:35 -0800 Subject: [PATCH] Adding alarms and reminders activity Adding a settings screen to control the permission SCHEDULE_EXACT_ALARM. Apps can start this by starting a newly introduced API intent REQUEST_SCHEDULE_EXACT_ALARM. Test: make -j RunSettingsRoboTests Manually by UI inspection: Settings -> Apps -> Special App access -> Alarms and Reminders or by running: adb shell am start -a android.settings.REQUEST_SCHEDULE_EXACT_ALARM Bug: 171306433 Bug: 171305516 Change-Id: I1293d38fc50a22b2af46f80ab24f676ed632f964 --- AndroidManifest.xml | 27 ++++ res/values/strings.xml | 18 +++ res/xml/alarms_and_reminders.xml | 30 ++++ res/xml/special_access.xml | 10 ++ src/com/android/settings/Settings.java | 4 + .../AppStateAlarmsAndRemindersBridge.java | 88 +++++++++++ .../applications/AppStateAppOpsBridge.java | 2 +- .../appinfo/AlarmsAndRemindersDetails.java | 137 ++++++++++++++++++ .../manageapplications/AppFilterRegistry.java | 13 +- .../ManageApplications.java | 19 +++ .../core/gateway/SettingsGateway.java | 4 +- .../AppStateAppOpsBridgeTest.java | 55 +++++++ .../AlarmsAndRemindersDetailsTest.java | 125 ++++++++++++++++ .../AppFilterRegistryTest.java | 5 + 14 files changed, 534 insertions(+), 3 deletions(-) create mode 100644 res/xml/alarms_and_reminders.xml create mode 100644 src/com/android/settings/applications/AppStateAlarmsAndRemindersBridge.java create mode 100644 src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetails.java create mode 100644 tests/robotests/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetailsTest.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index e5a9db43bd8..86d7992127a 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -3065,6 +3065,33 @@ android:value="com.android.settings.applications.appinfo.WriteSettingsDetails" /> + + + + + + + + + + + + + + + + + + Portable storage + + Alarms and reminders + + Allow to set alarms or reminders + + Alarms and reminders + + + Allow this app to schedule alarms or other timing based events. + This will allow the app to wake up and run even when you are not using the device. + Note that revoking this permission may cause the app to malfunction, specifically any alarms + that the app has scheduled will no longer work. + + + schedule, alarm, reminder, event + %1$s used of %2$s @@ -7304,6 +7320,8 @@ + + diff --git a/res/xml/alarms_and_reminders.xml b/res/xml/alarms_and_reminders.xml new file mode 100644 index 00000000000..a9d4323d42f --- /dev/null +++ b/res/xml/alarms_and_reminders.xml @@ -0,0 +1,30 @@ + + + + + + + + + + diff --git a/res/xml/special_access.xml b/res/xml/special_access.xml index de833f00130..671d8821b00 100644 --- a/res/xml/special_access.xml +++ b/res/xml/special_access.xml @@ -112,6 +112,16 @@ android:value="com.android.settings.Settings$ManageExternalSourcesActivity" /> + + + + allApps = mAppSession.getAllApps(); + for (int i = 0; i < allApps.size(); i++) { + final AppEntry currentEntry = allApps.get(i); + updateExtraInfo(currentEntry, currentEntry.info.packageName, currentEntry.info.uid); + } + } + + public static final AppFilter FILTER_CLOCK_APPS = new AppFilter() { + + @Override + public void init() { + } + + @Override + public boolean filterApp(AppEntry info) { + if (info.extraInfo instanceof PermissionState) { + final PermissionState permissionState = (PermissionState) info.extraInfo; + return permissionState.permissionDeclared; + } + return false; + } + }; + +} diff --git a/src/com/android/settings/applications/AppStateAppOpsBridge.java b/src/com/android/settings/applications/AppStateAppOpsBridge.java index b4f6e483711..2ccdc78413a 100755 --- a/src/com/android/settings/applications/AppStateAppOpsBridge.java +++ b/src/com/android/settings/applications/AppStateAppOpsBridge.java @@ -277,7 +277,7 @@ public abstract class AppStateAppOpsBridge extends AppStateBaseBridge { if (pe == null) { Log.w(TAG, "AppOp permission exists for package " + packageOp.getPackageName() + " of user " + userId + " but package doesn't exist or did not request " - + mPermissions + " access"); + + Arrays.toString(mPermissions) + " access"); continue; } diff --git a/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetails.java b/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetails.java new file mode 100644 index 00000000000..95835cbb326 --- /dev/null +++ b/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetails.java @@ -0,0 +1,137 @@ +/* + * Copyright (C) 2021 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.android.settings.applications.appinfo; + +import static android.app.Activity.RESULT_CANCELED; +import static android.app.Activity.RESULT_OK; + +import android.app.AppOpsManager; +import android.app.settings.SettingsEnums; +import android.content.Context; +import android.os.Bundle; + +import androidx.appcompat.app.AlertDialog; +import androidx.preference.Preference; +import androidx.preference.Preference.OnPreferenceChangeListener; + +import com.android.settings.R; +import com.android.settings.Settings; +import com.android.settings.applications.AppInfoWithHeader; +import com.android.settings.applications.AppStateAlarmsAndRemindersBridge; +import com.android.settings.applications.AppStateAppOpsBridge; +import com.android.settingslib.RestrictedSwitchPreference; +import com.android.settingslib.applications.ApplicationsState.AppEntry; + +/** + * App specific activity to show details about + * {@link android.Manifest.permission#SCHEDULE_EXACT_ALARM}. + */ +public class AlarmsAndRemindersDetails extends AppInfoWithHeader + implements OnPreferenceChangeListener { + + private static final String KEY_SWITCH = "alarms_and_reminders_switch"; + + private AppStateAlarmsAndRemindersBridge mAppBridge; + private AppOpsManager mAppOpsManager; + private RestrictedSwitchPreference mSwitchPref; + private AppStateAppOpsBridge.PermissionState mPermissionState; + + /** + * Returns the string that states whether the app has access to + * {@link android.Manifest.permission#SCHEDULE_EXACT_ALARM}. + */ + public static int getSummary(Context context, AppEntry entry) { + final AppStateAppOpsBridge.PermissionState state; + if (entry.extraInfo instanceof AppStateAppOpsBridge.PermissionState) { + state = (AppStateAppOpsBridge.PermissionState) entry.extraInfo; + } else { + state = new AppStateAlarmsAndRemindersBridge(context, /*appState=*/null, + /*callback=*/null).createPermissionState(entry.info.packageName, + entry.info.uid); + } + + return state.isPermissible() ? R.string.app_permission_summary_allowed + : R.string.app_permission_summary_not_allowed; + } + + @Override + public void onCreate(Bundle savedInstanceState) { + super.onCreate(savedInstanceState); + + final Context context = getActivity(); + mAppBridge = new AppStateAlarmsAndRemindersBridge(context, mState, /*callback=*/null); + mAppOpsManager = context.getSystemService(AppOpsManager.class); + + addPreferencesFromResource(R.xml.alarms_and_reminders); + mSwitchPref = findPreference(KEY_SWITCH); + mSwitchPref.setOnPreferenceChangeListener(this); + } + + @Override + public boolean onPreferenceChange(Preference preference, Object newValue) { + final boolean checked = (Boolean) newValue; + if (preference == mSwitchPref) { + if (mPermissionState != null && checked != mPermissionState.isPermissible()) { + if (Settings.AlarmsAndRemindersAppActivity.class.getName().equals( + getIntent().getComponent().getClassName())) { + setResult(checked ? RESULT_OK : RESULT_CANCELED); + } + setCanScheduleAlarms(checked); + logPermissionChange(checked, mPackageName); + refreshUi(); + } + return true; + } + return false; + } + + private void setCanScheduleAlarms(boolean newState) { + mAppOpsManager.setUidMode(AppOpsManager.OPSTR_SCHEDULE_EXACT_ALARM, + mPackageInfo.applicationInfo.uid, + newState ? AppOpsManager.MODE_ALLOWED : AppOpsManager.MODE_ERRORED); + } + + private void logPermissionChange(boolean newState, String packageName) { + mMetricsFeatureProvider.action( + mMetricsFeatureProvider.getAttribution(getActivity()), + SettingsEnums.ACTION_ALARMS_AND_REMINDERS_TOGGLE, + getMetricsCategory(), + packageName, + newState ? 1 : 0); + } + + @Override + protected boolean refreshUi() { + if (mPackageInfo == null || mPackageInfo.applicationInfo == null) { + return false; + } + mPermissionState = mAppBridge.createPermissionState(mPackageName, + mPackageInfo.applicationInfo.uid); + mSwitchPref.setEnabled(mPermissionState.permissionDeclared); + mSwitchPref.setChecked(mPermissionState.isPermissible()); + return true; + } + + @Override + protected AlertDialog createDialog(int id, int errorCode) { + return null; + } + + @Override + public int getMetricsCategory() { + return SettingsEnums.ALARMS_AND_REMINDERS; + } +} diff --git a/src/com/android/settings/applications/manageapplications/AppFilterRegistry.java b/src/com/android/settings/applications/manageapplications/AppFilterRegistry.java index b370ad2601d..f4de226167d 100644 --- a/src/com/android/settings/applications/manageapplications/AppFilterRegistry.java +++ b/src/com/android/settings/applications/manageapplications/AppFilterRegistry.java @@ -19,6 +19,7 @@ package com.android.settings.applications.manageapplications; import androidx.annotation.IntDef; import com.android.settings.R; +import com.android.settings.applications.AppStateAlarmsAndRemindersBridge; import com.android.settings.applications.AppStateInstallAppsBridge; import com.android.settings.applications.AppStateManageExternalStorageBridge; import com.android.settings.applications.AppStateNotificationBridge; @@ -50,6 +51,7 @@ public class AppFilterRegistry { FILTER_APPS_WRITE_SETTINGS, FILTER_APPS_INSTALL_SOURCES, FILTER_APPS_BLOCKED, + FILTER_ALARMS_AND_REMINDERS, }) @interface FilterType { } @@ -73,6 +75,7 @@ public class AppFilterRegistry { public static final int FILTER_APP_CAN_CHANGE_WIFI_STATE = 15; public static final int FILTER_APPS_BLOCKED = 16; public static final int FILTER_MANAGE_EXTERNAL_STORAGE = 17; + public static final int FILTER_ALARMS_AND_REMINDERS = 18; // Next id: 18. If you add an entry here, length of mFilters should be updated private static AppFilterRegistry sRegistry; @@ -80,7 +83,7 @@ public class AppFilterRegistry { private final AppFilterItem[] mFilters; private AppFilterRegistry() { - mFilters = new AppFilterItem[18]; + mFilters = new AppFilterItem[19]; // High power allowlist, on mFilters[FILTER_APPS_POWER_ALLOWLIST] = new AppFilterItem( @@ -185,6 +188,12 @@ public class AppFilterRegistry { AppStateManageExternalStorageBridge.FILTER_MANAGE_EXTERNAL_STORAGE, FILTER_MANAGE_EXTERNAL_STORAGE, R.string.filter_manage_external_storage); + + // Apps that can schedule alarms and reminders + mFilters[FILTER_ALARMS_AND_REMINDERS] = new AppFilterItem( + AppStateAlarmsAndRemindersBridge.FILTER_CLOCK_APPS, + FILTER_ALARMS_AND_REMINDERS, + R.string.alarms_and_reminders_title); } public static AppFilterRegistry getInstance() { @@ -213,6 +222,8 @@ public class AppFilterRegistry { return FILTER_APPS_RECENT; case ManageApplications.LIST_MANAGE_EXTERNAL_STORAGE: return FILTER_MANAGE_EXTERNAL_STORAGE; + case ManageApplications.LIST_TYPE_ALARMS_AND_REMINDERS: + return FILTER_ALARMS_AND_REMINDERS; default: return FILTER_APPS_ALL; } diff --git a/src/com/android/settings/applications/manageapplications/ManageApplications.java b/src/com/android/settings/applications/manageapplications/ManageApplications.java index 707e6f44a1a..2dadbbc0db8 100644 --- a/src/com/android/settings/applications/manageapplications/ManageApplications.java +++ b/src/com/android/settings/applications/manageapplications/ManageApplications.java @@ -91,6 +91,7 @@ import com.android.settings.Settings.WriteSettingsActivity; import com.android.settings.SettingsActivity; import com.android.settings.Utils; import com.android.settings.applications.AppInfoBase; +import com.android.settings.applications.AppStateAlarmsAndRemindersBridge; import com.android.settings.applications.AppStateAppOpsBridge.PermissionState; import com.android.settings.applications.AppStateBaseBridge; import com.android.settings.applications.AppStateInstallAppsBridge; @@ -104,6 +105,7 @@ import com.android.settings.applications.AppStateUsageBridge.UsageState; import com.android.settings.applications.AppStateWriteSettingsBridge; import com.android.settings.applications.AppStorageSettings; import com.android.settings.applications.UsageAccessDetails; +import com.android.settings.applications.appinfo.AlarmsAndRemindersDetails; import com.android.settings.applications.appinfo.AppInfoDashboardFragment; import com.android.settings.applications.appinfo.DrawOverlayDetails; import com.android.settings.applications.appinfo.ExternalSourcesDetails; @@ -230,6 +232,7 @@ public class ManageApplications extends InstrumentedFragment public static final int LIST_TYPE_PHOTOGRAPHY = 11; public static final int LIST_TYPE_WIFI_ACCESS = 13; public static final int LIST_MANAGE_EXTERNAL_STORAGE = 14; + public static final int LIST_TYPE_ALARMS_AND_REMINDERS = 15; // List types that should show instant apps. public static final Set LIST_TYPES_WITH_INSTANT = new ArraySet<>(Arrays.asList( @@ -321,6 +324,9 @@ public class ManageApplications extends InstrumentedFragment } else if (className.equals(Settings.ManageExternalStorageActivity.class.getName())) { mListType = LIST_MANAGE_EXTERNAL_STORAGE; screenTitle = R.string.manage_external_storage_title; + } else if (className.equals(Settings.AlarmsAndRemindersActivity.class.getName())) { + mListType = LIST_TYPE_ALARMS_AND_REMINDERS; + screenTitle = R.string.alarms_and_reminders_title; } else if (className.equals(Settings.NotificationAppListActivity.class.getName())) { mListType = LIST_TYPE_NOTIFICATION; mUsageStatsManager = IUsageStatsManager.Stub.asInterface( @@ -545,6 +551,8 @@ public class ManageApplications extends InstrumentedFragment return SettingsEnums.CONFIGURE_WIFI; case LIST_MANAGE_EXTERNAL_STORAGE: return SettingsEnums.MANAGE_EXTERNAL_STORAGE; + case LIST_TYPE_ALARMS_AND_REMINDERS: + return SettingsEnums.ALARMS_AND_REMINDERS; default: return SettingsEnums.PAGE_UNKNOWN; } @@ -666,6 +674,10 @@ public class ManageApplications extends InstrumentedFragment startAppInfoFragment(ManageExternalStorageDetails.class, R.string.manage_external_storage_title); break; + case LIST_TYPE_ALARMS_AND_REMINDERS: + startAppInfoFragment(AlarmsAndRemindersDetails.class, + R.string.alarms_and_reminders_label); + break; // TODO: Figure out if there is a way where we can spin up the profile's settings // process ahead of time, to avoid a long load of data when user clicks on a managed // app. Maybe when they load the list of apps that contains managed profile apps. @@ -744,6 +756,8 @@ public class ManageApplications extends InstrumentedFragment return R.string.help_uri_apps_wifi_access; case LIST_MANAGE_EXTERNAL_STORAGE: return R.string.help_uri_manage_external_storage; + case LIST_TYPE_ALARMS_AND_REMINDERS: + return R.string.help_uri_alarms_and_reminders; default: case LIST_TYPE_MAIN: return R.string.help_uri_apps; @@ -1066,6 +1080,8 @@ public class ManageApplications extends InstrumentedFragment mExtraInfoBridge = new AppStateChangeWifiStateBridge(mContext, mState, this); } else if (mManageApplications.mListType == LIST_MANAGE_EXTERNAL_STORAGE) { mExtraInfoBridge = new AppStateManageExternalStorageBridge(mContext, mState, this); + } else if (mManageApplications.mListType == LIST_TYPE_ALARMS_AND_REMINDERS) { + mExtraInfoBridge = new AppStateAlarmsAndRemindersBridge(mContext, mState, this); } else { mExtraInfoBridge = null; } @@ -1527,6 +1543,9 @@ public class ManageApplications extends InstrumentedFragment case LIST_MANAGE_EXTERNAL_STORAGE: holder.setSummary(ManageExternalStorageDetails.getSummary(mContext, entry)); break; + case LIST_TYPE_ALARMS_AND_REMINDERS: + holder.setSummary(AlarmsAndRemindersDetails.getSummary(mContext, entry)); + break; default: holder.updateSizeText(entry, mManageApplications.mInvalidSizeStr, mWhichSize); break; diff --git a/src/com/android/settings/core/gateway/SettingsGateway.java b/src/com/android/settings/core/gateway/SettingsGateway.java index 46bea3049d6..bc2582eef71 100644 --- a/src/com/android/settings/core/gateway/SettingsGateway.java +++ b/src/com/android/settings/core/gateway/SettingsGateway.java @@ -39,6 +39,7 @@ import com.android.settings.applications.AppDashboardFragment; import com.android.settings.applications.ProcessStatsSummary; import com.android.settings.applications.ProcessStatsUi; import com.android.settings.applications.UsageAccessDetails; +import com.android.settings.applications.appinfo.AlarmsAndRemindersDetails; import com.android.settings.applications.appinfo.AppInfoDashboardFragment; import com.android.settings.applications.appinfo.DrawOverlayDetails; import com.android.settings.applications.appinfo.ExternalSourcesDetails; @@ -313,7 +314,8 @@ public class SettingsGateway { InteractAcrossProfilesSettings.class.getName(), InteractAcrossProfilesDetails.class.getName(), MediaControlsSettings.class.getName(), - NetworkProviderSettings.class.getName() + NetworkProviderSettings.class.getName(), + AlarmsAndRemindersDetails.class.getName(), }; public static final String[] SETTINGS_FOR_RESTRICTED = { diff --git a/tests/robotests/src/com/android/settings/applications/AppStateAppOpsBridgeTest.java b/tests/robotests/src/com/android/settings/applications/AppStateAppOpsBridgeTest.java index 3f4175e1c22..8f41884ac6d 100644 --- a/tests/robotests/src/com/android/settings/applications/AppStateAppOpsBridgeTest.java +++ b/tests/robotests/src/com/android/settings/applications/AppStateAppOpsBridgeTest.java @@ -25,10 +25,13 @@ import android.app.AppOpsManager; import android.content.Context; import android.content.pm.IPackageManager; import android.os.RemoteException; +import android.os.UserHandle; import android.os.UserManager; import com.android.settingslib.applications.ApplicationsState.AppEntry; +import com.google.common.truth.Truth; + import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -60,6 +63,58 @@ public final class AppStateAppOpsBridgeTest { // should not crash } + @Test + public void permissionState_modeDefault_IsPermissible() { + AppStateAppOpsBridge.PermissionState permissionState = + new AppStateAppOpsBridge.PermissionState("pkg1", UserHandle.of(123)); + permissionState.appOpMode = AppOpsManager.MODE_DEFAULT; + + permissionState.staticPermissionGranted = true; + Truth.assertThat(permissionState.isPermissible()).isTrue(); + + permissionState.staticPermissionGranted = false; + Truth.assertThat(permissionState.isPermissible()).isFalse(); + } + + @Test + public void permissionState_modeErrored_IsPermissible() { + AppStateAppOpsBridge.PermissionState permissionState = + new AppStateAppOpsBridge.PermissionState("pkg1", UserHandle.of(123)); + permissionState.appOpMode = AppOpsManager.MODE_ERRORED; + + permissionState.staticPermissionGranted = true; + Truth.assertThat(permissionState.isPermissible()).isFalse(); + + permissionState.staticPermissionGranted = false; + Truth.assertThat(permissionState.isPermissible()).isFalse(); + } + + @Test + public void permissionState_modeAllowed_IsPermissible() { + AppStateAppOpsBridge.PermissionState permissionState = + new AppStateAppOpsBridge.PermissionState("pkg1", UserHandle.of(123)); + permissionState.appOpMode = AppOpsManager.MODE_ALLOWED; + + permissionState.staticPermissionGranted = true; + Truth.assertThat(permissionState.isPermissible()).isTrue(); + + permissionState.staticPermissionGranted = false; + Truth.assertThat(permissionState.isPermissible()).isTrue(); + } + + @Test + public void permissionState_modeIgnored_IsPermissible() { + AppStateAppOpsBridge.PermissionState permissionState = + new AppStateAppOpsBridge.PermissionState("pkg1", UserHandle.of(123)); + permissionState.appOpMode = AppOpsManager.MODE_IGNORED; + + permissionState.staticPermissionGranted = true; + Truth.assertThat(permissionState.isPermissible()).isFalse(); + + permissionState.staticPermissionGranted = false; + Truth.assertThat(permissionState.isPermissible()).isFalse(); + } + private class TestAppStateAppOpsBridge extends AppStateAppOpsBridge { private TestAppStateAppOpsBridge() { super(mContext, null, null, AppOpsManager.OP_SYSTEM_ALERT_WINDOW, diff --git a/tests/robotests/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetailsTest.java b/tests/robotests/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetailsTest.java new file mode 100644 index 00000000000..c3bceade2e5 --- /dev/null +++ b/tests/robotests/src/com/android/settings/applications/appinfo/AlarmsAndRemindersDetailsTest.java @@ -0,0 +1,125 @@ +/* + * Copyright (C) 2021 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.applications.appinfo; + +import static com.google.common.truth.Truth.assertThat; + +import static org.mockito.ArgumentMatchers.anyInt; +import static org.mockito.ArgumentMatchers.nullable; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import android.content.pm.ApplicationInfo; +import android.content.pm.PackageInfo; + +import com.android.settings.applications.AppStateAlarmsAndRemindersBridge; +import com.android.settings.applications.AppStateAppOpsBridge; +import com.android.settingslib.RestrictedSwitchPreference; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.robolectric.RobolectricTestRunner; +import org.robolectric.util.ReflectionHelpers; + +@RunWith(RobolectricTestRunner.class) +public class AlarmsAndRemindersDetailsTest { + + @Mock + private RestrictedSwitchPreference mSwitchPref; + @Mock + private PackageInfo mPackageInfo; + @Mock + private AppStateAlarmsAndRemindersBridge mAppStateBridge; + @Mock + private AppStateAppOpsBridge.PermissionState mPermissionState; + + private AlarmsAndRemindersDetails mFragment = new AlarmsAndRemindersDetails(); + + @Before + public void setUp() { + MockitoAnnotations.initMocks(this); + + ReflectionHelpers.setField(mFragment, "mSwitchPref", mSwitchPref); + ReflectionHelpers.setField(mFragment, "mAppBridge", mAppStateBridge); + } + + @Test + public void refreshUi_noPackageInfo_shouldReturnFalseAndNoCrash() { + mFragment.refreshUi(); + + assertThat(mFragment.refreshUi()).isFalse(); + // should not crash + } + + @Test + public void refreshUi_noApplicationInfo_shouldReturnFalseAndNoCrash() { + ReflectionHelpers.setField(mFragment, "mPackageInfo", mPackageInfo); + + mFragment.refreshUi(); + + assertThat(mFragment.refreshUi()).isFalse(); + // should not crash + } + + @Test + public void refreshUi_hasApplicationInfo_shouldReturnTrue() { + ReflectionHelpers.setField(mFragment, "mPackageInfo", mPackageInfo); + mPackageInfo.applicationInfo = new ApplicationInfo(); + when(mAppStateBridge.createPermissionState(nullable(String.class), anyInt())) + .thenReturn(mPermissionState); + + mFragment.refreshUi(); + + assertThat(mFragment.refreshUi()).isTrue(); + } + + @Test + public void refreshUi_switchPreferenceEnabled() { + ReflectionHelpers.setField(mFragment, "mPackageInfo", mPackageInfo); + mPackageInfo.applicationInfo = new ApplicationInfo(); + when(mAppStateBridge.createPermissionState(nullable(String.class), anyInt())) + .thenReturn(mPermissionState); + mPermissionState.permissionDeclared = false; + + mFragment.refreshUi(); + verify(mSwitchPref).setEnabled(false); + + mPermissionState.permissionDeclared = true; + + mFragment.refreshUi(); + verify(mSwitchPref).setEnabled(true); + } + + @Test + public void refreshUi_switchPreferenceChecked() { + ReflectionHelpers.setField(mFragment, "mPackageInfo", mPackageInfo); + mPackageInfo.applicationInfo = new ApplicationInfo(); + when(mAppStateBridge.createPermissionState(nullable(String.class), anyInt())) + .thenReturn(mPermissionState); + + when(mPermissionState.isPermissible()).thenReturn(true); + mFragment.refreshUi(); + verify(mSwitchPref).setChecked(true); + + when(mPermissionState.isPermissible()).thenReturn(false); + mFragment.refreshUi(); + verify(mSwitchPref).setChecked(false); + } +} diff --git a/tests/unit/src/com/android/settings/applications/manageapplications/AppFilterRegistryTest.java b/tests/unit/src/com/android/settings/applications/manageapplications/AppFilterRegistryTest.java index ba7a0d237a6..9c50d61b6c7 100644 --- a/tests/unit/src/com/android/settings/applications/manageapplications/AppFilterRegistryTest.java +++ b/tests/unit/src/com/android/settings/applications/manageapplications/AppFilterRegistryTest.java @@ -16,6 +16,7 @@ package com.android.settings.applications.manageapplications; +import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_ALARMS_AND_REMINDERS; import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_ALL; import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_INSTALL_SOURCES; import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_POWER_ALLOWLIST; @@ -23,6 +24,7 @@ import static com.android.settings.applications.manageapplications.AppFilterRegi import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_USAGE_ACCESS; import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_WITH_OVERLAY; import static com.android.settings.applications.manageapplications.AppFilterRegistry.FILTER_APPS_WRITE_SETTINGS; +import static com.android.settings.applications.manageapplications.ManageApplications.LIST_TYPE_ALARMS_AND_REMINDERS; import static com.android.settings.applications.manageapplications.ManageApplications.LIST_TYPE_GAMES; import static com.android.settings.applications.manageapplications.ManageApplications.LIST_TYPE_HIGH_POWER; import static com.android.settings.applications.manageapplications.ManageApplications.LIST_TYPE_MAIN; @@ -59,6 +61,9 @@ public class AppFilterRegistryTest { assertThat(registry.getDefaultFilterType(LIST_TYPE_MANAGE_SOURCES)) .isEqualTo(FILTER_APPS_INSTALL_SOURCES); + assertThat(registry.getDefaultFilterType(LIST_TYPE_ALARMS_AND_REMINDERS)) + .isEqualTo(FILTER_ALARMS_AND_REMINDERS); + assertThat(registry.getDefaultFilterType(LIST_TYPE_MAIN)).isEqualTo(FILTER_APPS_ALL); assertThat(registry.getDefaultFilterType(LIST_TYPE_NOTIFICATION)) .isEqualTo(FILTER_APPS_RECENT);