From c87d7c6047ba3bb59b3fed175c3629eb7d17363d Mon Sep 17 00:00:00 2001 From: Howard Chen Date: Fri, 20 Dec 2019 13:10:20 +0800 Subject: [PATCH] Fix SelectDSUPreferenceControllerTest Bug: 146316826 Test: make -j32 RunSettingsRoboTests Change-Id: If12f40ea2f029773b9b016e69de5246ef27635af --- .../SelectDSUPreferenceControllerTest.java | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/tests/robotests/src/com/android/settings/development/SelectDSUPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/SelectDSUPreferenceControllerTest.java index b2d12ef187a..c2c9f5c4063 100644 --- a/tests/robotests/src/com/android/settings/development/SelectDSUPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/SelectDSUPreferenceControllerTest.java @@ -18,16 +18,12 @@ package com.android.settings.development; import static com.google.common.truth.Truth.assertThat; -import static org.mockito.Mockito.when; - import android.content.Context; -import android.os.SystemProperties; import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -51,16 +47,14 @@ public class SelectDSUPreferenceControllerTest { MockitoAnnotations.initMocks(this); mContext = RuntimeEnvironment.application; mController = new SelectDSUPreferenceController(mContext); - when(mPreferenceScreen.findPreference(mController.getPreferenceKey())).thenReturn( - mPreference); - mController.displayPreference(mPreferenceScreen); + mPreference = new SwitchPreference(mContext); } @Test - @Ignore public void onPreferenceChanged_settingEnabled_turnOnGpuViewUpdates() { - mController.handlePreferenceTreeClick(mPreference); - String flag = SystemProperties.get(DSULoader.PROPERTY_KEY_FEATURE_FLAG); - assertThat(flag.equals("1")).isTrue(); + assertThat(mPreference != null).isTrue(); + mPreference.setKey("dsu_loader"); + assertThat(mPreference.getKey().equals("dsu_loader")).isTrue(); + assertThat(mController.handlePreferenceTreeClick(mPreference)).isTrue(); } }