diff --git a/res/values/config.xml b/res/values/config.xml index fb73e79c93e..924440406c6 100755 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -116,4 +116,6 @@ com.android.storagemanager.deletionhelper.DeletionHelperActivity + + false diff --git a/src/com/android/settings/support/NewDeviceIntroSuggestionActivity.java b/src/com/android/settings/support/NewDeviceIntroSuggestionActivity.java index 2189184441c..f881e2ff8c8 100644 --- a/src/com/android/settings/support/NewDeviceIntroSuggestionActivity.java +++ b/src/com/android/settings/support/NewDeviceIntroSuggestionActivity.java @@ -28,6 +28,7 @@ import android.text.TextUtils; import android.text.format.DateUtils; import android.util.Log; +import com.android.settings.R; import com.android.settings.dashboard.suggestions.SuggestionFeatureProvider; import com.android.settings.overlay.FeatureFactory; import com.android.settings.overlay.SupportFeatureProvider; @@ -61,7 +62,15 @@ public class NewDeviceIntroSuggestionActivity extends Activity { } public static boolean isSuggestionComplete(Context context) { - return isExpired(context) || hasLaunchedBefore(context) || !canOpenUrlInBrowser(context); + return !isSupported(context) + || isExpired(context) + || hasLaunchedBefore(context) + || !canOpenUrlInBrowser(context); + } + + private static boolean isSupported(Context context) { + return context.getResources() + .getBoolean(R.bool.config_new_device_intro_suggestion_supported); } private static boolean isExpired(Context context) { diff --git a/tests/robotests/res/values/config.xml b/tests/robotests/res/values/config.xml new file mode 100644 index 00000000000..156e20aef83 --- /dev/null +++ b/tests/robotests/res/values/config.xml @@ -0,0 +1,20 @@ + + + + + true + \ No newline at end of file diff --git a/tests/robotests/src/com/android/settings/support/NewDeviceIntroSuggestionActivityTest.java b/tests/robotests/src/com/android/settings/support/NewDeviceIntroSuggestionActivityTest.java index dc0f5fd49e0..75551e54ab4 100644 --- a/tests/robotests/src/com/android/settings/support/NewDeviceIntroSuggestionActivityTest.java +++ b/tests/robotests/src/com/android/settings/support/NewDeviceIntroSuggestionActivityTest.java @@ -22,9 +22,10 @@ import android.content.Intent; import android.content.SharedPreferences; import android.content.pm.ResolveInfo; -import com.android.settings.testutils.SettingsRobolectricTestRunner; +import com.android.settings.R; import com.android.settings.TestConfig; import com.android.settings.testutils.FakeFeatureFactory; +import com.android.settings.testutils.SettingsRobolectricTestRunner; import org.junit.Before; import org.junit.Test; @@ -69,6 +70,16 @@ public class NewDeviceIntroSuggestionActivityTest { .thenReturn(getSharedPreferences()); } + @Test + public void isSuggestionComplete_notSupported_shouldReturnTrue() { + when(mMockContext.getResources() + .getBoolean(R.bool.config_new_device_intro_suggestion_supported)) + .thenReturn(false); + + assertThat(isSuggestionComplete(mContext)) + .isTrue(); + } + @Test public void isSuggestionComplete_suggestionExpired_shouldReturnTrue() { final long currentTime = System.currentTimeMillis();