Merge "Adding FingerprintEnrollConfirmation" into main
This commit is contained in:
committed by
Android (Google) Code Review
commit
c76c7ac67f
2
tests/screenshot/OWNERS
Normal file
2
tests/screenshot/OWNERS
Normal file
@@ -0,0 +1,2 @@
|
||||
joshmccloskey@google.com
|
||||
jbolinger@google.com
|
BIN
tests/screenshot/assets/robolectric/fp_enroll_confirmation.png
Normal file
BIN
tests/screenshot/assets/robolectric/fp_enroll_confirmation.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 101 KiB |
@@ -27,6 +27,7 @@ import com.android.settings.biometrics.fingerprint2.lib.model.Default
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.modules.enrolling.rfps.ui.viewmodel.RFPSIconTouchViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.modules.enrolling.rfps.ui.viewmodel.RFPSViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.BackgroundViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintEnrollConfirmationViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintEnrollEnrollingViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintEnrollFindSensorViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintEnrollIntroViewModel
|
||||
@@ -103,6 +104,9 @@ class Injector(step: FingerprintNavigationStep.UiStep) {
|
||||
var rfpsViewModel =
|
||||
RFPSViewModel(fingerprintEnrollEnrollingViewModel, navigationViewModel, orientationInteractor)
|
||||
|
||||
val fingerprintEnrollConfirmationViewModel =
|
||||
FingerprintEnrollConfirmationViewModel(navigationViewModel, interactor)
|
||||
|
||||
var fingerprintFindSensorViewModel =
|
||||
FingerprintEnrollFindSensorViewModel(
|
||||
navigationViewModel,
|
||||
@@ -131,6 +135,7 @@ class Injector(step: FingerprintNavigationStep.UiStep) {
|
||||
BackgroundViewModel::class.java -> backgroundViewModel
|
||||
RFPSIconTouchViewModel::class.java -> rfpsIconTouchViewModel
|
||||
FingerprintEnrollEnrollingViewModel::class.java -> fingerprintEnrollEnrollingViewModel
|
||||
FingerprintEnrollConfirmationViewModel::class.java -> fingerprintEnrollConfirmationViewModel
|
||||
else -> null
|
||||
}
|
||||
as T
|
||||
|
@@ -0,0 +1,46 @@
|
||||
/*
|
||||
* Copyright (C) 2024 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.tests.screenshot.biometrics.fingerprint.fragment
|
||||
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||
import androidx.test.platform.app.InstrumentationRegistry
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.fragment.FingerprintEnrollConfirmationV2Fragment
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintNavigationStep
|
||||
import com.android.settings.tests.screenshot.biometrics.fingerprint.Injector
|
||||
import org.junit.Rule
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import platform.test.screenshot.FragmentScreenshotTestRule
|
||||
import platform.test.screenshot.ViewScreenshotTestRule.Mode
|
||||
|
||||
@RunWith(AndroidJUnit4::class)
|
||||
class FingerprintEnrollConfirmationScreenshotTest {
|
||||
private val injector: Injector = Injector(FingerprintNavigationStep.Confirmation)
|
||||
|
||||
@Rule
|
||||
@JvmField
|
||||
var rule: FragmentScreenshotTestRule = Injector.BiometricFragmentScreenShotRule()
|
||||
|
||||
@Test
|
||||
fun testConfirmation() {
|
||||
rule.screenshotTest(
|
||||
"fp_enroll_confirmation",
|
||||
Mode.MatchSize,
|
||||
FingerprintEnrollConfirmationV2Fragment(injector.factory),
|
||||
)
|
||||
}
|
||||
}
|
@@ -40,6 +40,7 @@ import com.google.common.truth.Truth.assertThat
|
||||
import kotlinx.coroutines.Dispatchers
|
||||
import kotlinx.coroutines.flow.Flow
|
||||
import kotlinx.coroutines.flow.MutableStateFlow
|
||||
import kotlinx.coroutines.flow.asStateFlow
|
||||
import kotlinx.coroutines.flow.flowOf
|
||||
import kotlinx.coroutines.flow.update
|
||||
import kotlinx.coroutines.launch
|
||||
@@ -119,21 +120,18 @@ class FingerprintEnrollFindSensorViewModelV2Test {
|
||||
}
|
||||
foldStateInteractor =
|
||||
object : FoldStateInteractor {
|
||||
override val isFolded: Flow<Boolean> = foldState
|
||||
override val isFolded: Flow<Boolean> = foldState.asStateFlow()
|
||||
|
||||
override fun onConfigurationChange(newConfig: Configuration) {
|
||||
TODO("Not yet implemented")
|
||||
foldState.update { false }
|
||||
}
|
||||
}
|
||||
|
||||
orientationInteractor =
|
||||
object: OrientationInteractor {
|
||||
override val orientation: Flow<Int>
|
||||
get() = TODO("Not yet implemented")
|
||||
object : OrientationInteractor {
|
||||
override val orientation: Flow<Int> = flowOf(Configuration.ORIENTATION_LANDSCAPE)
|
||||
override val rotation: Flow<Int> = flowOf(Surface.ROTATION_0)
|
||||
|
||||
override fun getRotationFromDefault(rotation: Int): Int {
|
||||
TODO("Not yet implemented")
|
||||
}
|
||||
|
||||
override fun getRotationFromDefault(rotation: Int): Int = rotation
|
||||
}
|
||||
underTest =
|
||||
FingerprintEnrollFindSensorViewModel.FingerprintEnrollFindSensorViewModelFactory(
|
||||
|
@@ -0,0 +1,111 @@
|
||||
/*
|
||||
* Copyright (C) 2024 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.fingerprint2.ui.enrollment.viewmodel
|
||||
|
||||
import androidx.arch.core.executor.testing.InstantTaskExecutorRule
|
||||
import com.android.settings.biometrics.fingerprint2.lib.model.Default
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintEnrollConfirmationViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintFlowViewModel
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintNavigationStep
|
||||
import com.android.settings.biometrics.fingerprint2.ui.enrollment.viewmodel.FingerprintNavigationViewModel
|
||||
import com.android.settings.testutils2.FakeFingerprintManagerInteractor
|
||||
import com.android.systemui.biometrics.shared.model.FingerprintSensor
|
||||
import com.android.systemui.biometrics.shared.model.FingerprintSensorType
|
||||
import com.android.systemui.biometrics.shared.model.SensorStrength
|
||||
import com.google.common.truth.Truth.assertThat
|
||||
import kotlinx.coroutines.launch
|
||||
import kotlinx.coroutines.test.StandardTestDispatcher
|
||||
import kotlinx.coroutines.test.TestScope
|
||||
import kotlinx.coroutines.test.advanceUntilIdle
|
||||
import kotlinx.coroutines.test.runCurrent
|
||||
import kotlinx.coroutines.test.runTest
|
||||
import org.junit.Before
|
||||
import org.junit.Rule
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import org.mockito.junit.MockitoJUnit
|
||||
import org.mockito.junit.MockitoJUnitRunner
|
||||
|
||||
@RunWith(MockitoJUnitRunner::class)
|
||||
class FingerprintEnrollConfirmationViewModelTest {
|
||||
@JvmField @Rule var rule = MockitoJUnit.rule()
|
||||
|
||||
@get:Rule val instantTaskRule = InstantTaskExecutorRule()
|
||||
private var backgroundDispatcher = StandardTestDispatcher()
|
||||
private var testScope = TestScope(backgroundDispatcher)
|
||||
val fingerprintFlowViewModel = FingerprintFlowViewModel(Default)
|
||||
val fakeFingerprintManagerInteractor = FakeFingerprintManagerInteractor()
|
||||
lateinit var navigationViewModel: FingerprintNavigationViewModel
|
||||
lateinit var underTest: FingerprintEnrollConfirmationViewModel
|
||||
|
||||
@Before
|
||||
fun setup() {
|
||||
navigationViewModel =
|
||||
FingerprintNavigationViewModel(
|
||||
FingerprintNavigationStep.Confirmation,
|
||||
false,
|
||||
fingerprintFlowViewModel,
|
||||
fakeFingerprintManagerInteractor,
|
||||
)
|
||||
underTest =
|
||||
FingerprintEnrollConfirmationViewModel(navigationViewModel, fakeFingerprintManagerInteractor)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testCanEnrollFingerprints() =
|
||||
testScope.runTest {
|
||||
fakeFingerprintManagerInteractor.sensorProp =
|
||||
FingerprintSensor(0 /* sensorId */, SensorStrength.STRONG, 5, FingerprintSensorType.REAR)
|
||||
fakeFingerprintManagerInteractor.enrolledFingerprintsInternal = mutableListOf()
|
||||
fakeFingerprintManagerInteractor.enrollableFingerprints = 5
|
||||
|
||||
var canEnrollFingerprints: Boolean = false
|
||||
val job = launch { underTest.isAddAnotherButtonVisible.collect { canEnrollFingerprints = it } }
|
||||
|
||||
advanceUntilIdle()
|
||||
assertThat(canEnrollFingerprints).isTrue()
|
||||
job.cancel()
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testNextButtonSendsNextStep() =
|
||||
testScope.runTest {
|
||||
var step: FingerprintNavigationStep.UiStep? = null
|
||||
val job = launch { navigationViewModel.navigateTo.collect { step = it } }
|
||||
|
||||
underTest.onNextButtonClicked()
|
||||
|
||||
runCurrent()
|
||||
|
||||
assertThat(step).isNull()
|
||||
job.cancel()
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testAddAnotherSendsAction() =
|
||||
testScope.runTest {
|
||||
var step: FingerprintNavigationStep.UiStep? = null
|
||||
val job = launch { navigationViewModel.navigateTo.collect { step = it } }
|
||||
|
||||
underTest.onAddAnotherButtonClicked()
|
||||
|
||||
runCurrent()
|
||||
|
||||
assertThat(step).isInstanceOf(FingerprintNavigationStep.Enrollment::class.java)
|
||||
job.cancel()
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user