diff --git a/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java b/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java index b9bfcc1e66a..0672bd4c610 100644 --- a/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java +++ b/tests/robotests/src/com/android/settings/datausage/DataUsageSummaryTest.java @@ -27,7 +27,6 @@ import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.never; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; import android.app.usage.NetworkStatsManager; import android.content.Context; @@ -46,15 +45,16 @@ import com.android.settings.testutils.shadow.ShadowUtils; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.Answers; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; +import org.robolectric.Shadows; import org.robolectric.annotation.Config; import org.robolectric.shadows.ShadowApplication; import org.robolectric.shadows.ShadowSubscriptionManager; +import org.robolectric.shadows.ShadowTelephonyManager; @Config(shadows = { ShadowUtils.class, @@ -71,7 +71,6 @@ public class DataUsageSummaryTest { private NetworkPolicyManager mNetworkPolicyManager; @Mock private NetworkStatsManager mNetworkStatsManager; - @Mock(answer = Answers.RETURNS_DEEP_STUBS) private TelephonyManager mTelephonyManager; private Context mContext; private FragmentActivity mActivity; @@ -90,8 +89,11 @@ public class DataUsageSummaryTest { shadowContext.setSystemService(Context.NETWORK_POLICY_SERVICE, mNetworkPolicyManager); mContext = spy(RuntimeEnvironment.application); - when(mContext.getSystemService(Context.TELEPHONY_SERVICE)).thenReturn(mTelephonyManager); - when(mTelephonyManager.createForSubscriptionId(anyInt())).thenReturn(mTelephonyManager); + mTelephonyManager = mContext.getSystemService(TelephonyManager.class); + final ShadowTelephonyManager shadowTelephonyManager = Shadows.shadowOf(mTelephonyManager); + shadowTelephonyManager.setTelephonyManagerForSubscriptionId( + SubscriptionManager.INVALID_SUBSCRIPTION_ID, mTelephonyManager); + shadowTelephonyManager.setTelephonyManagerForSubscriptionId(1, mTelephonyManager); mActivity = spy(Robolectric.buildActivity(FragmentActivity.class).get()); doReturn(mNetworkStatsManager).when(mActivity).getSystemService(NetworkStatsManager.class); @@ -188,7 +190,7 @@ public class DataUsageSummaryTest { ShadowDataUsageUtils.IS_WIFI_SUPPORTED = true; ShadowDataUsageUtils.HAS_SIM = false; ShadowSubscriptionManager.setDefaultDataSubscriptionId( - SubscriptionManager.INVALID_SUBSCRIPTION_ID); + SubscriptionManager.INVALID_SUBSCRIPTION_ID); final DataUsageSummary dataUsageSummary = spy(new DataUsageSummary()); doReturn(mContext).when(dataUsageSummary).getContext(); diff --git a/tests/robotests/src/com/android/settings/homepage/contextualcards/deviceinfo/DataUsageSliceTest.java b/tests/robotests/src/com/android/settings/homepage/contextualcards/deviceinfo/DataUsageSliceTest.java index 588b7aa4519..b3aae034c1e 100644 --- a/tests/robotests/src/com/android/settings/homepage/contextualcards/deviceinfo/DataUsageSliceTest.java +++ b/tests/robotests/src/com/android/settings/homepage/contextualcards/deviceinfo/DataUsageSliceTest.java @@ -17,13 +17,13 @@ package com.android.settings.homepage.contextualcards.deviceinfo; import static com.google.common.truth.Truth.assertThat; - import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.spy; import android.content.Context; - +import android.telephony.SubscriptionManager; +import android.telephony.TelephonyManager; import androidx.core.graphics.drawable.IconCompat; import androidx.slice.Slice; import androidx.slice.SliceItem; @@ -31,19 +31,18 @@ import androidx.slice.SliceMetadata; import androidx.slice.SliceProvider; import androidx.slice.core.SliceAction; import androidx.slice.widget.SliceLiveData; - import com.android.settings.R; import com.android.settings.testutils.SliceTester; import com.android.settings.testutils.shadow.ShadowDataUsageUtils; - +import java.util.List; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; +import org.robolectric.Shadows; import org.robolectric.annotation.Config; - -import java.util.List; +import org.robolectric.shadows.ShadowTelephonyManager; @RunWith(RobolectricTestRunner.class) @Config(shadows = ShadowDataUsageUtils.class) @@ -62,6 +61,11 @@ public class DataUsageSliceTest { SliceProvider.setSpecs(SliceLiveData.SUPPORTED_SPECS); mDataUsageSlice = spy(new DataUsageSlice(mContext)); + + final TelephonyManager telephonyManager = mContext.getSystemService(TelephonyManager.class); + final ShadowTelephonyManager shadowTelephonyManager = Shadows.shadowOf(telephonyManager); + shadowTelephonyManager.setTelephonyManagerForSubscriptionId( + SubscriptionManager.INVALID_SUBSCRIPTION_ID, telephonyManager); } @Test diff --git a/tests/robotests/src/com/android/settings/network/telephony/DataUsagePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/network/telephony/DataUsagePreferenceControllerTest.java index 5ffda8179e2..7a097e7be8f 100644 --- a/tests/robotests/src/com/android/settings/network/telephony/DataUsagePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/network/telephony/DataUsagePreferenceControllerTest.java @@ -17,7 +17,6 @@ package com.android.settings.network.telephony; import static com.google.common.truth.Truth.assertThat; - import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.verify; @@ -30,12 +29,9 @@ import android.net.TrafficStats; import android.provider.Settings; import android.telephony.SubscriptionManager; import android.telephony.TelephonyManager; - import androidx.preference.SwitchPreference; - import com.android.settings.core.BasePreferenceController; import com.android.settingslib.net.DataUsageController; - import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -44,14 +40,14 @@ import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; +import org.robolectric.Shadows; +import org.robolectric.shadows.ShadowTelephonyManager; import org.robolectric.util.ReflectionHelpers; @RunWith(RobolectricTestRunner.class) public class DataUsagePreferenceControllerTest { private static final int SUB_ID = 2; - @Mock - private TelephonyManager mTelephonyManager; @Mock private NetworkStatsManager mNetworkStatsManager; private DataUsagePreferenceController mController; @@ -63,8 +59,13 @@ public class DataUsagePreferenceControllerTest { MockitoAnnotations.initMocks(this); mContext = spy(Robolectric.setupActivity(Activity.class)); - doReturn(mTelephonyManager).when(mContext).getSystemService(Context.TELEPHONY_SERVICE); - doReturn(mTelephonyManager).when(mTelephonyManager).createForSubscriptionId(SUB_ID); + + final TelephonyManager telephonyManager = mContext.getSystemService(TelephonyManager.class); + final ShadowTelephonyManager shadowTelephonyManager = Shadows.shadowOf(telephonyManager); + shadowTelephonyManager.setTelephonyManagerForSubscriptionId(SUB_ID, telephonyManager); + shadowTelephonyManager.setTelephonyManagerForSubscriptionId( + SubscriptionManager.INVALID_SUBSCRIPTION_ID, telephonyManager); + doReturn(mNetworkStatsManager).when(mContext).getSystemService(NetworkStatsManager.class); mPreference = new SwitchPreference(mContext);