A separate entry for work profile CA cert

We mixed both primary and work profile CA certs into single entry previously which is not aligned with the CTS requirement. Separate them from now. Test: m -j RoboSettingsTest Test: Run related manual test in CtsVerifier Bug: 64567417 Change-Id: Iaff2d9f25ef15b96c11727e7075bdae8e90ec8ce
2017-08-18 11:08:20 +01:00
parent 6c9a1262be
commit c74bbcd3b2
14 changed files with 401 additions and 81 deletions
--- a/tests/robotests/src/com/android/settings/enterprise/CaCertsCurrentUserPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/enterprise/CaCertsCurrentUserPreferenceControllerTest.java
@@ -0,0 +1,88 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.enterprise;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import static org.mockito.Mockito.when;
+
+import android.support.v7.preference.Preference;
+
+import com.android.settings.R;
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.SettingsRobolectricTestRunner;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.robolectric.annotation.Config;
+
+/**
+ * Tests for {@link CaCertsCurrentUserPreferenceController}.
+ */
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
+public final class CaCertsCurrentUserPreferenceControllerTest extends
+        CaCertsPreferenceControllerTestBase {
+
+    private static final String CA_CERT_DEVICE = "CA certs";
+    private static final String CA_CERT_PERSONAL = "CA certs in personal profile";
+
+    @Before
+    public void mockGetString() {
+        when(mContext.getString(R.string.enterprise_privacy_ca_certs_device))
+                .thenReturn(CA_CERT_DEVICE);
+        when(mContext.getString(R.string.enterprise_privacy_ca_certs_personal))
+                .thenReturn(CA_CERT_PERSONAL);
+    }
+
+    @Test
+    public void testUpdateState_nonCompMode() {
+        assertUpdateState(false /* isCompMode */, CA_CERT_DEVICE);
+    }
+
+    @Test
+    public void testUpdateState_compMode() {
+        assertUpdateState(true /* isCompMode */, CA_CERT_PERSONAL);
+    }
+
+    @Override
+    void mockGetNumberOfCaCerts(int numOfCaCerts) {
+        when(mFeatureFactory.enterprisePrivacyFeatureProvider
+                .getNumberOfOwnerInstalledCaCertsForCurrentUser()).thenReturn(numOfCaCerts);
+    }
+
+    @Override
+    String getPreferenceKey() {
+        return CaCertsCurrentUserPreferenceController.CA_CERTS_CURRENT_USER;
+    }
+
+    @Override
+    CaCertsPreferenceControllerBase createController() {
+        return new CaCertsCurrentUserPreferenceController(mContext, null /* lifecycle */);
+    }
+
+    private void assertUpdateState(boolean isCompMode, String expectedTitle) {
+        final Preference preference = new Preference(mContext, null, 0, 0);
+
+        mockGetNumberOfCaCerts(2);
+        when(mFeatureFactory.enterprisePrivacyFeatureProvider.isInCompMode())
+                .thenReturn(isCompMode);
+        mController.updateState(preference);
+        assertThat(preference.getTitle()).isEqualTo(expectedTitle);
+    }
+}
--- a/tests/robotests/src/com/android/settings/enterprise/CaCertsManagedProfilePreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/enterprise/CaCertsManagedProfilePreferenceControllerTest.java
@@ -0,0 +1,50 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.enterprise;
+
+import static org.mockito.Mockito.when;
+
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.SettingsRobolectricTestRunner;
+
+import org.junit.runner.RunWith;
+import org.robolectric.annotation.Config;
+
+/**
+ * Tests for {@link CaCertsManagedProfilePreferenceController}.
+ */
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
+public final class CaCertsManagedProfilePreferenceControllerTest extends
+        CaCertsPreferenceControllerTestBase {
+
+    @Override
+    void mockGetNumberOfCaCerts(int numOfCaCerts) {
+        when(mFeatureFactory.enterprisePrivacyFeatureProvider
+                .getNumberOfOwnerInstalledCaCertsForManagedProfile()).thenReturn(numOfCaCerts);
+    }
+
+    @Override
+    String getPreferenceKey() {
+        return CaCertsManagedProfilePreferenceController.CA_CERTS_MANAGED_PROFILE;
+    }
+
+    @Override
+    CaCertsPreferenceControllerBase createController() {
+        return new CaCertsManagedProfilePreferenceController(mContext, null /* lifecycle */);
+    }
+}
--- a/tests/robotests/src/com/android/settings/enterprise/CaCertsPreferenceControllerBaseTest.java
+++ b/tests/robotests/src/com/android/settings/enterprise/CaCertsPreferenceControllerBaseTest.java
@@ -0,0 +1,66 @@
+/*
+ * Copyright (C) 2017 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.settings.enterprise;
+
+import android.content.Context;
+
+import com.android.settings.TestConfig;
+import com.android.settings.testutils.SettingsRobolectricTestRunner;
+
+import org.junit.runner.RunWith;
+import org.robolectric.annotation.Config;
+
+/**
+ * Tests for {@link CaCertsPreferenceControllerBase}.
+ */
+@RunWith(SettingsRobolectricTestRunner.class)
+@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
+public class CaCertsPreferenceControllerBaseTest extends CaCertsPreferenceControllerTestBase {
+    private static final String PREF_KEY = "pref";
+
+    private int mNumOfCaCerts;
+
+    void mockGetNumberOfCaCerts(int numOfCaCerts) {
+        mNumOfCaCerts = numOfCaCerts;
+    }
+
+    String getPreferenceKey() {
+        return PREF_KEY;
+    }
+
+    CaCertsPreferenceControllerBase createController() {
+        return new CaCertsPreferenceControllerBaseTestable(mContext);
+    }
+
+    private class CaCertsPreferenceControllerBaseTestable extends
+            CaCertsPreferenceControllerBase {
+
+        public CaCertsPreferenceControllerBaseTestable(Context context) {
+            super(context, null);
+        }
+
+        @Override
+        public String getPreferenceKey() {
+            return PREF_KEY;
+        }
+
+        @Override
+        protected int getNumberOfCaCerts() {
+            return mNumOfCaCerts;
+        }
+    }
+}
--- a/tests/robotests/src/com/android/settings/enterprise/CaCertsPreferenceControllerTestBase.java
+++ b/tests/robotests/src/com/android/settings/enterprise/CaCertsPreferenceControllerTestBase.java
@@ -16,50 +16,42 @@

 package com.android.settings.enterprise;

-import android.content.Context;
+import static com.google.common.truth.Truth.assertThat;

-import com.android.settings.R;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import android.content.Context;
 import android.support.v7.preference.Preference;

-import com.android.settings.testutils.SettingsRobolectricTestRunner;
-import com.android.settings.TestConfig;
+import com.android.settings.R;
 import com.android.settings.core.PreferenceAvailabilityObserver;
 import com.android.settings.testutils.FakeFeatureFactory;

 import org.junit.Before;
 import org.junit.Test;
-import org.junit.runner.RunWith;
 import org.mockito.Answers;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
-import org.robolectric.annotation.Config;
-
-import static com.google.common.truth.Truth.assertThat;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;

 /**
- * Tests for {@link CaCertsPreferenceController}.
+ * Base test class for testing {@link CaCertsPreferenceControllerBase}'s subclass.
 */
-@RunWith(SettingsRobolectricTestRunner.class)
-@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
-public final class CaCertsPreferenceControllerTest {
-
-    private static final String KEY_CA_CERTS = "ca_certs";
+public abstract class CaCertsPreferenceControllerTestBase {

    @Mock(answer = Answers.RETURNS_DEEP_STUBS)
-    private Context mContext;
-    private FakeFeatureFactory mFeatureFactory;
-    @Mock private PreferenceAvailabilityObserver mObserver;
-
-    private CaCertsPreferenceController mController;
+    protected Context mContext;
+    protected FakeFeatureFactory mFeatureFactory;
+    protected CaCertsPreferenceControllerBase mController;
+    @Mock
+    private PreferenceAvailabilityObserver mObserver;

    @Before
    public void setUp() {
        MockitoAnnotations.initMocks(this);
        FakeFeatureFactory.setupForTest(mContext);
        mFeatureFactory = (FakeFeatureFactory) FakeFeatureFactory.getFactory(mContext);
-        mController = new CaCertsPreferenceController(mContext, null /* lifecycle */);
+        mController = createController();
        mController.setAvailabilityObserver(mObserver);
    }

@@ -74,23 +66,20 @@ public final class CaCertsPreferenceControllerTest {

        when(mContext.getResources().getQuantityString(R.plurals.enterprise_privacy_number_ca_certs,
                10, 10)).thenReturn("10 certs");
-        when(mFeatureFactory.enterprisePrivacyFeatureProvider
-                .getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile()).thenReturn(10);
+        mockGetNumberOfCaCerts(10);
        mController.updateState(preference);
        assertThat(preference.getSummary()).isEqualTo("10 certs");
    }

    @Test
    public void testIsAvailable() {
-        when(mFeatureFactory.enterprisePrivacyFeatureProvider
-                .getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile()).thenReturn(0);
+        mockGetNumberOfCaCerts(0);
        assertThat(mController.isAvailable()).isFalse();
-        verify(mObserver).onPreferenceAvailabilityUpdated(KEY_CA_CERTS, false);
+        verify(mObserver).onPreferenceAvailabilityUpdated(getPreferenceKey(), false);

-        when(mFeatureFactory.enterprisePrivacyFeatureProvider
-                .getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile()).thenReturn(10);
+        mockGetNumberOfCaCerts(10);
        assertThat(mController.isAvailable()).isTrue();
-        verify(mObserver).onPreferenceAvailabilityUpdated(KEY_CA_CERTS, true);
+        verify(mObserver).onPreferenceAvailabilityUpdated(getPreferenceKey(), true);
    }

    @Test
@@ -101,6 +90,13 @@ public final class CaCertsPreferenceControllerTest {

    @Test
    public void testGetPreferenceKey() {
-        assertThat(mController.getPreferenceKey()).isEqualTo(KEY_CA_CERTS);
+        assertThat(mController.getPreferenceKey()).isEqualTo(getPreferenceKey());
    }
+
+    abstract void mockGetNumberOfCaCerts(int numOfCaCerts);
+
+    abstract String getPreferenceKey();
+
+    abstract CaCertsPreferenceControllerBase createController();
+
 }
--- a/tests/robotests/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImplTest.java
+++ b/tests/robotests/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImplTest.java
@@ -288,7 +288,7 @@ public final class EnterprisePrivacyFeatureProviderImplTest {
    }

    @Test
-    public void testGetNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile() {
+    public void testGetNumberOfOwnerInstalledCaCertsForCurrent() {
        final UserHandle userHandle = new UserHandle(UserHandle.USER_SYSTEM);
        final UserHandle managedProfileUserHandle = new UserHandle(MANAGED_PROFILE_USER_ID);
        final UserInfo managedProfile =
@@ -299,33 +299,44 @@ public final class EnterprisePrivacyFeatureProviderImplTest {

        when(mDevicePolicyManager.getOwnerInstalledCaCerts(userHandle))
                .thenReturn(null);
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUser())
                .isEqualTo(0);
        when(mDevicePolicyManager.getOwnerInstalledCaCerts(userHandle))
-                .thenReturn(new ArrayList<String>());
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
+                .thenReturn(new ArrayList<>());
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUser())
                .isEqualTo(0);
        when(mDevicePolicyManager.getOwnerInstalledCaCerts(userHandle))
                .thenReturn(Arrays.asList(new String[] {"ca1", "ca2"}));
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUser())
                .isEqualTo(2);
+    }

+    @Test
+    public void testGetNumberOfOwnerInstalledCaCertsForManagedProfile() {
+        final UserHandle userHandle = new UserHandle(UserHandle.USER_SYSTEM);
+        final UserHandle managedProfileUserHandle = new UserHandle(MANAGED_PROFILE_USER_ID);
+        final UserInfo managedProfile =
+                new UserInfo(MANAGED_PROFILE_USER_ID, "", "", UserInfo.FLAG_MANAGED_PROFILE);
+
+        // Without a profile
+        when(mDevicePolicyManager.getOwnerInstalledCaCerts(managedProfileUserHandle))
+                .thenReturn(Arrays.asList(new String[] {"ca1", "ca2"}));
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForManagedProfile())
+                .isEqualTo(0);
+
+        // With a profile
        mProfiles.add(managedProfile);
        when(mDevicePolicyManager.getOwnerInstalledCaCerts(managedProfileUserHandle))
                .thenReturn(null);
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
-                .isEqualTo(2);
-        when(mDevicePolicyManager.getOwnerInstalledCaCerts(managedProfileUserHandle))
-                .thenReturn(new ArrayList<String>());
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
-                .isEqualTo(2);
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForManagedProfile())
+                .isEqualTo(0);
+        when(mDevicePolicyManager.getOwnerInstalledCaCerts(userHandle))
+                .thenReturn(new ArrayList<>());
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForManagedProfile())
+                .isEqualTo(0);
        when(mDevicePolicyManager.getOwnerInstalledCaCerts(managedProfileUserHandle))
                .thenReturn(Arrays.asList(new String[] {"ca1", "ca2"}));
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
-                .isEqualTo(4);
-
-        mProfiles.remove(managedProfile);
-        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForCurrentUserAndManagedProfile())
+        assertThat(mProvider.getNumberOfOwnerInstalledCaCertsForManagedProfile())
                .isEqualTo(2);
    }

--- a/tests/robotests/src/com/android/settings/enterprise/EnterprisePrivacySettingsTest.java
+++ b/tests/robotests/src/com/android/settings/enterprise/EnterprisePrivacySettingsTest.java
@@ -128,7 +128,7 @@ public final class EnterprisePrivacySettingsTest {
    private void verifyPreferenceControllers(List<AbstractPreferenceController> controllers)
            throws Exception {
        assertThat(controllers).isNotNull();
-        assertThat(controllers.size()).isEqualTo(16);
+        assertThat(controllers.size()).isEqualTo(17);
        int position = 0;
        assertThat(controllers.get(position++)).isInstanceOf(NetworkLogsPreferenceController.class);
        assertThat(controllers.get(position++)).isInstanceOf(BugReportsPreferenceController.class);
@@ -152,7 +152,9 @@ public final class EnterprisePrivacySettingsTest {
        assertThat(controllers.get(position++)).isInstanceOf(
                GlobalHttpProxyPreferenceController.class);
        assertThat(controllers.get(position++)).isInstanceOf(
-                CaCertsPreferenceController.class);
+                CaCertsCurrentUserPreferenceController.class);
+        assertThat(controllers.get(position++)).isInstanceOf(
+                CaCertsManagedProfilePreferenceController.class);
        final AbstractPreferenceController exposureChangesCategoryController =
                controllers.get(position);
        final int exposureChangesCategoryControllerIndex = position;