Merge "Clean up InternetPreferenceController" into main
This commit is contained in:
Chaohui Wang
Android (Google) Code Review
@@ -1,152 +0,0 @@
|
||||
/*
|
||||
* Copyright (C) 2017 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.wifi;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.ArgumentMatchers.anyInt;
|
||||
import static org.mockito.ArgumentMatchers.anyString;
|
||||
import static org.mockito.Mockito.doNothing;
|
||||
import static org.mockito.Mockito.doReturn;
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.spy;
|
||||
import static org.mockito.Mockito.verify;
|
||||
|
||||
import android.content.BroadcastReceiver;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
import android.content.IntentFilter;
|
||||
import android.net.wifi.WifiManager;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.widget.SummaryUpdater.OnSummaryChangeListener;
|
||||
import com.android.settingslib.wifi.WifiStatusTracker;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.RobolectricTestRunner;
|
||||
import org.robolectric.RuntimeEnvironment;
|
||||
|
||||
@RunWith(RobolectricTestRunner.class)
|
||||
public class WifiSummaryUpdaterTest {
|
||||
@Mock private WifiStatusTracker mWifiTracker;
|
||||
@Mock private SummaryListener mListener;
|
||||
|
||||
private Context mContext;
|
||||
private WifiSummaryUpdater mSummaryUpdater;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
mContext = spy(RuntimeEnvironment.application.getApplicationContext());
|
||||
doReturn(mock(Intent.class)).when(mContext).registerReceiver(any(), any(), anyInt());
|
||||
doNothing().when(mContext).unregisterReceiver(any(BroadcastReceiver.class));
|
||||
|
||||
mSummaryUpdater = new WifiSummaryUpdater(mContext, mListener, mWifiTracker);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void register_true_shouldRegisterListenerAndTracker() {
|
||||
mSummaryUpdater.register(true);
|
||||
|
||||
verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class),
|
||||
anyInt());
|
||||
verify(mWifiTracker).setListening(true);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void register_true_shouldFetchInitialStateAndSendSummaryChange() {
|
||||
mSummaryUpdater.register(true);
|
||||
|
||||
verify(mWifiTracker).fetchInitialState();
|
||||
verify(mListener).onSummaryChanged(anyString());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void register_false_shouldUnregisterListenerAndTracker() {
|
||||
mSummaryUpdater.register(true);
|
||||
mSummaryUpdater.register(false);
|
||||
|
||||
verify(mContext).unregisterReceiver(any(BroadcastReceiver.class));
|
||||
verify(mWifiTracker).setListening(false);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void onReceive_networkStateChanged_shouldSendSummaryChange() {
|
||||
mSummaryUpdater.register(true);
|
||||
mContext.sendBroadcast(new Intent(WifiManager.NETWORK_STATE_CHANGED_ACTION));
|
||||
|
||||
verify(mListener).onSummaryChanged(anyString());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void onReceive_rssiChanged_shouldSendSummaryChange() {
|
||||
mSummaryUpdater.register(true);
|
||||
mContext.sendBroadcast(new Intent(WifiManager.RSSI_CHANGED_ACTION));
|
||||
|
||||
verify(mListener).onSummaryChanged(anyString());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getSummary_wifiDisabled_shouldReturnDisabled() {
|
||||
mWifiTracker.enabled = false;
|
||||
|
||||
assertThat(mSummaryUpdater.getSummary())
|
||||
.isEqualTo(mContext.getString(R.string.switch_off_text));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getSummary_wifiDisconnected_shouldReturnDisconnected() {
|
||||
mWifiTracker.enabled = true;
|
||||
mWifiTracker.connected = false;
|
||||
|
||||
assertThat(mSummaryUpdater.getSummary())
|
||||
.isEqualTo(mContext.getString(R.string.disconnected));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getSummary_wifiConnected_shouldReturnSsid() {
|
||||
mWifiTracker.enabled = true;
|
||||
mWifiTracker.connected = true;
|
||||
mWifiTracker.ssid = "Test Ssid";
|
||||
|
||||
assertThat(mSummaryUpdater.getSummary()).isEqualTo("Test Ssid");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getSummary_wifiConnected_withSpeedLabel_shouldReturnSsid_withSpeedLabel() {
|
||||
mWifiTracker.enabled = true;
|
||||
mWifiTracker.connected = true;
|
||||
mWifiTracker.ssid = "Test Ssid";
|
||||
mWifiTracker.statusLabel = "Very Fast";
|
||||
|
||||
assertThat(mSummaryUpdater.getSummary()).isEqualTo("Test Ssid / Very Fast");
|
||||
}
|
||||
|
||||
private class SummaryListener implements OnSummaryChangeListener {
|
||||
private String summary;
|
||||
|
||||
@Override
|
||||
public void onSummaryChanged(String summary) {
|
||||
this.summary = summary;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1,297 +0,0 @@
|
||||
/*
|
||||
* Copyright (C) 2020 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.network;
|
||||
|
||||
import static com.android.settings.network.InternetUpdater.INTERNET_NETWORKS_AVAILABLE;
|
||||
import static com.android.settings.network.InternetUpdater.INTERNET_WIFI;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.times;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
import android.content.BroadcastReceiver;
|
||||
import android.content.Context;
|
||||
import android.content.IntentFilter;
|
||||
import android.net.ConnectivityManager;
|
||||
import android.net.NetworkRequest;
|
||||
import android.net.NetworkScoreManager;
|
||||
import android.net.wifi.WifiManager;
|
||||
import android.os.Handler;
|
||||
import android.os.Looper;
|
||||
|
||||
import androidx.lifecycle.Lifecycle;
|
||||
import androidx.lifecycle.LifecycleOwner;
|
||||
import androidx.lifecycle.LifecycleRegistry;
|
||||
import androidx.preference.Preference;
|
||||
import androidx.preference.PreferenceManager;
|
||||
import androidx.preference.PreferenceScreen;
|
||||
import androidx.test.annotation.UiThreadTest;
|
||||
import androidx.test.core.app.ApplicationProvider;
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.testutils.ResourcesUtils;
|
||||
import com.android.settings.wifi.WifiPickerTrackerHelper;
|
||||
import com.android.settings.wifi.WifiSummaryUpdater;
|
||||
import com.android.settingslib.mobile.dataservice.SubscriptionInfoEntity;
|
||||
import com.android.wifitrackerlib.HotspotNetworkEntry;
|
||||
import com.android.wifitrackerlib.StandardWifiEntry;
|
||||
import com.android.wifitrackerlib.WifiPickerTracker;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Rule;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.Spy;
|
||||
import org.mockito.junit.MockitoJUnit;
|
||||
import org.mockito.junit.MockitoRule;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
@RunWith(AndroidJUnit4.class)
|
||||
public class InternetPreferenceControllerTest {
|
||||
|
||||
private static final String TEST_SUMMARY = "test summary";
|
||||
private static final String TEST_ALTERNATE_SUMMARY = "test alternate summary";
|
||||
private static final String NOT_CONNECTED = "Not connected";
|
||||
private static final String SUB_ID_1 = "1";
|
||||
private static final String SUB_ID_2 = "2";
|
||||
private static final String DISPLAY_NAME_1 = "Sub 1";
|
||||
private static final String DISPLAY_NAME_2 = "Sub 2";
|
||||
|
||||
@Rule
|
||||
public final MockitoRule mMockitoRule = MockitoJUnit.rule();
|
||||
@Spy
|
||||
private Context mContext = ApplicationProvider.getApplicationContext();
|
||||
@Mock
|
||||
private SubscriptionInfoEntity mActiveSubInfo;
|
||||
@Mock
|
||||
private SubscriptionInfoEntity mDefaultDataSubInfo;
|
||||
@Mock
|
||||
private ConnectivityManager mConnectivityManager;
|
||||
@Mock
|
||||
private LifecycleOwner mLifecycleOwner;
|
||||
@Mock
|
||||
private WifiManager mWifiManager;
|
||||
@Mock
|
||||
private WifiSummaryUpdater mSummaryHelper;
|
||||
@Mock
|
||||
private WifiPickerTrackerHelper mWifiPickerTrackerHelper;
|
||||
@Mock
|
||||
private WifiPickerTracker mWifiPickerTracker;
|
||||
@Mock
|
||||
private HotspotNetworkEntry mHotspotNetworkEntry;
|
||||
|
||||
private LifecycleRegistry mLifecycleRegistry;
|
||||
|
||||
private MockInternetPreferenceController mController;
|
||||
private PreferenceScreen mScreen;
|
||||
private Preference mPreference;
|
||||
private List<SubscriptionInfoEntity> mSubscriptionInfoEntityList = new ArrayList<>();
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
when(mContext.getSystemService(ConnectivityManager.class)).thenReturn(mConnectivityManager);
|
||||
when(mContext.getSystemService(NetworkScoreManager.class))
|
||||
.thenReturn(mock(NetworkScoreManager.class));
|
||||
when(mContext.getSystemService(Context.WIFI_SERVICE)).thenReturn(mWifiManager);
|
||||
when(mWifiManager.getWifiState()).thenReturn(WifiManager.WIFI_STATE_DISABLED);
|
||||
when(mWifiPickerTrackerHelper.getWifiPickerTracker()).thenReturn(mWifiPickerTracker);
|
||||
when(mWifiPickerTracker.getConnectedWifiEntry()).thenReturn(null /* WifiEntry */);
|
||||
when(mHotspotNetworkEntry.getAlternateSummary()).thenReturn(TEST_ALTERNATE_SUMMARY);
|
||||
|
||||
if (Looper.myLooper() == null) {
|
||||
Looper.prepare();
|
||||
}
|
||||
mLifecycleRegistry = new LifecycleRegistry(mLifecycleOwner);
|
||||
when(mLifecycleOwner.getLifecycle()).thenReturn(mLifecycleRegistry);
|
||||
mController = new MockInternetPreferenceController(mContext, mock(Lifecycle.class),
|
||||
mLifecycleOwner);
|
||||
mController.sIconMap.put(INTERNET_WIFI, 0);
|
||||
mController.mWifiPickerTrackerHelper = mWifiPickerTrackerHelper;
|
||||
|
||||
final PreferenceManager preferenceManager = new PreferenceManager(mContext);
|
||||
mScreen = preferenceManager.createPreferenceScreen(mContext);
|
||||
mPreference = new Preference(mContext);
|
||||
mPreference.setKey(InternetPreferenceController.KEY);
|
||||
mScreen.addPreference(mPreference);
|
||||
}
|
||||
|
||||
private class MockInternetPreferenceController extends
|
||||
com.android.settings.network.InternetPreferenceController {
|
||||
|
||||
private int mDefaultDataSubscriptionId;
|
||||
public MockInternetPreferenceController(Context context, Lifecycle lifecycle,
|
||||
LifecycleOwner lifecycleOwner) {
|
||||
super(context, lifecycle, lifecycleOwner);
|
||||
}
|
||||
|
||||
private List<SubscriptionInfoEntity> mSubscriptionInfoEntity;
|
||||
|
||||
@Override
|
||||
protected List<SubscriptionInfoEntity> getSubscriptionInfoList() {
|
||||
return mSubscriptionInfoEntity;
|
||||
}
|
||||
|
||||
public void setSubscriptionInfoList(List<SubscriptionInfoEntity> list) {
|
||||
mSubscriptionInfoEntity = list;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected int getDefaultDataSubscriptionId() {
|
||||
return mDefaultDataSubscriptionId;
|
||||
}
|
||||
|
||||
public void setDefaultDataSubscriptionId(int subscriptionId) {
|
||||
mDefaultDataSubscriptionId = subscriptionId;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
private SubscriptionInfoEntity setupSubscriptionInfoEntity(String subId, int slotId,
|
||||
String displayName, boolean isVisible, boolean isValid, boolean isActive,
|
||||
boolean isActiveData) {
|
||||
return new SubscriptionInfoEntity(subId, slotId, false, false, displayName, isVisible,
|
||||
false, isValid, isActive, isActiveData);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void isAvailable_shouldMatchPrefFlag() {
|
||||
assertThat(mController.isAvailable()).isEqualTo(
|
||||
mContext.getResources().getBoolean(R.bool.config_show_internet_settings));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void onResume_shouldRegisterCallback() {
|
||||
mController.onResume();
|
||||
|
||||
verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class),
|
||||
any(int.class));
|
||||
verify(mConnectivityManager).registerNetworkCallback(
|
||||
any(NetworkRequest.class),
|
||||
any(ConnectivityManager.NetworkCallback.class),
|
||||
any(Handler.class));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void onPause_shouldUnregisterCallback() {
|
||||
mController.onResume();
|
||||
mController.onPause();
|
||||
|
||||
verify(mContext, times(2)).unregisterReceiver(any(BroadcastReceiver.class));
|
||||
verify(mConnectivityManager, times(2)).unregisterNetworkCallback(
|
||||
any(ConnectivityManager.NetworkCallback.class));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void onSummaryChanged_internetWifi_updateSummary() {
|
||||
when(mSummaryHelper.getSummary()).thenReturn(TEST_SUMMARY);
|
||||
mController.mSummaryHelper = mSummaryHelper;
|
||||
mController.onInternetTypeChanged(INTERNET_WIFI);
|
||||
mController.displayPreference(mScreen);
|
||||
|
||||
mController.onSummaryChanged(TEST_SUMMARY);
|
||||
|
||||
assertThat(mPreference.getSummary()).isEqualTo(TEST_SUMMARY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void onSummaryChanged_internetNetworksAvailable_notUpdateSummary() {
|
||||
when(mSummaryHelper.getSummary()).thenReturn(TEST_SUMMARY);
|
||||
mController.mSummaryHelper = mSummaryHelper;
|
||||
mController.onInternetTypeChanged(INTERNET_NETWORKS_AVAILABLE);
|
||||
mController.displayPreference(mScreen);
|
||||
mPreference.setSummary(NOT_CONNECTED);
|
||||
|
||||
mController.onSummaryChanged(TEST_SUMMARY);
|
||||
|
||||
assertThat(mPreference.getSummary()).isNotEqualTo(TEST_SUMMARY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateCellularSummary_getNullSubscriptionInfo_shouldNotCrash() {
|
||||
mController.setSubscriptionInfoList(mSubscriptionInfoEntityList);
|
||||
|
||||
mController.updateCellularSummary();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateCellularSummary_getActiveSubscriptionInfo_cbrs() {
|
||||
mController.setDefaultDataSubscriptionId(Integer.parseInt(SUB_ID_2));
|
||||
mActiveSubInfo = setupSubscriptionInfoEntity(SUB_ID_1, 1, DISPLAY_NAME_1,
|
||||
false, true, true, true);
|
||||
mDefaultDataSubInfo = setupSubscriptionInfoEntity(SUB_ID_2, 1, DISPLAY_NAME_2,
|
||||
false, true, true, false);
|
||||
mSubscriptionInfoEntityList.add(mActiveSubInfo);
|
||||
mSubscriptionInfoEntityList.add(mDefaultDataSubInfo);
|
||||
mController.setSubscriptionInfoList(mSubscriptionInfoEntityList);
|
||||
mController.displayPreference(mScreen);
|
||||
|
||||
mController.updateCellularSummary();
|
||||
assertThat(mPreference.getSummary()).isEqualTo(DISPLAY_NAME_2);
|
||||
|
||||
mActiveSubInfo = setupSubscriptionInfoEntity(SUB_ID_1, 1, DISPLAY_NAME_1,
|
||||
true, true, true, true);
|
||||
mSubscriptionInfoEntityList.add(mActiveSubInfo);
|
||||
mController.setSubscriptionInfoList(mSubscriptionInfoEntityList);
|
||||
mController.onAvailableSubInfoChanged(mSubscriptionInfoEntityList);
|
||||
final String expectedSummary =
|
||||
ResourcesUtils.getResourcesString(mContext, "mobile_data_temp_using",
|
||||
DISPLAY_NAME_1);
|
||||
mController.updateCellularSummary();
|
||||
assertThat(mPreference.getSummary()).isEqualTo(expectedSummary);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateHotspotNetwork_isHotspotNetworkEntry_updateAlternateSummary() {
|
||||
when(mWifiPickerTracker.getConnectedWifiEntry()).thenReturn(mHotspotNetworkEntry);
|
||||
mController.onInternetTypeChanged(INTERNET_WIFI);
|
||||
mController.displayPreference(mScreen);
|
||||
mPreference.setSummary(TEST_SUMMARY);
|
||||
|
||||
mController.updateHotspotNetwork();
|
||||
|
||||
assertThat(mPreference.getSummary().toString()).isEqualTo(TEST_ALTERNATE_SUMMARY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateHotspotNetwork_notHotspotNetworkEntry_notChangeSummary() {
|
||||
when(mWifiPickerTracker.getConnectedWifiEntry()).thenReturn(mock(StandardWifiEntry.class));
|
||||
mController.onInternetTypeChanged(INTERNET_WIFI);
|
||||
mController.displayPreference(mScreen);
|
||||
mPreference.setSummary(TEST_SUMMARY);
|
||||
|
||||
mController.updateHotspotNetwork();
|
||||
|
||||
assertThat(mPreference.getSummary().toString()).isEqualTo(TEST_SUMMARY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void updateHotspotNetwork_hotspotNetworkNotEnabled_returnFalse() {
|
||||
mController.mWifiPickerTrackerHelper = null;
|
||||
|
||||
assertThat(mController.updateHotspotNetwork()).isFalse();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user