PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove no-used EntityHeaderController in Storage Settings

Browse Source 
The EntityHeaderController is a workaround to fix header
shadow, however, the header shadow does not exist and it's
safe to remove the EntityHeaderController.

Bug: 183078080
Test: manual visual
Change-Id: I5197ec62edbe7ab3ff981895ec7ff267caeb9448
This commit is contained in:
Arc Wang
2021-07-05 10:55:02 +08:00
parent e8a80850c1
commit c6d5dcfc6c
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/android/settings/deviceinfo/StorageCategoryFragment.java
View File

@@ -44,7 +44,6 @@ import com.android.settings.deviceinfo.storage.StorageItemPreferenceController;
import com.android.settings.deviceinfo.storage.UserIconLoader;
import com.android.settings.deviceinfo.storage.VolumeSizesLoader;
import com.android.settings.overlay.FeatureFactory;
import com.android.settings.widget.EntityHeaderController;
import com.android.settingslib.applications.StorageStatsSource;
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
@@ -161,15 +160,6 @@ public class StorageCategoryFragment extends DashboardFragment
super.onAttach(context);
}
@Override
public void onViewCreated(View v, Bundle savedInstanceState) {
super.onViewCreated(v, savedInstanceState);
EntityHeaderController.newInstance(getActivity(), this /*fragment*/,
null /* header view */)
.setRecyclerView(getListView(), getSettingsLifecycle());
}
@Override
public void onResume() {
super.onResume();

10
src/com/android/settings/deviceinfo/StorageDashboardFragment.java
View File

@@ -56,7 +56,6 @@ import com.android.settings.deviceinfo.storage.UserIconLoader;
import com.android.settings.deviceinfo.storage.VolumeSizesLoader;
import com.android.settings.overlay.FeatureFactory;
import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.widget.EntityHeaderController;
import com.android.settingslib.applications.StorageStatsSource;
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
@@ -320,15 +319,6 @@ public class StorageDashboardFragment extends DashboardFragment
activity.invalidateOptionsMenu();
}
@Override
public void onViewCreated(View v, Bundle savedInstanceState) {
super.onViewCreated(v, savedInstanceState);
EntityHeaderController.newInstance(getActivity(), this /*fragment*/,
null /* header view */)
.setRecyclerView(getListView(), getSettingsLifecycle());
}
@Override
public void onResume() {
super.onResume();