Display App installed in other user in All Apps

Only for admin user.

Also clean up unused getInstallationStatus().

Fix: 277299765
Test: Manually with All Apps when multiple users is on
Test: Unit test
Change-Id: I4de681c101a605e3517dcd8765bf7a95d1b76417

tests/robotests/src/com/android/settings/UtilsTest.java

@@ -160,30 +160,6 @@ public class UtilsTest {
         Utils.maybeInitializeVolume(storageManager, new Bundle());
     }
 
-    @Test
-    public void getInstallationStatus_notInstalled_shouldReturnUninstalled() {
-        assertThat(Utils.getInstallationStatus(new ApplicationInfo()))
-                .isEqualTo(R.string.not_installed);
-    }
-
-    @Test
-    public void getInstallationStatus_enabled_shouldReturnInstalled() {
-        final ApplicationInfo info = new ApplicationInfo();
-        info.flags = ApplicationInfo.FLAG_INSTALLED;
-        info.enabled = true;
-
-        assertThat(Utils.getInstallationStatus(info)).isEqualTo(R.string.installed);
-    }
-
-    @Test
-    public void getInstallationStatus_disabled_shouldReturnDisabled() {
-        final ApplicationInfo info = new ApplicationInfo();
-        info.flags = ApplicationInfo.FLAG_INSTALLED;
-        info.enabled = false;
-
-        assertThat(Utils.getInstallationStatus(info)).isEqualTo(R.string.disabled);
-    }
-
     @Test
     public void isProfileOrDeviceOwner_deviceOwnerApp_returnTrue() {
         when(mDevicePolicyManager.isDeviceOwnerAppOnAnyUser(PACKAGE_NAME)).thenReturn(true);

tests/spa_unit/src/com/android/settings/spa/app/AllAppListTest.kt

@@ -147,6 +147,7 @@ class AllAppListTest {
         val listModel = AllAppListModel(context) { stateOf(SUMMARY) }
         val disabledApp = ApplicationInfo().apply {
             packageName = PACKAGE_NAME
+            flags = ApplicationInfo.FLAG_INSTALLED
             enabled = false
         }
 
@@ -159,6 +160,23 @@ class AllAppListTest {
         assertThat(summaryState.value).isEqualTo("$SUMMARY${System.lineSeparator()}Disabled")
     }
 
+    @Test
+    fun allAppListModel_getSummaryWhenNotInstalled() {
+        val listModel = AllAppListModel(context) { stateOf(SUMMARY) }
+        val notInstalledApp = ApplicationInfo().apply {
+            packageName = PACKAGE_NAME
+        }
+
+        lateinit var summaryState: State<String>
+        composeTestRule.setContent {
+            summaryState =
+                listModel.getSummary(option = 0, record = AppRecordWithSize(app = notInstalledApp))
+        }
+
+        assertThat(summaryState.value)
+            .isEqualTo("$SUMMARY${System.lineSeparator()}Not installed for this user")
+    }
+
     private fun getAppListInput(): AppListInput<AppRecordWithSize> {
         lateinit var input: AppListInput<AppRecordWithSize>
         composeTestRule.setContent {
@@ -192,6 +210,7 @@ class AllAppListTest {
         const val SUMMARY = "Summary"
         val APP = ApplicationInfo().apply {
             packageName = PACKAGE_NAME
+            flags = ApplicationInfo.FLAG_INSTALLED
         }
     }
 }

tests/spa_unit/src/com/android/settings/spa/app/appinfo/AppNotificationPreferenceTest.kt

@@ -21,6 +21,7 @@ import android.content.pm.ApplicationInfo
 import androidx.compose.runtime.CompositionLocalProvider
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.test.assertIsDisplayed
+import androidx.compose.ui.test.assertIsNotEnabled
 import androidx.compose.ui.test.junit4.createComposeRule
 import androidx.compose.ui.test.onNodeWithText
 import androidx.compose.ui.test.onRoot
@@ -72,7 +73,7 @@ class AppNotificationPreferenceTest {
 
     @Test
     fun title_displayed() {
-        setContent()
+        setContent(APP)
 
         composeTestRule.onNodeWithText(context.getString(R.string.notifications_label))
             .assertIsDisplayed()
@@ -80,14 +81,25 @@ class AppNotificationPreferenceTest {
 
     @Test
     fun summary_displayed() {
-        setContent()
+        setContent(APP)
 
         composeTestRule.onNodeWithText(SUMMARY).assertIsDisplayed()
     }
 
+    @Test
+    fun whenNotInstalled_disable() {
+        setContent(ApplicationInfo().apply {
+            packageName = PACKAGE_NAME
+            uid = UID
+        })
+
+        composeTestRule.onNodeWithText(context.getString(R.string.notifications_label))
+            .assertIsNotEnabled()
+    }
+
     @Test
     fun onClick_startActivity() {
-        setContent()
+        setContent(APP)
 
         composeTestRule.onRoot().performClick()
         composeTestRule.delay()
@@ -102,10 +114,10 @@ class AppNotificationPreferenceTest {
         }
     }
 
-    private fun setContent() {
+    private fun setContent(app: ApplicationInfo) {
         composeTestRule.setContent {
             CompositionLocalProvider(LocalContext provides context) {
-                AppNotificationPreference(app = APP, repository = repository)
+                AppNotificationPreference(app = app, repository = repository)
             }
         }
     }
@@ -116,6 +128,7 @@ class AppNotificationPreferenceTest {
         val APP = ApplicationInfo().apply {
             packageName = PACKAGE_NAME
             uid = UID
+            flags = ApplicationInfo.FLAG_INSTALLED
         }
         const val SUMMARY = "Summary"
     }

tests/spa_unit/src/com/android/settings/spa/app/specialaccess/PictureInPictureTest.kt

@@ -167,6 +167,7 @@ class PictureInPictureTest {
         const val PICTURE_IN_PICTURE_PACKAGE_NAME = "picture.in.picture.package.name"
         val PICTURE_IN_PICTURE_APP = ApplicationInfo().apply {
             packageName = PICTURE_IN_PICTURE_PACKAGE_NAME
+            flags = ApplicationInfo.FLAG_INSTALLED
         }
         val PICTURE_IN_PICTURE_PACKAGE_INFO = PackageInfo().apply {
             packageName = PICTURE_IN_PICTURE_PACKAGE_NAME