Clean up ShadowUserManager

Remove addManagedUser() and use default shadow for the same purpose.

Test: make RunSettingsRoboTests -j40 ROBOTEST_FILTER=Redaction
Change-Id: I2f86bd51bccbde23a8a37d19b28e30cadb2b9f93
This commit is contained in:
Fan Zhang
2019-01-28 16:32:56 -08:00
parent 5c3301b0ab
commit c52a581bb7
2 changed files with 9 additions and 13 deletions

View File

@@ -12,6 +12,7 @@ import static org.robolectric.Robolectric.buildActivity;
import android.content.ContentResolver; import android.content.ContentResolver;
import android.content.Intent; import android.content.Intent;
import android.os.UserHandle; import android.os.UserHandle;
import android.os.UserManager;
import android.provider.Settings; import android.provider.Settings;
import android.view.View; import android.view.View;
import android.widget.RadioButton; import android.widget.RadioButton;
@@ -20,7 +21,6 @@ import com.android.settings.R;
import com.android.settings.RestrictedRadioButton; import com.android.settings.RestrictedRadioButton;
import com.android.settings.notification.RedactionInterstitial.RedactionInterstitialFragment; import com.android.settings.notification.RedactionInterstitial.RedactionInterstitialFragment;
import com.android.settings.testutils.shadow.ShadowRestrictedLockUtilsInternal; import com.android.settings.testutils.shadow.ShadowRestrictedLockUtilsInternal;
import com.android.settings.testutils.shadow.ShadowUserManager;
import com.android.settings.testutils.shadow.ShadowUtils; import com.android.settings.testutils.shadow.ShadowUtils;
import org.junit.After; import org.junit.After;
@@ -30,12 +30,13 @@ import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner; import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment; import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config; import org.robolectric.annotation.Config;
import org.robolectric.shadow.api.Shadow;
import org.robolectric.shadows.ShadowUserManager;
@RunWith(RobolectricTestRunner.class) @RunWith(RobolectricTestRunner.class)
@Config(shadows = { @Config(shadows = {
ShadowUtils.class, ShadowUtils.class,
ShadowRestrictedLockUtilsInternal.class, ShadowRestrictedLockUtilsInternal.class,
ShadowUserManager.class,
}) })
public class RedactionInterstitialTest { public class RedactionInterstitialTest {
private RedactionInterstitial mActivity; private RedactionInterstitial mActivity;
@@ -103,7 +104,9 @@ public class RedactionInterstitialTest {
@Test @Test
public void managedProfileNoRestrictionsTest() { public void managedProfileNoRestrictionsTest() {
setupSettings(1 /* show */, 1 /* showUnredacted */); setupSettings(1 /* show */, 1 /* showUnredacted */);
ShadowUserManager.getShadow().addManagedProfile(UserHandle.myUserId()); final ShadowUserManager sum =
Shadow.extract(RuntimeEnvironment.application.getSystemService(UserManager.class));
sum.setManagedProfile(true);
setupActivity(); setupActivity();
assertHideAllVisible(false); assertHideAllVisible(false);
@@ -114,7 +117,9 @@ public class RedactionInterstitialTest {
@Test @Test
public void managedProfileUnredactedRestrictionTest() { public void managedProfileUnredactedRestrictionTest() {
setupSettings(1 /* show */, 1 /* showUnredacted */); setupSettings(1 /* show */, 1 /* showUnredacted */);
ShadowUserManager.getShadow().addManagedProfile(UserHandle.myUserId()); final ShadowUserManager sum =
Shadow.extract(RuntimeEnvironment.application.getSystemService(UserManager.class));
sum.setManagedProfile(true);
ShadowRestrictedLockUtilsInternal.setKeyguardDisabledFeatures( ShadowRestrictedLockUtilsInternal.setKeyguardDisabledFeatures(
KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS); KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS);
setupActivity(); setupActivity();

View File

@@ -98,15 +98,6 @@ public class ShadowUserManager extends org.robolectric.shadows.ShadowUserManager
mRestrictionSources.put(restrictionKey + userHandle.getIdentifier(), enforcers); mRestrictionSources.put(restrictionKey + userHandle.getIdentifier(), enforcers);
} }
@Implementation
protected boolean isManagedProfile(@UserIdInt int userId) {
return mManagedProfiles.contains(userId);
}
public void addManagedProfile(int userId) {
mManagedProfiles.add(userId);
}
@Implementation @Implementation
protected boolean isQuietModeEnabled(UserHandle userHandle) { protected boolean isQuietModeEnabled(UserHandle userHandle) {
return mIsQuietModeEnabled; return mIsQuietModeEnabled;