Update Network & internet->Wi-Fi to use MasterSwitchPreference.
- Add a preference controller for Network & internet->Wi-Fi to control the preference toggling and summary update. - Refactor WifiSettings and WifiEnabler to share code between the new wifi preference controller and the wifi setting. - Refactor BluetoothSummaryHelper to have a common base class with the WifiSummaryHelper. - Rename the summary helper to summary updater. Bug: 34280769 Test: make RunSettingsRoboTests Change-Id: I00ebfc161bcef89331bb41ba405ed8cb8232d248
This commit is contained in:
@@ -0,0 +1,126 @@
|
||||
/*
|
||||
* Copyright (C) 2017 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.settings.widget;
|
||||
|
||||
import android.content.Context;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.SettingsRobolectricTestRunner;
|
||||
import com.android.settings.TestConfig;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Answers;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.RuntimeEnvironment;
|
||||
import org.robolectric.annotation.Config;
|
||||
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.times;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
@RunWith(SettingsRobolectricTestRunner.class)
|
||||
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
||||
public class SummaryUpdaterTest {
|
||||
|
||||
private Context mContext;
|
||||
|
||||
private SummaryUpdaterTestable mSummaryUpdater;
|
||||
@Mock
|
||||
private SummaryListener mListener;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
mContext = RuntimeEnvironment.application.getApplicationContext();
|
||||
mSummaryUpdater = new SummaryUpdaterTestable(mContext, mListener);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void notifyChangeIfNeeded_fistTimeInit_shouldNotifyChange() {
|
||||
final String summary = "initialized";
|
||||
mSummaryUpdater.setTestSummary(summary);
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
|
||||
verify(mListener).onSummaryChanged(summary);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void notifyChangeIfNeeded_summaryUpdated_shouldNotifyChange() {
|
||||
final String summaryInit = "initialized";
|
||||
mSummaryUpdater.setTestSummary(summaryInit);
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
final String summaryUpdate = "updated";
|
||||
|
||||
mSummaryUpdater.setTestSummary(summaryUpdate);
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
|
||||
verify(mListener).onSummaryChanged(summaryUpdate);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void notifyChangeIfNeeded_summaryNotUpdated_shouldOnlyNotifyChangeOnce() {
|
||||
final String summaryInit = "initialized";
|
||||
mSummaryUpdater.setTestSummary(summaryInit);
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
final String summaryUpdate = "updated";
|
||||
mSummaryUpdater.setTestSummary(summaryUpdate);
|
||||
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
mSummaryUpdater.notifyChangeIfNeeded();
|
||||
|
||||
verify(mListener, times(1)).onSummaryChanged(summaryUpdate);
|
||||
}
|
||||
|
||||
private class SummaryListener implements SummaryUpdater.OnSummaryChangeListener {
|
||||
String summary;
|
||||
|
||||
@Override
|
||||
public void onSummaryChanged(String summary) {
|
||||
this.summary = summary;
|
||||
}
|
||||
}
|
||||
|
||||
public final class SummaryUpdaterTestable extends SummaryUpdater {
|
||||
private String mTestSummary;
|
||||
|
||||
SummaryUpdaterTestable(Context context, SummaryUpdater.OnSummaryChangeListener listener) {
|
||||
super(context, listener);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void register(boolean register) {
|
||||
}
|
||||
|
||||
@Override
|
||||
public void notifyChangeIfNeeded() {
|
||||
super.notifyChangeIfNeeded();
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getSummary() {
|
||||
return mTestSummary;
|
||||
}
|
||||
|
||||
public void setTestSummary(String summary) {
|
||||
mTestSummary = summary;
|
||||
}
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user