Add misc logging:
- Button clicks in app detail page: uninstall/disable/clear data/clear cache - More logging in search: log inline search result click, and its metadata such as name/value/rank. Fix: 32652772 Fix: 32798201 Test: make RunSettingsRoboTests Change-Id: I90cef7c9ea9ea69ea9cf083013a38417097f8594
This commit is contained in:
@@ -19,9 +19,10 @@ package com.android.settings.search;
|
||||
|
||||
import android.content.Context;
|
||||
import android.graphics.drawable.Drawable;
|
||||
import android.util.Pair;
|
||||
import android.view.LayoutInflater;
|
||||
import android.view.View;
|
||||
|
||||
import com.android.internal.logging.nano.MetricsProto;
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.SettingsRobolectricTestRunner;
|
||||
import com.android.settings.TestConfig;
|
||||
@@ -29,19 +30,24 @@ import com.android.settings.search2.InlineSwitchPayload;
|
||||
import com.android.settings.search2.InlineSwitchViewHolder;
|
||||
import com.android.settings.search2.SearchFragment;
|
||||
import com.android.settings.search2.SearchResult;
|
||||
import com.android.settings.testutils.FakeFeatureFactory;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Answers;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.RuntimeEnvironment;
|
||||
import org.robolectric.annotation.Config;
|
||||
import org.robolectric.shadows.ShadowApplication;
|
||||
import org.robolectric.util.ReflectionHelpers;
|
||||
|
||||
import java.util.ArrayList;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
import static org.mockito.Matchers.any;
|
||||
import static org.mockito.Matchers.eq;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
@RunWith(SettingsRobolectricTestRunner.class)
|
||||
@@ -51,22 +57,31 @@ public class InlineSwitchViewHolderTest {
|
||||
private static final String TITLE = "title";
|
||||
private static final String SUMMARY = "summary";
|
||||
|
||||
@Mock(answer = Answers.RETURNS_DEEP_STUBS)
|
||||
private Context mContext;
|
||||
@Mock
|
||||
private SearchFragment mFragment;
|
||||
|
||||
@Mock
|
||||
private InlineSwitchPayload mPayload;
|
||||
|
||||
private FakeFeatureFactory mFeatureFactory;
|
||||
private InlineSwitchViewHolder mHolder;
|
||||
private Drawable mIcon;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
final Context context = ShadowApplication.getInstance().getApplicationContext();
|
||||
View view = LayoutInflater.from(context).inflate(R.layout.search_inline_switch_item, null);
|
||||
mHolder = new InlineSwitchViewHolder(view, context);
|
||||
|
||||
final Context context = RuntimeEnvironment.application;
|
||||
mIcon = context.getDrawable(R.drawable.ic_search_history);
|
||||
FakeFeatureFactory.setupForTest(mContext);
|
||||
mFeatureFactory = (FakeFeatureFactory) FakeFeatureFactory.getFactory(mContext);
|
||||
|
||||
mHolder = new InlineSwitchViewHolder(
|
||||
LayoutInflater.from(context).inflate(R.layout.search_inline_switch_item, null),
|
||||
context);
|
||||
ReflectionHelpers.setField(mHolder, "mMetricsFeatureProvider",
|
||||
mFeatureFactory.metricsFeatureProvider);
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -82,12 +97,19 @@ public class InlineSwitchViewHolderTest {
|
||||
when(mPayload.getSwitchValue(any(Context.class))).thenReturn(true);
|
||||
SearchResult result = getSearchResult();
|
||||
mHolder.onBind(mFragment, result);
|
||||
mHolder.switchView.setChecked(true);
|
||||
// Precondition: switch is on.
|
||||
assertThat(mHolder.switchView.isChecked()).isTrue();
|
||||
|
||||
mHolder.switchView.performClick();
|
||||
|
||||
verify(mFeatureFactory.metricsFeatureProvider).action(
|
||||
any(Context.class),
|
||||
eq(MetricsProto.MetricsEvent.ACTION_CLICK_SETTINGS_SEARCH_INLINE_RESULT),
|
||||
any(Pair.class), any(Pair.class), any(Pair.class));
|
||||
assertThat(mHolder.titleView.getText()).isEqualTo(TITLE);
|
||||
assertThat(mHolder.summaryView.getText()).isEqualTo(SUMMARY);
|
||||
assertThat(mHolder.iconView.getDrawable()).isEqualTo(mIcon);
|
||||
assertThat(mHolder.switchView.isChecked()).isTrue();
|
||||
assertThat(mHolder.switchView.isChecked()).isFalse();
|
||||
}
|
||||
|
||||
private SearchResult getSearchResult() {
|
||||
|
Reference in New Issue
Block a user