From 1a253baae4a0212a344db5a3f9a04f74c8083e04 Mon Sep 17 00:00:00 2001 From: Calvin Pan Date: Wed, 18 May 2022 09:32:52 +0000 Subject: [PATCH] Avoid getting app locale config for each app Getting app locale config will spend a lot of time. Removing the log to prevent getting locale-config for each system app. Bug: 232557302 Test: Saving about 80% under java stack tracing mode Change-Id: I2e755286a4e493be7fd73028ade8d190f6571e46 --- .../settings/applications/AppLocaleUtil.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/com/android/settings/applications/AppLocaleUtil.java b/src/com/android/settings/applications/AppLocaleUtil.java index 31357968a07..8c3671ed943 100644 --- a/src/com/android/settings/applications/AppLocaleUtil.java +++ b/src/com/android/settings/applications/AppLocaleUtil.java @@ -49,17 +49,17 @@ public class AppLocaleUtil { boolean isDisallowedPackage = isDisallowedPackage(context, packageName); boolean hasLauncherEntry = hasLauncherEntry(packageName, infos); boolean isSignedWithPlatformKey = isSignedWithPlatformKey(context, packageName); - boolean isAppLocaleSupported = isAppLocaleSupported(context, packageName); + boolean canDisplay = !isDisallowedPackage + && !isSignedWithPlatformKey + && hasLauncherEntry + && isAppLocaleSupported(context, packageName); + Log.i(TAG, "Can display preference - [" + packageName + "] :" + " isDisallowedPackage : " + isDisallowedPackage + " / isSignedWithPlatformKey : " + isSignedWithPlatformKey + " / hasLauncherEntry : " + hasLauncherEntry - + " / isAppLocaleSupported : " + isAppLocaleSupported); - - return !isDisallowedPackage - && !isSignedWithPlatformKey - && hasLauncherEntry - && isAppLocaleSupported; + + " / canDisplay : " + canDisplay); + return canDisplay; } private static boolean isDisallowedPackage(Context context, String packageName) {