Adds a menu item for additional battery info to battery settings.

am: 7b557df0e4

Change-Id: Iaef847979f64bf93b87457fa3f2f734b1789c830
This commit is contained in:
Jaewoong Jung
2017-01-13 22:40:38 +00:00
committed by android-build-merger
6 changed files with 55 additions and 4 deletions

View File

@@ -6898,6 +6898,9 @@
<!-- Label for list to control apps that ignore battery saving restrictions [CHAR LIMIT=27]--> <!-- Label for list to control apps that ignore battery saving restrictions [CHAR LIMIT=27]-->
<string name="high_power_apps">Battery optimization</string> <string name="high_power_apps">Battery optimization</string>
<!-- Label for menu to launch additional battery info -->
<string name="additional_battery_info" translatable="false">Additional battery info</string>
<!-- Filter for apps allowed to use a lot of power [CHAR LIMIT=25] --> <!-- Filter for apps allowed to use a lot of power [CHAR LIMIT=25] -->
<string name="high_power_filter_on">Not optimized</string> <string name="high_power_filter_on">Not optimized</string>

View File

@@ -25,6 +25,7 @@ import android.os.Bundle;
import android.os.Handler; import android.os.Handler;
import android.os.Message; import android.os.Message;
import android.os.UserManager; import android.os.UserManager;
import android.support.annotation.VisibleForTesting;
import android.view.Menu; import android.view.Menu;
import android.view.MenuInflater; import android.view.MenuInflater;
import android.view.MenuItem; import android.view.MenuItem;
@@ -39,7 +40,8 @@ import com.android.settings.SettingsPreferenceFragment;
public abstract class PowerUsageBase extends SettingsPreferenceFragment { public abstract class PowerUsageBase extends SettingsPreferenceFragment {
// +1 to allow ordering for PowerUsageSummary. // +1 to allow ordering for PowerUsageSummary.
private static final int MENU_STATS_REFRESH = Menu.FIRST + 1; @VisibleForTesting
static final int MENU_STATS_REFRESH = Menu.FIRST + 1;
protected BatteryStatsHelper mStatsHelper; protected BatteryStatsHelper mStatsHelper;
protected UserManager mUm; protected UserManager mUm;

View File

@@ -0,0 +1,25 @@
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.fuelgauge;
/**
* Feature Provider used in power usage
*/
public interface PowerUsageFeatureProvider {
boolean isAdditionalBatteryInfoEnabled();
}

View File

@@ -26,6 +26,7 @@ import android.os.Handler;
import android.os.Message; import android.os.Message;
import android.os.Process; import android.os.Process;
import android.os.UserHandle; import android.os.UserHandle;
import android.support.annotation.VisibleForTesting;
import android.support.v7.preference.Preference; import android.support.v7.preference.Preference;
import android.support.v7.preference.PreferenceGroup; import android.support.v7.preference.PreferenceGroup;
import android.text.TextUtils; import android.text.TextUtils;
@@ -43,6 +44,7 @@ import com.android.settings.Settings.HighPowerApplicationsActivity;
import com.android.settings.SettingsActivity; import com.android.settings.SettingsActivity;
import com.android.settings.applications.ManageApplications; import com.android.settings.applications.ManageApplications;
import com.android.settings.dashboard.SummaryLoader; import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.overlay.FeatureFactory;
import com.android.settingslib.BatteryInfo; import com.android.settingslib.BatteryInfo;
import java.util.ArrayList; import java.util.ArrayList;
@@ -67,7 +69,9 @@ public class PowerUsageSummary extends PowerUsageBase {
private static final int MENU_STATS_TYPE = Menu.FIRST; private static final int MENU_STATS_TYPE = Menu.FIRST;
private static final int MENU_HIGH_POWER_APPS = Menu.FIRST + 3; private static final int MENU_HIGH_POWER_APPS = Menu.FIRST + 3;
private static final int MENU_HELP = Menu.FIRST + 4; @VisibleForTesting
static final int MENU_ADDITIONAL_BATTERY_INFO = Menu.FIRST + 4;
private static final int MENU_HELP = Menu.FIRST + 5;
private BatteryHistoryPreference mHistPref; private BatteryHistoryPreference mHistPref;
private PreferenceGroup mAppListGroup; private PreferenceGroup mAppListGroup;
@@ -130,12 +134,20 @@ public class PowerUsageSummary extends PowerUsageBase {
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
if (DEBUG) { if (DEBUG) {
menu.add(0, MENU_STATS_TYPE, 0, R.string.menu_stats_total) menu.add(Menu.NONE, MENU_STATS_TYPE, Menu.NONE, R.string.menu_stats_total)
.setIcon(com.android.internal.R.drawable.ic_menu_info_details) .setIcon(com.android.internal.R.drawable.ic_menu_info_details)
.setAlphabeticShortcut('t'); .setAlphabeticShortcut('t');
} }
menu.add(0, MENU_HIGH_POWER_APPS, 0, R.string.high_power_apps); menu.add(Menu.NONE, MENU_HIGH_POWER_APPS, Menu.NONE, R.string.high_power_apps);
PowerUsageFeatureProvider powerUsageFeatureProvider =
FeatureFactory.getFactory(getContext()).getPowerUsageFeatureProvider(getContext());
if (powerUsageFeatureProvider != null &&
powerUsageFeatureProvider.isAdditionalBatteryInfoEnabled()) {
menu.add(Menu.NONE, MENU_ADDITIONAL_BATTERY_INFO,
Menu.NONE, R.string.additional_battery_info);
}
super.onCreateOptionsMenu(menu, inflater); super.onCreateOptionsMenu(menu, inflater);
} }

View File

@@ -21,6 +21,7 @@ import android.text.TextUtils;
import android.util.Log; import android.util.Log;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.fuelgauge.PowerUsageFeatureProvider;
/** /**
* Abstract class for creating feature controllers. Allows OEM implementations to define their own * Abstract class for creating feature controllers. Allows OEM implementations to define their own
@@ -61,6 +62,8 @@ public abstract class FeatureFactory {
public abstract SupportFeatureProvider getSupportFeatureProvider(Context context); public abstract SupportFeatureProvider getSupportFeatureProvider(Context context);
public abstract PowerUsageFeatureProvider getPowerUsageFeatureProvider(Context context);
public abstract SurveyFeatureProvider getSurveyFeatureProvider(Context context); public abstract SurveyFeatureProvider getSurveyFeatureProvider(Context context);
public static final class FactoryNotFoundException extends RuntimeException { public static final class FactoryNotFoundException extends RuntimeException {

View File

@@ -18,6 +18,7 @@ package com.android.settings.overlay;
import android.content.Context; import android.content.Context;
import android.support.annotation.Keep; import android.support.annotation.Keep;
import com.android.settings.fuelgauge.PowerUsageFeatureProvider;
/** /**
* {@link FeatureFactory} implementation for AOSP Settings. * {@link FeatureFactory} implementation for AOSP Settings.
@@ -30,6 +31,11 @@ public class FeatureFactoryImpl extends FeatureFactory {
return null; return null;
} }
@Override
public PowerUsageFeatureProvider getPowerUsageFeatureProvider(Context context) {
return null;
}
@Override @Override
public SurveyFeatureProvider getSurveyFeatureProvider(Context context) { public SurveyFeatureProvider getSurveyFeatureProvider(Context context) {
return null; return null;