PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hide extra information link when it is empty

Browse Source 
Extra information may be or may not be provided as this is given from the Carriers, therefore it is needed to hide when there is no given URL string

Bug: 360265682
Flag: EXEMPT bugfix
Test: manually test when extra information is valid and when extra information is empty
      https://b.corp.google.com/issues/360265682#comment2 for UI test
result

Change-Id: Icf7f06e6af8580d0e84382a2598be75e321cf657
This commit is contained in:
Hakjun Choi
2024-10-04 09:13:50 +00:00
parent 5087754b42
commit c2c2722771
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/com/android/settings/network/telephony/SatelliteSetting.java
View File

@@ -195,19 +195,19 @@ public class SatelliteSetting extends RestrictedDashboardFragment {
final String[] link = new String[1]; final String[] link = new String[1];
link[0] = readSatelliteMoreInfoString(mSubId); link[0] = readSatelliteMoreInfoString(mSubId);
footerPreference.setLearnMoreAction(view -> { if (link[0] != null && !link[0].isEmpty()) {
if (!link[0].isEmpty()) { footerPreference.setLearnMoreAction(view -> {
Intent helpIntent = HelpUtils.getHelpIntent(mActivity, link[0], if (!link[0].isEmpty()) {
this.getClass().getName()); Intent helpIntent = HelpUtils.getHelpIntent(mActivity, link[0],
if (helpIntent != null) { this.getClass().getName());
mActivity.startActivityForResult(helpIntent, /*requestCode=*/ 0); if (helpIntent != null) {
mActivity.startActivityForResult(helpIntent, /*requestCode=*/ 0);
}
} }
} });
}); footerPreference.setLearnMoreText(
footerPreference.setLearnMoreText( getResources().getString(R.string.more_about_satellite_messaging));
getResources().getString(R.string.more_about_satellite_messaging)); }
// TODO : b/320467418 add rounded rectangle border line to footer preference.
} }
} }