PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix typo in metrics constants"

Browse Source
This commit is contained in:
TreeHugger Robot
2017-06-26 21:06:45 +00:00
committed by Android (Google) Code Review
parent 1d583e125f 9861c95577
commit c26ae0677e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/android/settings/search/SearchFragment.java
View File

@@ -392,13 +392,13 @@ public class SearchFragment extends InstrumentedFragment implements SearchView.O
taggedData.addAll(Arrays.asList(logTaggedData)); taggedData.addAll(Arrays.asList(logTaggedData));
} }
taggedData.add(Pair.create( taggedData.add(Pair.create(
MetricsEvent.FIELD_SETTINGS_SERACH_RESULT_COUNT, MetricsEvent.FIELD_SETTINGS_SEARCH_RESULT_COUNT,
mSearchAdapter.getItemCount())); mSearchAdapter.getItemCount()));
taggedData.add(Pair.create( taggedData.add(Pair.create(
MetricsEvent.FIELD_SETTINGS_SERACH_RESULT_RANK, MetricsEvent.FIELD_SETTINGS_SEARCH_RESULT_RANK,
resultViewHolder.getAdapterPosition())); resultViewHolder.getAdapterPosition()));
taggedData.add(Pair.create( taggedData.add(Pair.create(
MetricsEvent.FIELD_SETTINGS_SERACH_QUERY_LENGTH, MetricsEvent.FIELD_SETTINGS_SEARCH_QUERY_LENGTH,
TextUtils.isEmpty(mQuery) ? 0 : mQuery.length())); TextUtils.isEmpty(mQuery) ? 0 : mQuery.length()));
mMetricsFeatureProvider.action(getContext(), mMetricsFeatureProvider.action(getContext(),

6
tests/robotests/src/com/android/settings/search/SearchFragmentTest.java
View File

@@ -435,9 +435,9 @@ public class SearchFragmentTest {
nullable(Context.class), nullable(Context.class),
eq(MetricsProto.MetricsEvent.ACTION_CLICK_SETTINGS_SEARCH_RESULT), eq(MetricsProto.MetricsEvent.ACTION_CLICK_SETTINGS_SEARCH_RESULT),
eq("test_setting"), eq("test_setting"),
argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SERACH_RESULT_COUNT)), argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SEARCH_RESULT_COUNT)),
argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SERACH_RESULT_RANK)), argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SEARCH_RESULT_RANK)),
argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SERACH_QUERY_LENGTH))); argThat(pairMatches(MetricsProto.MetricsEvent.FIELD_SETTINGS_SEARCH_QUERY_LENGTH)));
verify(mFeatureFactory.searchFeatureProvider).searchResultClicked(nullable(Context.class), verify(mFeatureFactory.searchFeatureProvider).searchResultClicked(nullable(Context.class),
nullable(String.class), eq(searchResult)); nullable(String.class), eq(searchResult));