diff --git a/res/values/strings.xml b/res/values/strings.xml index c32d557e374..b06d5609f1b 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4830,7 +4830,7 @@ Tap a button to zoom - Quickly zoom in on the screen to see content more clearly.\n\nTo zoom in:\n\t1. Use shortcut to start magnification\n\t2. Tap the screen\n\t3. Drag 2 fingers to move around screen\n\t4. Pinch with 2 fingers to adjust zoom\n\t5. Use shortcut to stop magnification +
To zoom in:
\t1. Use shortcut to start magnification
\t2. Tap the screen
\t3. Drag 2 fingers to move around screen
\t4. Pinch with 2 fingers to adjust zoom
\t5. Use shortcut to stop magnification

To zoom in temporarily:
\t1. Use shortcut to start magnification
\t2. Touch & hold anywhere on the screen
\t3. Drag finger to move around screen
\t4. Lift finger to stop magnification]]>
When magnification is turned on, you can zoom in on your screen.\n\nTo zoom, start magnification, then tap anywhere on the screen.\n\n\nTo zoom temporarily, start magnification, then touch & hold anywhere on the screen.\n\n\nYou can’t zoom in on the keyboard or navigation bar. @@ -4940,7 +4940,7 @@ Use color inversion - Color inversion turns light screens dark. This helps people who are sensitive to bright light see the screen more easily.\n\nNote: Dark colors will turn light. Colors will change in media and images. You can also use Dark theme (Settings > Display). +
Note: Dark colors will turn light. Colors will change in media and images. You can also use Dark theme (Settings > Display).]]>
Auto click (dwell timing) diff --git a/res/xml/accessibility_color_inversion_settings.xml b/res/xml/accessibility_color_inversion_settings.xml index 9681001053c..ba0d6fdb286 100644 --- a/res/xml/accessibility_color_inversion_settings.xml +++ b/res/xml/accessibility_color_inversion_settings.xml @@ -31,17 +31,4 @@ settings:allowDividerBelow="true" settings:searchable="false" /> - - - - - - diff --git a/res/xml/accessibility_daltonizer_settings.xml b/res/xml/accessibility_daltonizer_settings.xml index b2ab5efb59c..c98736b231f 100644 --- a/res/xml/accessibility_daltonizer_settings.xml +++ b/res/xml/accessibility_daltonizer_settings.xml @@ -52,16 +52,4 @@ - - - - - diff --git a/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java b/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java index 31a8c199b24..f73ca01fe83 100644 --- a/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java +++ b/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java @@ -92,8 +92,8 @@ public class MagnificationGesturesPreferenceController extends TogglePreferenceC Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED); extras.putInt(AccessibilitySettings.EXTRA_TITLE_RES, R.string.accessibility_screen_magnification_gestures_title); - extras.putInt(AccessibilitySettings.EXTRA_SUMMARY_RES, - R.string.accessibility_screen_magnification_summary); + extras.putCharSequence(AccessibilitySettings.EXTRA_HTML_DESCRIPTION, + context.getText(R.string.accessibility_screen_magnification_summary)); extras.putInt(AccessibilitySettings.EXTRA_VIDEO_RAW_RESOURCE_ID, R.raw.accessibility_screen_magnification); } diff --git a/src/com/android/settings/accessibility/MagnificationNavbarPreferenceController.java b/src/com/android/settings/accessibility/MagnificationNavbarPreferenceController.java index 1b8d854d095..952f820d7a2 100644 --- a/src/com/android/settings/accessibility/MagnificationNavbarPreferenceController.java +++ b/src/com/android/settings/accessibility/MagnificationNavbarPreferenceController.java @@ -55,8 +55,8 @@ public class MagnificationNavbarPreferenceController extends TogglePreferenceCon Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_NAVBAR_ENABLED); extras.putInt(AccessibilitySettings.EXTRA_TITLE_RES, R.string.accessibility_screen_magnification_navbar_title); - extras.putInt(AccessibilitySettings.EXTRA_SUMMARY_RES, - R.string.accessibility_screen_magnification_navbar_summary); + extras.putCharSequence(AccessibilitySettings.EXTRA_HTML_DESCRIPTION, + mContext.getText(R.string.accessibility_screen_magnification_navbar_summary)); extras.putBoolean(AccessibilitySettings.EXTRA_CHECKED, isChecked()); extras.putBoolean(AccessibilitySettings.EXTRA_LAUNCHED_FROM_SUW, mIsFromSUW); } diff --git a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java index a75c536d7de..17ca93915ee 100644 --- a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java @@ -330,9 +330,6 @@ public class ToggleAccessibilityServicePreferenceFragment extends .appendPath(String.valueOf(animatedImageRes)) .build(); - // Settings html description. - mHtmlDescription = arguments.getCharSequence(AccessibilitySettings.EXTRA_HTML_DESCRIPTION); - // Get Accessibility service name. mPackageName = getAccessibilityServiceInfo().getResolveInfo().loadLabel( getPackageManager()); diff --git a/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java index ffde1e3df04..ec5784ebf78 100644 --- a/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java @@ -29,8 +29,6 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -import androidx.preference.PreferenceCategory; -import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; import com.android.settings.R; @@ -45,7 +43,6 @@ import java.util.List; public class ToggleColorInversionPreferenceFragment extends ToggleFeaturePreferenceFragment { private static final String ENABLED = Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED; - private static final String CATEGORY_FOOTER_KEY = "color_inversion_footer_category"; private static final int DIALOG_ID_EDIT_SHORTCUT = 1; private final Handler mHandler = new Handler(); private SettingsContentObserver mSettingsContentObserver; @@ -91,7 +88,8 @@ public class ToggleColorInversionPreferenceFragment extends ToggleFeaturePrefere public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { mComponentName = COLOR_INVERSION_COMPONENT_NAME; - mPackageName = getString(R.string.accessibility_display_inversion_preference_title); + mPackageName = getText(R.string.accessibility_display_inversion_preference_title); + mHtmlDescription = getText(R.string.accessibility_display_inversion_preference_subtitle); final List enableServiceFeatureKeys = new ArrayList<>(/* initialCapacity= */ 1); enableServiceFeatureKeys.add(ENABLED); mSettingsContentObserver = new SettingsContentObserver(mHandler, enableServiceFeatureKeys) { @@ -103,17 +101,6 @@ public class ToggleColorInversionPreferenceFragment extends ToggleFeaturePrefere return super.onCreateView(inflater, container, savedInstanceState); } - @Override - public void onViewCreated(View view, Bundle savedInstanceState) { - super.onViewCreated(view, savedInstanceState); - - final PreferenceScreen preferenceScreen = getPreferenceScreen(); - preferenceScreen.setOrderingAsAdded(false); - final PreferenceCategory footerCategory = preferenceScreen.findPreference( - CATEGORY_FOOTER_KEY); - footerCategory.setOrder(Integer.MAX_VALUE); - } - @Override public void onResume() { super.onResume(); diff --git a/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java index f2b84e52a24..9b8b1176513 100644 --- a/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java @@ -32,7 +32,6 @@ import android.view.View; import android.view.ViewGroup; import androidx.preference.Preference; -import androidx.preference.PreferenceCategory; import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; @@ -50,8 +49,8 @@ public final class ToggleDaltonizerPreferenceFragment extends ToggleFeaturePrefe implements DaltonizerRadioButtonPreferenceController.OnChangeListener { private static final String ENABLED = Settings.Secure.ACCESSIBILITY_DISPLAY_DALTONIZER_ENABLED; - private static final String CATEGORY_FOOTER_KEY = "daltonizer_footer_category"; - private static final String CATEGORY_MODE_KEY = "daltonizer_mode_category"; + private static final String KEY_PREVIEW = "daltonizer_preview"; + private static final String KEY_CATEGORY_MODE = "daltonizer_mode_category"; private static final List sControllers = new ArrayList<>(); private final Handler mHandler = new Handler(); private SettingsContentObserver mSettingsContentObserver; @@ -82,7 +81,8 @@ public final class ToggleDaltonizerPreferenceFragment extends ToggleFeaturePrefe public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { mComponentName = DALTONIZER_COMPONENT_NAME; - mPackageName = getString(R.string.accessibility_display_daltonizer_preference_title); + mPackageName = getText(R.string.accessibility_display_daltonizer_preference_title); + mHtmlDescription = getText(R.string.accessibility_display_daltonizer_preference_subtitle); final List enableServiceFeatureKeys = new ArrayList<>(/* initialCapacity= */ 1); enableServiceFeatureKeys.add(ENABLED); mSettingsContentObserver = new SettingsContentObserver(mHandler, enableServiceFeatureKeys) { @@ -97,16 +97,32 @@ public final class ToggleDaltonizerPreferenceFragment extends ToggleFeaturePrefe @Override public void onViewCreated(View view, Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); + updatePreferenceOrder(); + } + + /** Customizes the order by preference key. */ + private List getPreferenceOrderList() { + List lists = new ArrayList<>(); + lists.add(KEY_PREVIEW); + lists.add(KEY_USE_SERVICE_PREFERENCE); + lists.add(KEY_CATEGORY_MODE); + lists.add(KEY_GENERAL_CATEGORY); + lists.add(KEY_INTRODUCTION_CATEGORY); + return lists; + } + + private void updatePreferenceOrder() { + List lists = getPreferenceOrderList(); final PreferenceScreen preferenceScreen = getPreferenceScreen(); preferenceScreen.setOrderingAsAdded(false); - final PreferenceCategory modeCategory = preferenceScreen.findPreference( - CATEGORY_MODE_KEY); - modeCategory.setOrder(Integer.MAX_VALUE - 1); - - final PreferenceCategory footerCategory = preferenceScreen.findPreference( - CATEGORY_FOOTER_KEY); - footerCategory.setOrder(Integer.MAX_VALUE); + final int size = lists.size(); + for (int i = 0; i < size; i++) { + final Preference preference = preferenceScreen.findPreference(lists.get(i)); + if (preference != null) { + preference.setOrder(i); + } + } } @Override diff --git a/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java b/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java index 5571591e41a..70f6dcd8ea1 100644 --- a/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java @@ -79,7 +79,9 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference protected CharSequence mHtmlDescription; private static final String ANCHOR_TAG = "a"; private static final String DRAWABLE_FOLDER = "drawable"; - protected static final String KEY_GENERAL_CATEGORY = "categories"; + protected static final String KEY_USE_SERVICE_PREFERENCE = "use_service"; + protected static final String KEY_GENERAL_CATEGORY = "general_categories"; + protected static final String KEY_INTRODUCTION_CATEGORY = "introduction_categories"; private static final String KEY_SHORTCUT_PREFERENCE = "shortcut_preference"; private static final String EXTRA_SHORTCUT_TYPE = "shortcut_type"; private TouchExplorationStateChangeListener mTouchExplorationStateChangeListener; @@ -146,6 +148,7 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference } mToggleServiceDividerSwitchPreference = new DividerSwitchPreference(getPrefContext()); + mToggleServiceDividerSwitchPreference.setKey(KEY_USE_SERVICE_PREFERENCE); preferenceScreen.addPreference(mToggleServiceDividerSwitchPreference); onProcessArguments(getArguments()); @@ -177,6 +180,7 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference getPrefContext()); final CharSequence title = getString(R.string.accessibility_introduction_title, mPackageName); + introductionCategory.setKey(KEY_INTRODUCTION_CATEGORY); introductionCategory.setTitle(title); preferenceScreen.addPreference(introductionCategory); @@ -358,6 +362,12 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference AccessibilitySettings.EXTRA_SUMMARY); createFooterPreference(summary); } + + // Settings html description. + if (arguments.containsKey(AccessibilitySettings.EXTRA_HTML_DESCRIPTION)) { + mHtmlDescription = arguments.getCharSequence( + AccessibilitySettings.EXTRA_HTML_DESCRIPTION); + } } private Drawable getDrawableFromUri(Uri imageUri) { diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java index 7ca2abfc7d1..e31feaa66ac 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java @@ -83,8 +83,6 @@ public class ToggleScreenMagnificationPreferenceFragment extends private static final char COMPONENT_NAME_SEPARATOR = ':'; private static final TextUtils.SimpleStringSplitter sStringColonSplitter = new TextUtils.SimpleStringSplitter(COMPONENT_NAME_SEPARATOR); - - protected Preference mConfigWarningPreference; protected VideoPreference mVideoPreference; protected class VideoPreference extends Preference { @@ -192,12 +190,6 @@ public class ToggleScreenMagnificationPreferenceFragment extends initShortcutPreference(); super.onViewCreated(view, savedInstanceState); - - mConfigWarningPreference = new Preference(getPrefContext()); - mConfigWarningPreference.setSelectable(false); - mConfigWarningPreference.setPersistent(false); - mConfigWarningPreference.setVisible(false); - preferenceScreen.addPreference(mConfigWarningPreference); } @Override @@ -219,7 +211,6 @@ public class ToggleScreenMagnificationPreferenceFragment extends videoView.start(); } - updateConfigurationWarningIfNeeded(); updateShortcutPreferenceData(); updateShortcutPreference(); } @@ -428,7 +419,6 @@ public class ToggleScreenMagnificationPreferenceFragment extends : DialogEnums.ACCESSIBILITY_BUTTON_TUTORIAL); } MagnificationPreferenceFragment.setChecked(getContentResolver(), preferenceKey, enabled); - updateConfigurationWarningIfNeeded(); } @Override @@ -496,16 +486,6 @@ public class ToggleScreenMagnificationPreferenceFragment extends mShortcutPreference.setSummary(getShortcutTypeSummary(getPrefContext())); } - private void updateConfigurationWarningIfNeeded() { - final CharSequence warningMessage = - MagnificationPreferenceFragment.getConfigurationWarningStringForSecureSettingsKey( - mPreferenceKey, getPrefContext()); - if (warningMessage != null) { - mConfigWarningPreference.setSummary(warningMessage); - } - mConfigWarningPreference.setVisible(warningMessage != null); - } - @VisibleForTesting static void optInAllMagnificationValuesToSettings(Context context, int shortcutTypes) { if ((shortcutTypes & UserShortcutType.SOFTWARE) == UserShortcutType.SOFTWARE) {