From c1ca4b81c17ebfbca7627db07bed088c5cb0ae7c Mon Sep 17 00:00:00 2001
From: Julia Reynolds <juliacr@google.com>
Date: Thu, 21 Jan 2021 11:13:57 -0500
Subject: [PATCH] Fix some issues with notif blocking in settings

- Fix cast cast exception
- Make sure unblocking a notification channel also actually
unblocks it

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.notification"
Fixes: 177968301
Fixes: 177907827
Change-Id: Ibad56e102e167bcf004fbd0f9873cc29834a30c1
---
 res/xml/channel_notification_settings.xml                    | 5 ++---
 .../settings/notification/app/BlockPreferenceController.java | 3 ++-
 .../notification/app/ChannelListPreferenceController.java    | 4 +++-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/res/xml/channel_notification_settings.xml b/res/xml/channel_notification_settings.xml
index ff1427b7d7b..44a21acbe4c 100644
--- a/res/xml/channel_notification_settings.xml
+++ b/res/xml/channel_notification_settings.xml
@@ -25,10 +25,9 @@
         android:order="1"
         android:layout="@layout/settings_entity_header" />
 
-    <com.android.settingslib.widget.LayoutPreference
+    <com.android.settings.widget.SettingsMainSwitchPreference
         android:key="block"
-        android:order="2"
-        android:layout="@layout/styled_switch_bar" />
+        android:order="2" />
 
     <!-- Importance toggle -->
     <com.android.settingslib.RestrictedSwitchPreference
diff --git a/src/com/android/settings/notification/app/BlockPreferenceController.java b/src/com/android/settings/notification/app/BlockPreferenceController.java
index 589a03db614..e5a7e980c5f 100644
--- a/src/com/android/settings/notification/app/BlockPreferenceController.java
+++ b/src/com/android/settings/notification/app/BlockPreferenceController.java
@@ -16,6 +16,7 @@
 
 package com.android.settings.notification.app;
 
+import static android.app.NotificationManager.IMPORTANCE_LOW;
 import static android.app.NotificationManager.IMPORTANCE_NONE;
 import static android.app.NotificationManager.IMPORTANCE_UNSPECIFIED;
 
@@ -107,7 +108,7 @@ public class BlockPreferenceController extends NotificationPreferenceController
                         ? IMPORTANCE_NONE
                         : isDefaultChannel()
                                 ? IMPORTANCE_UNSPECIFIED
-                                : mChannel.getOriginalImportance();
+                                : Math.max(mChannel.getOriginalImportance(), IMPORTANCE_LOW);
                 mChannel.setImportance(importance);
                 saveChannel();
             }
diff --git a/src/com/android/settings/notification/app/ChannelListPreferenceController.java b/src/com/android/settings/notification/app/ChannelListPreferenceController.java
index 8410ce13a4c..5fd607f0adf 100644
--- a/src/com/android/settings/notification/app/ChannelListPreferenceController.java
+++ b/src/com/android/settings/notification/app/ChannelListPreferenceController.java
@@ -339,7 +339,9 @@ public class ChannelListPreferenceController extends NotificationPreferenceContr
         channelPref.setOnPreferenceChangeListener(
                 (preference, o) -> {
                     boolean value = (Boolean) o;
-                    int importance = value ? channel.getOriginalImportance() : IMPORTANCE_NONE;
+                    int importance = value
+                            ? Math.max(channel.getOriginalImportance(), IMPORTANCE_LOW)
+                            : IMPORTANCE_NONE;
                     channel.setImportance(importance);
                     channel.lockFields(NotificationChannel.USER_LOCKED_IMPORTANCE);
                     PrimarySwitchPreference channelPref1 = (PrimarySwitchPreference) preference;