PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean WriteSettingsDetails a little

Browse Source 
Bug: 236346018
Test: Make Settings App
Change-Id: Id33b0860e835919dd275ed4cc2ec916d9a076175
This commit is contained in:
Chaohui Wang
2022-09-06 18:15:16 +08:00
parent 7929ab9e8b
commit c17f017b1b
1 changed files with 1 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/com/android/settings/applications/appinfo/WriteSettingsDetails.java
View File

@@ -18,11 +18,7 @@ package com.android.settings.applications.appinfo;
import android.app.AppOpsManager; import android.app.AppOpsManager;
import android.app.settings.SettingsEnums; import android.app.settings.SettingsEnums;
import android.content.Context; import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.content.pm.ResolveInfo;
import android.os.Bundle; import android.os.Bundle;
import android.provider.Settings;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -41,20 +37,13 @@ import com.android.settingslib.applications.ApplicationsState.AppEntry;
public class WriteSettingsDetails extends AppInfoWithHeader implements OnPreferenceChangeListener, public class WriteSettingsDetails extends AppInfoWithHeader implements OnPreferenceChangeListener,
OnPreferenceClickListener { OnPreferenceClickListener {
private static final String KEY_APP_OPS_PREFERENCE_SCREEN = "app_ops_preference_screen";
private static final String KEY_APP_OPS_SETTINGS_SWITCH = "app_ops_settings_switch"; private static final String KEY_APP_OPS_SETTINGS_SWITCH = "app_ops_settings_switch";
private static final String LOG_TAG = "WriteSettingsDetails";
private static final int [] APP_OPS_OP_CODE = {
AppOpsManager.OP_WRITE_SETTINGS
};
// Use a bridge to get the overlay details but don't initialize it to connect with all state. // Use a bridge to get the overlay details but don't initialize it to connect with all state.
// TODO: Break out this functionality into its own class. // TODO: Break out this functionality into its own class.
private AppStateWriteSettingsBridge mAppBridge; private AppStateWriteSettingsBridge mAppBridge;
private AppOpsManager mAppOpsManager; private AppOpsManager mAppOpsManager;
private SwitchPreference mSwitchPref; private SwitchPreference mSwitchPref;
private Intent mSettingsIntent;
private WriteSettingsState mWriteSettingsState; private WriteSettingsState mWriteSettingsState;
@Override @Override
@@ -66,13 +55,10 @@ public class WriteSettingsDetails extends AppInfoWithHeader implements OnPrefere
mAppOpsManager = (AppOpsManager) context.getSystemService(Context.APP_OPS_SERVICE); mAppOpsManager = (AppOpsManager) context.getSystemService(Context.APP_OPS_SERVICE);
addPreferencesFromResource(R.xml.write_system_settings_permissions_details); addPreferencesFromResource(R.xml.write_system_settings_permissions_details);
mSwitchPref = (SwitchPreference) findPreference(KEY_APP_OPS_SETTINGS_SWITCH); mSwitchPref = findPreference(KEY_APP_OPS_SETTINGS_SWITCH);
mSwitchPref.setOnPreferenceChangeListener(this); mSwitchPref.setOnPreferenceChangeListener(this);
mSettingsIntent = new Intent(Intent.ACTION_MAIN)
.addCategory(Settings.INTENT_CATEGORY_USAGE_ACCESS_CONFIG)
.setPackage(mPackageName);
} }
@Override @Override
@@ -107,16 +93,6 @@ public class WriteSettingsDetails extends AppInfoWithHeader implements OnPrefere
logCategory, packageName); logCategory, packageName);
} }
private boolean canWriteSettings(String pkgName) {
int result = mAppOpsManager.checkOpNoThrow(AppOpsManager.OP_WRITE_SETTINGS,
mPackageInfo.applicationInfo.uid, pkgName);
if (result == AppOpsManager.MODE_ALLOWED) {
return true;
}
return false;
}
@Override @Override
protected boolean refreshUi() { protected boolean refreshUi() {
mWriteSettingsState = mAppBridge.getWriteSettingsInfo(mPackageName, mWriteSettingsState = mAppBridge.getWriteSettingsInfo(mPackageName,
@@ -127,8 +103,6 @@ public class WriteSettingsDetails extends AppInfoWithHeader implements OnPrefere
// you can't ask a user for a permission you didn't even declare! // you can't ask a user for a permission you didn't even declare!
mSwitchPref.setEnabled(mWriteSettingsState.permissionDeclared); mSwitchPref.setEnabled(mWriteSettingsState.permissionDeclared);
ResolveInfo resolveInfo = mPm.resolveActivityAsUser(mSettingsIntent,
PackageManager.GET_META_DATA, mUserId);
return true; return true;
} }