From c12b1b40ee20b74b146efebdd564527475ecb40b Mon Sep 17 00:00:00 2001 From: Lee Chou Date: Thu, 27 Feb 2020 11:50:03 +0800 Subject: [PATCH] Fixes ApnEditor not restoring previous UI ApnEditor tries read and set the UI in onCreate, before the previous bundle is restored. This caused problems when the configuration has changed (such as switching to Dark Theme). This moves the UI changes to onViewRestored Fixes: 146399432 Test: make SettingsGoogle and manual test UI Change-Id: I8147ec96569fa28867c088d6c36584aa344f40ed --- src/com/android/settings/network/ApnEditor.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/network/ApnEditor.java b/src/com/android/settings/network/ApnEditor.java index 091e7f5f3dd..6de2550c385 100644 --- a/src/com/android/settings/network/ApnEditor.java +++ b/src/com/android/settings/network/ApnEditor.java @@ -39,6 +39,7 @@ import android.view.MenuItem; import android.view.View; import android.view.View.OnKeyListener; +import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; import androidx.appcompat.app.AlertDialog; import androidx.preference.EditTextPreference; @@ -388,8 +389,12 @@ public class ApnEditor extends SettingsPreferenceFragment for (int i = 0; i < getPreferenceScreen().getPreferenceCount(); i++) { getPreferenceScreen().getPreference(i).setOnPreferenceChangeListener(this); } + } - fillUI(icicle == null); + @Override + public void onViewStateRestored(@Nullable Bundle savedInstanceState) { + super.onViewStateRestored(savedInstanceState); + fillUI(savedInstanceState == null); } @VisibleForTesting