PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Settings] Add test case for new LocalePicker page - suggested language

Browse Source 
Bug: 396285228
Test: atest
Test: atest SettingsRoboTests:com.android.settings.localepicker.SystemLocaleSuggestedListPreferenceControllerTest
Test: atest SettingsUnitTests:com.android.settings.localepicker.SystemLocaleSuggestedListPreferenceControllerTest
Flag: EXEMPT refactor
Change-Id: I70d731b50775bf45ae0d73e4da9ea78dfcd3826c
This commit is contained in:
Zoey Chen
2025-02-14 11:28:13 +00:00
parent 5e79d18636
commit c0a09796b8
3 changed files with 299 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/com/android/settings/localepicker/LocalePickerBaseListPreferenceController.java
View File

@@ -28,6 +28,7 @@ import android.util.Log;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;
import androidx.fragment.app.FragmentManager;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
@@ -164,7 +165,8 @@ public abstract class LocalePickerBaseListPreferenceController extends
return getSortedLocaleList(searchItem);
}
private void setupPreference(List<LocaleStore.LocaleInfo> localeInfoList,
@VisibleForTesting
void setupPreference(List<LocaleStore.LocaleInfo> localeInfoList,
Map<String, Preference> existingPreferences) {
Log.d(TAG, "setupPreference: isNumberingMode = " + isNumberingMode());
if (isNumberingMode() && getPreferenceCategoryKey().contains(KEY_SUPPORTED)) {
@@ -255,7 +257,8 @@ public abstract class LocalePickerBaseListPreferenceController extends
return localeInfos;
}
private void switchFragment(LocaleStore.LocaleInfo localeInfo) {
@VisibleForTesting
void switchFragment(LocaleStore.LocaleInfo localeInfo) {
boolean shouldShowLocaleEditor = shouldShowLocaleEditor(localeInfo);
if (shouldShowLocaleEditor) {
List<LocaleStore.LocaleInfo> feedItemList = getUserLocaleList();
@@ -281,7 +284,6 @@ public abstract class LocalePickerBaseListPreferenceController extends
.setArguments(extra)
.launch();
}
((Activity) mContext).finish();
}
public void setFragmentManager(@NonNull FragmentManager fragmentManager) {
@@ -295,7 +297,8 @@ public abstract class LocalePickerBaseListPreferenceController extends
}
}
private boolean shouldShowLocaleEditor(LocaleStore.LocaleInfo localeInfo) {
@VisibleForTesting
boolean shouldShowLocaleEditor(LocaleStore.LocaleInfo localeInfo) {
boolean isSystemLocale = localeInfo.isSystemLocale();
boolean isRegionLocale = localeInfo.getParent() != null;
boolean mayHaveDifferentNumberingSystem = localeInfo.hasNumberingSystems();

181
tests/robotests/src/com/android/settings/localepicker/SystemLocaleSuggestedListPreferenceControllerTest.java Normal file
View File

@@ -0,0 +1,181 @@
/**
* Copyright (C) 2025 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.app.IActivityManager;
import android.content.Context;
import android.content.res.Configuration;
import android.os.LocaleList;
import android.os.Looper;
import android.telephony.TelephonyManager;
import android.util.ArrayMap;
import com.android.internal.app.LocaleStore;
import com.android.settings.testutils.shadow.ShadowActivityManager;
import com.android.settings.testutils.shadow.ShadowFragment;
import androidx.fragment.app.FragmentActivity;
import androidx.fragment.app.FragmentManager;
import androidx.fragment.app.FragmentTransaction;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceFragmentCompat;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.Shadows;
import org.robolectric.shadows.ShadowTelephonyManager;
import org.robolectric.annotation.Config;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@RunWith(RobolectricTestRunner.class)
@Config(shadows = {
ShadowFragment.class,
ShadowActivityManager.class,
})
public class SystemLocaleSuggestedListPreferenceControllerTest {
private static final String KEY_CATEGORY_SYSTEM_SUGGESTED_LIST =
"system_language_suggested_category";
private static final String KEY_SUGGESTED = "system_locale_suggested_list";
private Context mContext;
private PreferenceCategory mPreferenceCategory;
private PreferenceScreen mPreferenceScreen;
private SystemLocaleSuggestedListPreferenceController mController;
private List<LocaleStore.LocaleInfo> mLocaleList;
private Map<String, Preference> mPreferences = new ArrayMap<>();
@Mock
private PreferenceManager mPreferenceManager;
@Mock
private IActivityManager mActivityService;
@Mock
private LocaleStore.LocaleInfo mSuggestedLocaleInfo_1;
@Mock
private LocaleStore.LocaleInfo mSuggestedLocaleInfo_2;
@Mock
private FragmentManager mFragmentManager;
@Mock
private FragmentTransaction mFragmentTransaction;
@Before
public void setUp() throws Exception {
MockitoAnnotations.initMocks(this);
mContext = spy(ApplicationProvider.getApplicationContext());
if (Looper.myLooper() == null) {
Looper.prepare();
}
ShadowActivityManager.setService(mActivityService);
final Configuration config = new Configuration();
setUpLocaleConditions();
config.setLocales(new LocaleList(mSuggestedLocaleInfo_1.getLocale(),
mSuggestedLocaleInfo_2.getLocale()));
when(mActivityService.getConfiguration()).thenReturn(config);
ShadowTelephonyManager shadowTelephonyManager =
Shadows.shadowOf(mContext.getSystemService(TelephonyManager.class));
shadowTelephonyManager.setSimCountryIso("us");
shadowTelephonyManager.setNetworkCountryIso("us");
when(mFragmentManager.beginTransaction()).thenReturn(mFragmentTransaction);
mPreferenceScreen = spy(new PreferenceScreen(mContext, null));
mPreferenceCategory = spy(new PreferenceCategory(mContext, null));
when(mPreferenceScreen.getPreferenceManager()).thenReturn(mPreferenceManager);
when(mPreferenceCategory.getPreferenceManager()).thenReturn(mPreferenceManager);
mPreferenceManager = new PreferenceManager(mContext);
mPreferenceScreen = mPreferenceManager.createPreferenceScreen(mContext);
mPreferenceCategory.setKey(KEY_CATEGORY_SYSTEM_SUGGESTED_LIST);
mPreferenceScreen.addPreference(mPreferenceCategory);
mController = new SystemLocaleSuggestedListPreferenceController(mContext, KEY_SUGGESTED);
}
private void setUpLocaleConditions() {
mLocaleList = new ArrayList<>();
when(mSuggestedLocaleInfo_1.getFullNameNative()).thenReturn("English");
when(mSuggestedLocaleInfo_1.getLocale()).thenReturn(
LocaleList.forLanguageTags("en-US").get(0));
mLocaleList.add(mSuggestedLocaleInfo_1);
when(mSuggestedLocaleInfo_2.getFullNameNative()).thenReturn("Español (Estados Unidos)");
when(mSuggestedLocaleInfo_2.getLocale()).thenReturn(
LocaleList.forLanguageTags("es-US").get(0));
mLocaleList.add(mSuggestedLocaleInfo_2);
}
@Test
public void displayPreference_hasSuggestedPreference_categoryIsVisible() {
mController.displayPreference(mPreferenceScreen);
mController.setupPreference(mLocaleList, mPreferences);
assertTrue(mPreferenceCategory.isVisible());
assertThat(mPreferenceCategory.getPreferenceCount()).isEqualTo(2);
}
@Test
public void displayPreference_noSuggestedPreference_categoryIsGone() {
mLocaleList.clear();
mController.displayPreference(mPreferenceScreen);
mController.setupPreference(mLocaleList, mPreferences);
assertFalse(mPreferenceCategory.isVisible());
assertThat(mPreferenceCategory.getPreferenceCount()).isEqualTo(0);
}
@Test
public void switchFragment_shouldShowLocaleEditor() {
when(mSuggestedLocaleInfo_1.isSuggested()).thenReturn(true);
mController.shouldShowLocaleEditor(mSuggestedLocaleInfo_1);
mController.switchFragment(mSuggestedLocaleInfo_1);
verify(mFragmentTransaction, never()).add(any(LocaleListEditor.class),
anyString());
}
@Test
public void switchFragment_shouldShowRegionNumberingPicker() {
Context activityContext = mock(Context.class);
mController = new SystemLocaleSuggestedListPreferenceController(activityContext,
KEY_SUGGESTED);
when(mSuggestedLocaleInfo_1.isSuggested()).thenReturn(false);
when(mSuggestedLocaleInfo_1.isSystemLocale()).thenReturn(false);
when(mSuggestedLocaleInfo_1.getParent()).thenReturn(null);
mController.shouldShowLocaleEditor(mSuggestedLocaleInfo_1);
mController.switchFragment(mSuggestedLocaleInfo_1);
verify(mFragmentTransaction, never()).add(any(RegionAndNumberingSystemPickerFragment.class),
anyString());
}
}

111
tests/unit/src/com/android/settings/localepicker/SystemLocaleSuggestedListPreferenceControllerTest.java Normal file
View File

@@ -0,0 +1,111 @@
/**
* Copyright (C) 2025 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.app.Activity;
import android.content.Context;
import android.os.Looper;
import com.android.internal.app.LocaleStore;
import com.android.internal.app.SystemLocaleCollector;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.MockitoAnnotations;
import java.util.Locale;
import java.util.Set;
@RunWith(AndroidJUnit4.class)
public class SystemLocaleSuggestedListPreferenceControllerTest {
private static final String KEY_CATEGORY_SYSTEM_SUGGESTED_LIST =
"system_language_suggested_category";
private static final String KEY_SUGGESTED = "system_locale_suggested_list";
private Context mContext;
private PreferenceManager mPreferenceManager;
private PreferenceCategory mPreferenceCategory;
private PreferenceScreen mPreferenceScreen;
private Preference mSuggestedPreference;
private SystemLocaleSuggestedListPreferenceController mController;
private Set<LocaleStore.LocaleInfo> mLocaleList;
@Before
public void setUp() throws Exception {
MockitoAnnotations.initMocks(this);
mContext = spy(ApplicationProvider.getApplicationContext());
if (Looper.myLooper() == null) {
Looper.prepare();
}
SystemLocaleCollector systemLocaleCollector = new SystemLocaleCollector(mContext, null);
mLocaleList = systemLocaleCollector.getSupportedLocaleList(null, false, false);
mPreferenceManager = new PreferenceManager(mContext);
mPreferenceScreen = mPreferenceManager.createPreferenceScreen(mContext);
mPreferenceCategory = new PreferenceCategory(mContext);
mPreferenceCategory.setKey(KEY_CATEGORY_SYSTEM_SUGGESTED_LIST);
mPreferenceScreen.addPreference(mPreferenceCategory);
mController = new SystemLocaleSuggestedListPreferenceController(mContext, KEY_SUGGESTED);
mController.displayPreference(mPreferenceScreen);
}
@Test
public void displayPreference_suggestedLocaleShouldBeInSuggestedCategory() {
int count = 0;
for (LocaleStore.LocaleInfo localeInfo : mLocaleList) {
if (localeInfo.isSuggested()) {
count++;
}
}
assertThat(mPreferenceCategory.getPreferenceCount()).isEqualTo(count);
}
@Test
public void displayPreference_hasSuggestedPreference_categoryIsVisible() {
int count = 0;
for (LocaleStore.LocaleInfo localeInfo : mLocaleList) {
if (localeInfo.isSuggested()) {
count++;
}
}
if (count > 0) {
assertTrue(mPreferenceCategory.isVisible());
} else {
assertFalse(mPreferenceCategory.isVisible());
}
}
}