Fix Settings crash

Doesn't unregister contentprovider so that when data changed,
the fragment is destroyed.

Fixes: 127726564
Test: Connect to wifi. Go to Settings -> connected devices ->
      connection preference -> printing -> hp print service -> press
      back. Repeat several times.

Change-Id: I79d1522ce9d91a6bf6b1f982b7687eab1f7896bb
This commit is contained in:
Raff Tsai
2019-03-08 07:22:20 +08:00
parent 476b9050e8
commit bf1fa0c2a6

View File

@@ -143,6 +143,8 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment
@Override
public void onStart() {
super.onStart();
initComponents();
updateUiForArguments();
updateEmptyView();
updateUiForServiceState();
}
@@ -158,20 +160,9 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment
@Override
public void onStop() {
super.onStop();
}
@Override
public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
initComponents();
updateUiForArguments();
}
@Override
public void onDestroyView() {
super.onDestroyView();
mSwitchBar.removeOnSwitchChangeListener(this);
mSwitchBar.hide();
mPrintersAdapter.unregisterAdapterDataObserver(mDataObserver);
}
private void onPreferenceToggled(String preferenceKey, boolean enabled) {