Add referrer when launching search intent.
Bug: 123294739 Test: robotests Change-Id: I600abf1d764e828d52f3b8d35ad24cdc94dfba01
This commit is contained in:
@@ -20,10 +20,12 @@ package com.android.settings.search;
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
|
||||
import android.app.Activity;
|
||||
import android.app.settings.SettingsEnums;
|
||||
import android.content.ComponentName;
|
||||
import android.content.Intent;
|
||||
import android.content.pm.ActivityInfo;
|
||||
import android.content.pm.ResolveInfo;
|
||||
import android.net.Uri;
|
||||
import android.provider.Settings;
|
||||
import android.widget.Toolbar;
|
||||
|
||||
@@ -60,19 +62,19 @@ public class SearchFeatureProviderImplTest {
|
||||
@Test
|
||||
@Config(shadows = ShadowUtils.class)
|
||||
public void initSearchToolbar_hasResolvedInfo_shouldStartCorrectIntent() {
|
||||
final Intent searchIntent = new Intent(SearchFeatureProvider.SEARCH_UI_INTENT)
|
||||
final Intent searchIntent = new Intent(Settings.ACTION_APP_SEARCH_SETTINGS)
|
||||
.setPackage(mActivity.getString(R.string.config_settingsintelligence_package_name));
|
||||
final ResolveInfo info = new ResolveInfo();
|
||||
info.activityInfo = new ActivityInfo();
|
||||
mPackageManager.addResolveInfoForIntent(searchIntent, info);
|
||||
|
||||
// Should not crash.
|
||||
mProvider.initSearchToolbar(mActivity, null);
|
||||
mProvider.initSearchToolbar(mActivity, null, SettingsEnums.TESTING);
|
||||
|
||||
final Toolbar toolbar = new Toolbar(mActivity);
|
||||
// This ensures navigationView is created.
|
||||
toolbar.setNavigationContentDescription("test");
|
||||
mProvider.initSearchToolbar(mActivity, toolbar);
|
||||
mProvider.initSearchToolbar(mActivity, toolbar, SettingsEnums.TESTING);
|
||||
|
||||
toolbar.performClick();
|
||||
|
||||
@@ -87,7 +89,7 @@ public class SearchFeatureProviderImplTest {
|
||||
final Toolbar toolbar = new Toolbar(mActivity);
|
||||
// This ensures navigationView is created.
|
||||
toolbar.setNavigationContentDescription("test");
|
||||
mProvider.initSearchToolbar(mActivity, toolbar);
|
||||
mProvider.initSearchToolbar(mActivity, toolbar, SettingsEnums.TESTING);
|
||||
|
||||
toolbar.performClick();
|
||||
|
||||
@@ -108,6 +110,15 @@ public class SearchFeatureProviderImplTest {
|
||||
assertThat(Shadows.shadowOf(mActivity).getNextStartedActivity()).isNull();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void buildSearchIntent_shouldIncludeReferrer() {
|
||||
final Intent searchIntent = mProvider.buildSearchIntent(mActivity, SettingsEnums.TESTING);
|
||||
final Uri referrer = searchIntent.getParcelableExtra(Intent.EXTRA_REFERRER);
|
||||
|
||||
assertThat(referrer.toSafeString()).isEqualTo(
|
||||
"android-app://" + mActivity.getPackageName() + "/" + SettingsEnums.TESTING);
|
||||
}
|
||||
|
||||
@Test(expected = IllegalArgumentException.class)
|
||||
public void verifyLaunchSearchResultPageCaller_nullCaller_shouldCrash() {
|
||||
mProvider.verifyLaunchSearchResultPageCaller(mActivity, null /* caller */);
|
||||
|
@@ -17,11 +17,11 @@
|
||||
package com.android.settings.search.actionbar;
|
||||
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.spy;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.verifyZeroInteractions;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
import android.app.settings.SettingsEnums;
|
||||
import android.content.Context;
|
||||
import android.os.Bundle;
|
||||
import android.provider.Settings.Global;
|
||||
@@ -29,9 +29,9 @@ import android.view.Menu;
|
||||
import android.view.MenuItem;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.core.InstrumentedFragment;
|
||||
import com.android.settings.core.InstrumentedPreferenceFragment;
|
||||
import com.android.settings.testutils.shadow.ShadowUtils;
|
||||
import com.android.settingslib.core.lifecycle.ObservableFragment;
|
||||
import com.android.settingslib.core.lifecycle.ObservablePreferenceFragment;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
@@ -49,15 +49,24 @@ public class SearchMenuControllerTest {
|
||||
@Mock
|
||||
private Menu mMenu;
|
||||
private TestPreferenceFragment mPreferenceHost;
|
||||
private ObservableFragment mHost;
|
||||
private InstrumentedFragment mHost;
|
||||
private Context mContext;
|
||||
|
||||
@Before
|
||||
public void setUp() {
|
||||
MockitoAnnotations.initMocks(this);
|
||||
mContext = RuntimeEnvironment.application;
|
||||
mHost = spy(new ObservableFragment());
|
||||
when(mHost.getContext()).thenReturn(mContext);
|
||||
mHost = new InstrumentedFragment() {
|
||||
@Override
|
||||
public Context getContext() {
|
||||
return mContext;
|
||||
}
|
||||
|
||||
@Override
|
||||
public int getMetricsCategory() {
|
||||
return SettingsEnums.TESTING;
|
||||
}
|
||||
};
|
||||
mPreferenceHost = new TestPreferenceFragment();
|
||||
Global.putInt(mContext.getContentResolver(), Global.DEVICE_PROVISIONED, 1);
|
||||
|
||||
@@ -101,7 +110,7 @@ public class SearchMenuControllerTest {
|
||||
verifyZeroInteractions(mMenu);
|
||||
}
|
||||
|
||||
private static class TestPreferenceFragment extends ObservablePreferenceFragment {
|
||||
private static class TestPreferenceFragment extends InstrumentedPreferenceFragment {
|
||||
@Override
|
||||
public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
|
||||
}
|
||||
@@ -110,5 +119,10 @@ public class SearchMenuControllerTest {
|
||||
public Context getContext() {
|
||||
return RuntimeEnvironment.application;
|
||||
}
|
||||
|
||||
@Override
|
||||
public int getMetricsCategory() {
|
||||
return SettingsEnums.TESTING;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user