From 964b36d415048eb4fb2d03e887a0db813b7b6e1a Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Thu, 18 Jan 2018 11:36:21 -0800 Subject: [PATCH] Update suggestion card layout - set card corner radius - update card margin according to number of card and card position - update text alignment for title and summary Bug: 70573674 Test: visual Change-Id: Icfceed5614ded97ce2a7767667ae97f92b89b2fa --- res/layout/suggestion_container.xml | 2 - res/layout/suggestion_tile_v2.xml | 19 +++-- res/layout/suggestion_tile_with_button_v2.xml | 20 +++-- res/values/dimens.xml | 8 +- res/values/styles.xml | 9 +++ .../dashboard/DashboardAdapterV2.java | 3 +- .../suggestions/SuggestionAdapterV2.java | 78 ++++++++++++++----- 7 files changed, 99 insertions(+), 40 deletions(-) diff --git a/res/layout/suggestion_container.xml b/res/layout/suggestion_container.xml index 2aa104333db..e01a5903c79 100644 --- a/res/layout/suggestion_container.xml +++ b/res/layout/suggestion_container.xml @@ -57,8 +57,6 @@ android:layout_height="wrap_content" android:paddingTop="20dp" android:paddingBottom="16dp" - android:paddingStart="16dp" - android:paddingEnd="16dp" android:scrollbars="none"/> diff --git a/res/layout/suggestion_tile_v2.xml b/res/layout/suggestion_tile_v2.xml index e180897af06..27b3c349e9e 100644 --- a/res/layout/suggestion_tile_v2.xml +++ b/res/layout/suggestion_tile_v2.xml @@ -21,7 +21,8 @@ android:layout_width="328dp" android:layout_height="wrap_content" app:cardUseCompatPadding="true" - app:cardElevation="2dp"> + app:cardElevation="2dp" + app:cardCornerRadius="@dimen/suggestion_card_corner_radius"> @@ -55,21 +56,23 @@ diff --git a/res/layout/suggestion_tile_with_button_v2.xml b/res/layout/suggestion_tile_with_button_v2.xml index 01be23658fc..5f4ed18bab3 100644 --- a/res/layout/suggestion_tile_with_button_v2.xml +++ b/res/layout/suggestion_tile_with_button_v2.xml @@ -21,14 +21,14 @@ android:layout_width="328dp" android:layout_height="wrap_content" app:cardUseCompatPadding="true" - app:cardElevation="2dp"> + app:cardElevation="2dp" + app:cardCornerRadius="@dimen/suggestion_card_corner_radius"> + android:orientation="vertical"> @@ -56,9 +56,11 @@