PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a mutability flag to the PendingIntent

Browse Source 
- Request from Android Platform Security team.
  go/immutable-pendingintents

Bug: 170162129
Test:
1. adb shell am start -a
android.settings.panel.action.INTERNET_CONNECTIVITY
2. make RunSettingsRoboTests ROBOTEST_FILTER=WifiSliceTest
Change-Id: If3032959649206f2fb6736244d7aa8b9a8419378
This commit is contained in:
Weng Su
2020-11-11 07:57:44 +00:00
parent 76eb401911
commit bd482c986c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/wifi/slice/WifiSlice.java
View File

@@ -224,7 +224,7 @@ public class WifiSlice implements CustomSliceable {
private SliceAction getActivityAction(int requestCode, Intent intent, IconCompat icon, private SliceAction getActivityAction(int requestCode, Intent intent, IconCompat icon,
CharSequence title) { CharSequence title) {
final PendingIntent pi = PendingIntent.getActivity(mContext, requestCode, intent, final PendingIntent pi = PendingIntent.getActivity(mContext, requestCode, intent,
0 /* flags */); PendingIntent.FLAG_IMMUTABLE /* flags */);
return SliceAction.createDeeplink(pi, icon, ListBuilder.ICON_IMAGE, title); return SliceAction.createDeeplink(pi, icon, ListBuilder.ICON_IMAGE, title);
} }
@@ -289,7 +289,7 @@ public class WifiSlice implements CustomSliceable {
private PendingIntent getPrimaryAction() { private PendingIntent getPrimaryAction() {
final Intent intent = getIntent(); final Intent intent = getIntent();
return PendingIntent.getActivity(mContext, 0 /* requestCode */, return PendingIntent.getActivity(mContext, 0 /* requestCode */,
intent, 0 /* flags */); intent, PendingIntent.FLAG_IMMUTABLE /* flags */);
} }
private Set<String> getKeywords() { private Set<String> getKeywords() {