From 23c2acfd4c01b270c998a4a497c658cc3d842473 Mon Sep 17 00:00:00 2001 From: Paul Lawrence Date: Thu, 10 Mar 2016 13:54:56 -0800 Subject: [PATCH] Don't show secure startup options and strings when file encrypted File encryption is secure by default, so we don't need to warn. Bug: 27433949 Bug: 27435082 Change-Id: I3e856256188e6a7dcd58cabbde043395c314999e --- src/com/android/settings/ChooseLockGeneric.java | 9 ++++++++- src/com/android/settings/SecuritySettings.java | 3 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/ChooseLockGeneric.java b/src/com/android/settings/ChooseLockGeneric.java index 8847321e93a..ed1d0dd47f7 100644 --- a/src/com/android/settings/ChooseLockGeneric.java +++ b/src/com/android/settings/ChooseLockGeneric.java @@ -34,6 +34,7 @@ import android.os.Bundle; import android.os.Process; import android.os.UserHandle; import android.os.UserManager; +import android.os.storage.StorageManager; import android.security.KeyStore; import android.support.v7.preference.Preference; import android.support.v7.preference.PreferenceScreen; @@ -481,7 +482,13 @@ public class ChooseLockGeneric extends SettingsActivity { } private void updatePreferenceSummaryIfNeeded() { - if (LockPatternUtils.isDeviceEncrypted()) { + // On a default block encrypted device with accessibility, add a warning + // that your data is not credential encrypted + if (!StorageManager.isBlockEncrypted()) { + return; + } + + if (StorageManager.isNonDefaultBlockEncrypted()) { return; } diff --git a/src/com/android/settings/SecuritySettings.java b/src/com/android/settings/SecuritySettings.java index 4f4e543f353..c6ec4a974ff 100644 --- a/src/com/android/settings/SecuritySettings.java +++ b/src/com/android/settings/SecuritySettings.java @@ -36,6 +36,7 @@ import android.os.Bundle; import android.os.PersistableBundle; import android.os.UserHandle; import android.os.UserManager; +import android.os.storage.StorageManager; import android.provider.SearchIndexableResource; import android.provider.Settings; import android.security.KeyStore; @@ -1054,7 +1055,7 @@ public class SecuritySettings extends SettingsPreferenceFragment DevicePolicyManager dpm = context.getSystemService(DevicePolicyManager.class); return UserManager.get(context).isAdminUser() && UserManager.get(context).isPrimaryUser() - && LockPatternUtils.isDeviceEncryptionEnabled() + && StorageManager.isBlockEncrypted() && !dpm.getDoNotAskCredentialsOnBoot(); }