Use different exceptions for different crash reasons
Always throwing RemoteServiceException would make it impossible to tell the cause of a crash without the string message. Let's use a different exception type so developers can cluster crashes without the exception message. Bug: 124137635 Test: Treehugger Change-Id: Ibae57bdb1b8965241c41249a89c728d224e4e995
This commit is contained in:
@@ -21,6 +21,7 @@ import static android.app.admin.DevicePolicyManager.EXTRA_PASSWORD_COMPLEXITY;
|
||||
|
||||
import static com.android.settings.password.ChooseLockSettingsHelper.EXTRA_KEY_REQUESTED_MIN_COMPLEXITY;
|
||||
|
||||
import android.app.RemoteServiceException.MissingRequestPasswordComplexityPermissionException;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
import android.os.Bundle;
|
||||
@@ -79,7 +80,8 @@ public class SetupChooseLockGeneric extends ChooseLockGeneric {
|
||||
if (!hasPermission) {
|
||||
PasswordUtils.crashCallingApplication(activityToken,
|
||||
"Must have permission " + REQUEST_PASSWORD_COMPLEXITY
|
||||
+ " to use extra " + EXTRA_PASSWORD_COMPLEXITY);
|
||||
+ " to use extra " + EXTRA_PASSWORD_COMPLEXITY,
|
||||
MissingRequestPasswordComplexityPermissionException.TYPE_ID);
|
||||
finish();
|
||||
return;
|
||||
}
|
||||
|
Reference in New Issue
Block a user