From 4b964aa5525cffbc229dc7fd101ff6a4cb3fc53d Mon Sep 17 00:00:00 2001 From: Chaohui Wang Date: Tue, 14 Mar 2023 16:46:47 +0800 Subject: [PATCH] Move LogEvent action to Settings Spa cannot refer SettingsEnums, move the action to Settings. Bug: 269821172 Test: Make Settings Change-Id: I033f4d046736b109de679e139caac75b3e4071b1 --- .../settings/spa/core/instrumentation/SpaLogProvider.kt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/spa/core/instrumentation/SpaLogProvider.kt b/src/com/android/settings/spa/core/instrumentation/SpaLogProvider.kt index 9b3e2d68ac2..31d5797bf9a 100644 --- a/src/com/android/settings/spa/core/instrumentation/SpaLogProvider.kt +++ b/src/com/android/settings/spa/core/instrumentation/SpaLogProvider.kt @@ -92,8 +92,11 @@ class SpaLogData(val id: String, val event: LogEvent, return null } - fun getAction(): Int { - return event.action + fun getAction(): Int = when (event) { + LogEvent.PAGE_ENTER -> SettingsEnums.PAGE_VISIBLE + LogEvent.PAGE_LEAVE -> SettingsEnums.PAGE_HIDE + LogEvent.ENTRY_CLICK -> SettingsEnums.ACTION_SETTINGS_TILE_CLICK + LogEvent.ENTRY_SWITCH -> SettingsEnums.ACTION_SETTINGS_PREFERENCE_CHANGE } //TODO(b/253979024): Will be implemented in subsequent CLs.