From 484087c181cedb5a6418c8c10f81a36eaa49420f Mon Sep 17 00:00:00 2001 From: Jin Dong Date: Fri, 22 Dec 2017 17:49:23 +0800 Subject: [PATCH] Fix memory leak of DataSaverPreference When DataSaverPreference is shown repeatedly, memory leak happens since DataSaverBackend.Listener is not removed on onDetached(). TEST: Repeat enter and exit "Data usage" for several times and check if the count of activity is not increasing. Bug: 72581115 Change-Id: Ic4a72de049bb87f1e522fe46dd0fb4bb58ed65a5 --- src/com/android/settings/datausage/DataSaverPreference.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/datausage/DataSaverPreference.java b/src/com/android/settings/datausage/DataSaverPreference.java index 13ef9d7c4f5..f1f648a37a2 100644 --- a/src/com/android/settings/datausage/DataSaverPreference.java +++ b/src/com/android/settings/datausage/DataSaverPreference.java @@ -37,7 +37,7 @@ public class DataSaverPreference extends Preference implements DataSaverBackend. @Override public void onDetached() { super.onDetached(); - mDataSaverBackend.addListener(this); + mDataSaverBackend.remListener(this); } @Override