PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix talkback issue about announcing wrong number of items

Browse Source 
From hierarchical view, one of root cause is PreferenceCategory.
Looks like PreferenceCategory generates an invisible space when
we add a footerPreference as a child.

So, we remove PreferenceCategory directly, and declard "allow divider"
attribute for neccessary preferences.

Test: Visual
Fixes: 130396913
Change-Id: I6d56ac165633aa211e794e07417821066380d041
This commit is contained in:
tmfang
2019-06-27 17:50:20 +08:00
committed by Tsung-Mao Fang
parent eae13f76f7
commit b981068248
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
res/layout/face_enroll_button.xml
View File

@@ -17,7 +17,8 @@
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:layout_height="wrap_content"
android:minHeight="?android:attr/listPreferredItemHeight">
<Button
android:id="@+id/security_settings_face_settings_enroll_button"

3
res/layout/face_remove_button.xml
View File

@@ -17,7 +17,8 @@
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:layout_height="wrap_content"
android:minHeight="?android:attr/listPreferredItemHeight">
<Button
android:id="@+id/security_settings_face_settings_remove_button"

13
res/xml/security_settings_face.xml
View File

@@ -68,17 +68,16 @@
<com.android.settingslib.widget.LayoutPreference
android:key="security_settings_face_delete_faces_container"
android:selectable="false"
android:layout="@layout/face_remove_button" />
android:layout="@layout/face_remove_button"
settings:allowDividerBelow="true"/>
<com.android.settingslib.widget.LayoutPreference
android:key="security_settings_face_enroll_faces_container"
android:selectable="false"
android:layout="@layout/face_enroll_button " />
</PreferenceCategory>
<PreferenceCategory
android:key="security_settings_face_footer_container">
<com.android.settingslib.widget.FooterPreference />
android:layout="@layout/face_enroll_button "
settings:allowDividerBelow="true"/>
</PreferenceCategory>
<com.android.settingslib.widget.FooterPreference
settings:allowDividerAbove="true"/>
</PreferenceScreen>