From b8ed22bb4ea10b8f03df3295d15c1905b431f5ef Mon Sep 17 00:00:00 2001 From: Chris Antol Date: Tue, 11 Apr 2023 21:00:45 +0000 Subject: [PATCH] Make Tips & Support page launchable from Settings Search results Bug: 258315425 Test: Tested on pixel device: in Settings search bar, enter "Tips" then tap the result for Tips & Support -> verify Tips and Support page is launched Change-Id: I30e52f5498fbeb840e7448fa464c20649f0b1db5 --- .../android/settings/support/SupportDashboardActivity.java | 6 ++++-- .../settings/support/SupportDashboardActivityTest.java | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/support/SupportDashboardActivity.java b/src/com/android/settings/support/SupportDashboardActivity.java index b8a22b996e1..46548584e02 100644 --- a/src/com/android/settings/support/SupportDashboardActivity.java +++ b/src/com/android/settings/support/SupportDashboardActivity.java @@ -17,7 +17,6 @@ package com.android.settings.support; import android.app.Activity; import android.content.Context; -import android.content.Intent; import android.os.Bundle; import com.android.settings.R; @@ -37,6 +36,9 @@ import java.util.List; @SearchIndexable public class SupportDashboardActivity extends Activity implements Indexable { + public static final String ACTION_SUPPORT_SETTINGS = + "com.android.settings.action.SUPPORT_SETTINGS"; + @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); @@ -70,7 +72,7 @@ public class SupportDashboardActivity extends Activity implements Indexable { data.summaryOn = context.getString(R.string.support_summary); data.intentTargetPackage = context.getPackageName(); data.intentTargetClass = SupportDashboardActivity.class.getName(); - data.intentAction = Intent.ACTION_MAIN; + data.intentAction = ACTION_SUPPORT_SETTINGS; data.key = SUPPORT_SEARCH_INDEX_KEY; result.add(data); diff --git a/tests/robotests/src/com/android/settings/support/SupportDashboardActivityTest.java b/tests/robotests/src/com/android/settings/support/SupportDashboardActivityTest.java index 0124551740e..f5109944626 100644 --- a/tests/robotests/src/com/android/settings/support/SupportDashboardActivityTest.java +++ b/tests/robotests/src/com/android/settings/support/SupportDashboardActivityTest.java @@ -16,6 +16,8 @@ package com.android.settings.support; +import static com.android.settings.support.SupportDashboardActivity.ACTION_SUPPORT_SETTINGS; + import static com.google.common.truth.Truth.assertThat; import android.content.Context; @@ -59,7 +61,7 @@ public class SupportDashboardActivityTest { mContext.getString(R.string.page_tab_title_support)); assertThat(value.intentTargetPackage).isEqualTo(mContext.getPackageName()); assertThat(value.intentTargetClass).isEqualTo(SupportDashboardActivity.class.getName()); - assertThat(value.intentAction).isEqualTo(Intent.ACTION_MAIN); + assertThat(value.intentAction).isEqualTo(ACTION_SUPPORT_SETTINGS); } @Test