From b8b310df1797cace05fee4b7ac9b882484f51d25 Mon Sep 17 00:00:00 2001 From: Robin Lee Date: Thu, 30 Mar 2017 15:13:07 +0100 Subject: [PATCH] VPN: uncheck lockdown if always-on is off Change-Id: I00933e0c8567997d800f9f31f78c7b19922a52b8 Fix: 36713605 Test: make RunSettingsRoboTests -j30 --- src/com/android/settings/vpn2/AppManagementFragment.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/vpn2/AppManagementFragment.java b/src/com/android/settings/vpn2/AppManagementFragment.java index 75595120fb1..9981b2fae84 100644 --- a/src/com/android/settings/vpn2/AppManagementFragment.java +++ b/src/com/android/settings/vpn2/AppManagementFragment.java @@ -197,9 +197,7 @@ public class AppManagementFragment extends SettingsPreferenceFragment @Override public void onConfirmLockdown(Bundle options, boolean isEnabled, boolean isLockdown) { - if (setAlwaysOnVpnByUI(isEnabled, isLockdown)) { - updateUI(); - } + setAlwaysOnVpnByUI(isEnabled, isLockdown); } private boolean setAlwaysOnVpnByUI(boolean isEnabled, boolean isLockdown) { @@ -214,6 +212,8 @@ public class AppManagementFragment extends SettingsPreferenceFragment final boolean success = setAlwaysOnVpn(isEnabled, isLockdown); if (isEnabled && (!success || !isVpnAlwaysOn())) { CannotConnectFragment.show(this, mVpnLabel); + } else { + updateUI(); } return success; }