From be70aaa6c4c54e412eff70a0879243753a3897ed Mon Sep 17 00:00:00 2001 From: lindatseng Date: Wed, 22 May 2019 10:36:50 -0700 Subject: [PATCH] Add null check to precent crash in monkey test Fixes: 133259172 Test: manual Change-Id: Ib4dd24965fda40a7a917397bf558309e0424bf16 --- src/com/android/settings/panel/PanelFeatureProviderImpl.java | 4 ++++ src/com/android/settings/panel/PanelFragment.java | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/com/android/settings/panel/PanelFeatureProviderImpl.java b/src/com/android/settings/panel/PanelFeatureProviderImpl.java index 67c300f5f0f..e6b0a231885 100644 --- a/src/com/android/settings/panel/PanelFeatureProviderImpl.java +++ b/src/com/android/settings/panel/PanelFeatureProviderImpl.java @@ -25,6 +25,10 @@ public class PanelFeatureProviderImpl implements PanelFeatureProvider { @Override public PanelContent getPanel(Context context, String panelType, String mediaPackageName) { + if (context == null) { + return null; + } + switch (panelType) { case Settings.Panel.ACTION_INTERNET_CONNECTIVITY: return InternetConnectivityPanel.create(context); diff --git a/src/com/android/settings/panel/PanelFragment.java b/src/com/android/settings/panel/PanelFragment.java index e9eeb8d2041..79d1ac592d9 100644 --- a/src/com/android/settings/panel/PanelFragment.java +++ b/src/com/android/settings/panel/PanelFragment.java @@ -170,6 +170,10 @@ public class PanelFragment extends Fragment { .getPanelFeatureProvider() .getPanel(activity, panelType, mediaPackageName); + if (mPanel == null) { + activity.finish(); + } + mMetricsProvider = FeatureFactory.getFactory(activity).getMetricsFeatureProvider(); mPanelSlices.setLayoutManager(new LinearLayoutManager((activity)));