diff --git a/src/com/android/settings/SettingsInitialize.java b/src/com/android/settings/SettingsInitialize.java index c0c0777f2f3..297bad79099 100644 --- a/src/com/android/settings/SettingsInitialize.java +++ b/src/com/android/settings/SettingsInitialize.java @@ -118,7 +118,8 @@ public class SettingsInitialize extends BroadcastReceiver { } private void privateProfileSetup(Context context, PackageManager pm, UserInfo userInfo) { - if (Flags.allowPrivateProfile()) { + if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { if (userInfo == null || !userInfo.isPrivateProfile()) { return; } diff --git a/src/com/android/settings/Utils.java b/src/com/android/settings/Utils.java index 108e331a090..6e36ee36733 100644 --- a/src/com/android/settings/Utils.java +++ b/src/com/android/settings/Utils.java @@ -1228,6 +1228,7 @@ public final class Utils extends com.android.settingslib.Utils { UserProperties userProperties = userManager.getUserProperties(userHandle); if (userProperties.getShowInSettings() == UserProperties.SHOW_IN_SETTINGS_SEPARATE) { if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && userProperties.getShowInQuietMode() == UserProperties.SHOW_IN_QUIET_MODE_HIDDEN) { if (!userManager.isQuietModeEnabled(userHandle)) { diff --git a/src/com/android/settings/accounts/AccountPreferenceController.java b/src/com/android/settings/accounts/AccountPreferenceController.java index 2d862d6f093..4f03303c372 100644 --- a/src/com/android/settings/accounts/AccountPreferenceController.java +++ b/src/com/android/settings/accounts/AccountPreferenceController.java @@ -311,11 +311,10 @@ public class AccountPreferenceController extends AbstractPreferenceController // should be shown or not. if (((profile.isManagedProfile() && (mType & ProfileSelectFragment.ProfileType.WORK) != 0) - || (Flags.allowPrivateProfile() - && profile.isPrivateProfile() + || (isPrivateProfile(profile) && (mType & ProfileSelectFragment.ProfileType.PRIVATE) != 0) || (!profile.isManagedProfile() - && !(Flags.allowPrivateProfile() && profile.isPrivateProfile()) + && !isPrivateProfile(profile) && (mType & ProfileSelectFragment.ProfileType.PERSONAL) != 0)) && !(mUm.getUserProperties(profile.getUserHandle()) .getShowInQuietMode() == UserProperties.SHOW_IN_QUIET_MODE_HIDDEN @@ -338,6 +337,12 @@ public class AccountPreferenceController extends AbstractPreferenceController mFragment.forceUpdatePreferences(); } + private static boolean isPrivateProfile(UserInfo profile) { + return Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && profile.isPrivateProfile(); + } + private void updateProfileUi(final UserInfo userInfo) { if (mFragment.getPreferenceManager() == null) { return; diff --git a/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminListPreferenceController.java b/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminListPreferenceController.java index 640f21dec0e..86c11c21e09 100644 --- a/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminListPreferenceController.java +++ b/src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminListPreferenceController.java @@ -167,8 +167,9 @@ public class DeviceAdminListPreferenceController extends BasePreferenceControlle } private boolean shouldSkipProfile(UserHandle profile) { - return android.os.Flags.allowPrivateProfile() + return android.os.Flags.allowPrivateProfile() && android.multiuser.Flags.handleInterleavedSettingsForPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && mUm.isQuietModeEnabled(profile) && mUm.getUserProperties(profile).getShowInQuietMode() == UserProperties.SHOW_IN_QUIET_MODE_HIDDEN; diff --git a/src/com/android/settings/dashboard/profileselector/ProfileSelectFragment.java b/src/com/android/settings/dashboard/profileselector/ProfileSelectFragment.java index 53a55542848..e8f407bd170 100644 --- a/src/com/android/settings/dashboard/profileselector/ProfileSelectFragment.java +++ b/src/com/android/settings/dashboard/profileselector/ProfileSelectFragment.java @@ -239,7 +239,9 @@ public abstract class ProfileSelectFragment extends DashboardFragment { return WORK_TAB; } UserInfo userInfo = UserManager.get(activity).getUserInfo(userId); - if (Flags.allowPrivateProfile() && userInfo != null && userInfo.isPrivateProfile()) { + if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && userInfo != null && userInfo.isPrivateProfile()) { return PRIVATE_TAB; } } @@ -249,7 +251,9 @@ public abstract class ProfileSelectFragment extends DashboardFragment { return WORK_TAB; } UserInfo userInfo = UserManager.get(activity).getUserInfo(intentUser); - if (Flags.allowPrivateProfile() && userInfo != null && userInfo.isPrivateProfile()) { + if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && userInfo != null && userInfo.isPrivateProfile()) { return PRIVATE_TAB; } @@ -260,7 +264,7 @@ public abstract class ProfileSelectFragment extends DashboardFragment { final DevicePolicyManager devicePolicyManager = getContext().getSystemService(DevicePolicyManager.class); - if (Flags.allowPrivateProfile()) { + if (Flags.allowPrivateProfile() && android.multiuser.Flags.enablePrivateSpaceFeatures()) { int tabForPosition = ((ViewPagerAdapter) mViewPager.getAdapter()).getTabForPosition(position); @@ -331,7 +335,9 @@ public abstract class ProfileSelectFragment extends DashboardFragment { ProfileType.WORK, bundle != null ? bundle.deepCopy() : new Bundle(), workFragmentConstructor)); - } else if (Flags.allowPrivateProfile() && userInfo.isPrivateProfile()) { + } else if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && userInfo.isPrivateProfile()) { if (!privateSpaceInfoProvider.isPrivateSpaceLocked(context)) { fragments.add(createAndGetFragment( ProfileType.PRIVATE, diff --git a/src/com/android/settings/dashboard/profileselector/UserAdapter.java b/src/com/android/settings/dashboard/profileselector/UserAdapter.java index c9e49f17558..40d1a93e5d7 100644 --- a/src/com/android/settings/dashboard/profileselector/UserAdapter.java +++ b/src/com/android/settings/dashboard/profileselector/UserAdapter.java @@ -87,6 +87,7 @@ public class UserAdapter extends BaseAdapter { return resources.getString(WORK_CATEGORY_HEADER, () -> context.getString(com.android.settingslib.R.string.category_work)); } else if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && mUserManager.getUserInfo(userId).isPrivateProfile()) { return resources.getString(PRIVATE_CATEGORY_HEADER, () -> context.getString(com.android.settingslib.R.string.category_private)); diff --git a/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImpl.java b/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImpl.java index 887fc3215a2..ef542a3590f 100644 --- a/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImpl.java +++ b/src/com/android/settings/enterprise/EnterprisePrivacyFeatureProviderImpl.java @@ -257,6 +257,7 @@ public class EnterprisePrivacyFeatureProviderImpl implements EnterprisePrivacyFe private boolean shouldSkipProfile(UserInfo userInfo) { return android.os.Flags.allowPrivateProfile() && android.multiuser.Flags.handleInterleavedSettingsForPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && userInfo.isQuietModeEnabled() && mUm.getUserProperties(userInfo.getUserHandle()).getShowInQuietMode() == UserProperties.SHOW_IN_QUIET_MODE_HIDDEN; diff --git a/src/com/android/settings/password/ChooseLockPassword.java b/src/com/android/settings/password/ChooseLockPassword.java index 631c735e6d0..a6453005ab9 100644 --- a/src/com/android/settings/password/ChooseLockPassword.java +++ b/src/com/android/settings/password/ChooseLockPassword.java @@ -416,6 +416,7 @@ public class ChooseLockPassword extends SettingsActivity { public String getHint(Context context, boolean isAlpha, int type, ProfileType profile) { if (isAlpha) { if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && profile.equals(ProfileType.Private)) { return context.getString(alphaHintForPrivateProfile); } else if (type == TYPE_FINGERPRINT) { @@ -433,6 +434,7 @@ public class ChooseLockPassword extends SettingsActivity { } } else { if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && profile.equals(ProfileType.Private)) { return context.getString(numericHintForPrivateProfile); } else if (type == TYPE_FINGERPRINT) { @@ -1147,7 +1149,9 @@ public class ChooseLockPassword extends SettingsActivity { /*flags=*/0).getSystemService(UserManager.class); if (userManager.isManagedProfile()) { return ProfileType.Managed; - } else if (android.os.Flags.allowPrivateProfile() && userManager.isPrivateProfile()) { + } else if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && userManager.isPrivateProfile()) { return ProfileType.Private; } else if (userManager.isProfile()) { return ProfileType.Other; diff --git a/src/com/android/settings/password/ChooseLockPattern.java b/src/com/android/settings/password/ChooseLockPattern.java index 8d0aebe6374..c331991a486 100644 --- a/src/com/android/settings/password/ChooseLockPattern.java +++ b/src/com/android/settings/password/ChooseLockPattern.java @@ -478,7 +478,9 @@ public class ChooseLockPattern extends SettingsActivity { .getString(SET_WORK_PROFILE_PATTERN_HEADER, () -> getString( R.string.lockpassword_choose_your_profile_pattern_header)); - } else if (android.os.Flags.allowPrivateProfile() && isPrivateProfile()) { + } else if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && isPrivateProfile()) { msg = getString(R.string.private_space_choose_your_pattern_header); } else { msg = getString(R.string.lockpassword_choose_your_pattern_header); diff --git a/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java b/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java index f2ebd1f6b3d..cf805130591 100644 --- a/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java +++ b/src/com/android/settings/password/ConfirmDeviceCredentialActivity.java @@ -300,6 +300,7 @@ public class ConfirmDeviceCredentialActivity extends FragmentActivity { launchedCDC = true; } } else if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && userProperties != null && userProperties.isAuthAlwaysRequiredToDisableQuietMode() && isInternalActivity()) { @@ -413,7 +414,8 @@ public class ConfirmDeviceCredentialActivity extends FragmentActivity { private boolean doesUserStateEnforceStrongAuth(int userId) { if (android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace()) { + && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { // Check if CE storage for user is locked since biometrics can't unlock fbe/keystore of // the profile user using verifyTiedProfileChallenge. Biometrics can still be used if // the user is stopped with delayed locking (i.e., with storage unlocked), so the user diff --git a/src/com/android/settings/password/ConfirmDeviceCredentialUtils.java b/src/com/android/settings/password/ConfirmDeviceCredentialUtils.java index 32e7489c6a6..e3182a4521e 100644 --- a/src/com/android/settings/password/ConfirmDeviceCredentialUtils.java +++ b/src/com/android/settings/password/ConfirmDeviceCredentialUtils.java @@ -105,7 +105,8 @@ public class ConfirmDeviceCredentialUtils { private static boolean isBiometricUnlockEnabledForPrivateSpace() { return android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace(); + && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures(); } /** diff --git a/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java b/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java index 1f0f7bb6414..7f0118c5b92 100644 --- a/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java +++ b/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java @@ -104,7 +104,8 @@ public class AutoAdvanceSetupFragment extends InstrumentedFragment { @Override public void onCreate(@Nullable Bundle savedInstanceState) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(savedInstanceState); } } diff --git a/src/com/android/settings/privatespace/HidePrivateSpaceController.java b/src/com/android/settings/privatespace/HidePrivateSpaceController.java index a53055cefc2..903defa332b 100644 --- a/src/com/android/settings/privatespace/HidePrivateSpaceController.java +++ b/src/com/android/settings/privatespace/HidePrivateSpaceController.java @@ -38,7 +38,10 @@ public class HidePrivateSpaceController extends TogglePreferenceController { @Override @AvailabilityStatus public int getAvailabilityStatus() { - return android.os.Flags.allowPrivateProfile() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + ? AVAILABLE + : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsController.java b/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsController.java index 1a89d37b8b6..6cb54a1cd89 100644 --- a/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsController.java +++ b/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsController.java @@ -52,6 +52,7 @@ public class HidePrivateSpaceSensitiveNotificationsController extends TogglePref public int getAvailabilityStatus() { if (!android.os.Flags.allowPrivateProfile() || !android.multiuser.Flags.enablePsSensitiveNotificationsToggle() + || !android.multiuser.Flags.enablePrivateSpaceFeatures() || !mPrivateSpaceMaintainer.doesPrivateSpaceExist()) { return UNSUPPORTED_ON_DEVICE; } diff --git a/src/com/android/settings/privatespace/HidePrivateSpaceSettings.java b/src/com/android/settings/privatespace/HidePrivateSpaceSettings.java index 124978a590c..c41267f3b69 100644 --- a/src/com/android/settings/privatespace/HidePrivateSpaceSettings.java +++ b/src/com/android/settings/privatespace/HidePrivateSpaceSettings.java @@ -27,7 +27,8 @@ public class HidePrivateSpaceSettings extends DashboardFragment{ @Override public void onCreate(Bundle icicle) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(icicle); } } diff --git a/src/com/android/settings/privatespace/HidePrivateSpaceSummaryController.java b/src/com/android/settings/privatespace/HidePrivateSpaceSummaryController.java index 42627af93ea..a366b709422 100644 --- a/src/com/android/settings/privatespace/HidePrivateSpaceSummaryController.java +++ b/src/com/android/settings/privatespace/HidePrivateSpaceSummaryController.java @@ -36,7 +36,10 @@ public final class HidePrivateSpaceSummaryController extends BasePreferenceContr @Override public int getAvailabilityStatus() { - return android.os.Flags.allowPrivateProfile() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + ? AVAILABLE + : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/privatespace/PrivateProfileContextHelperActivity.java b/src/com/android/settings/privatespace/PrivateProfileContextHelperActivity.java index 12a74400952..f2a50dc1e34 100644 --- a/src/com/android/settings/privatespace/PrivateProfileContextHelperActivity.java +++ b/src/com/android/settings/privatespace/PrivateProfileContextHelperActivity.java @@ -59,7 +59,8 @@ public class PrivateProfileContextHelperActivity extends FragmentActivity { @Override protected void onCreate(Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return; } setTheme(SetupWizardUtils.getTheme(this, getIntent())); diff --git a/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivity.java b/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivity.java index 63b1dc95a98..53d6b2272b3 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivity.java +++ b/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivity.java @@ -77,7 +77,8 @@ public class PrivateSpaceAuthenticationActivity extends FragmentActivity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); - if (Flags.allowPrivateProfile()) { + if (Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { ThemeHelper.trySetDynamicColor(this); mPrivateSpaceMaintainer = new Injector().injectPrivateSpaceMaintainer(getApplicationContext()); diff --git a/src/com/android/settings/privatespace/PrivateSpaceDashboardFragment.java b/src/com/android/settings/privatespace/PrivateSpaceDashboardFragment.java index 726567e08de..32db8b6a7d3 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceDashboardFragment.java +++ b/src/com/android/settings/privatespace/PrivateSpaceDashboardFragment.java @@ -32,7 +32,8 @@ public class PrivateSpaceDashboardFragment extends DashboardFragment { @Override public void onCreate(Bundle icicle) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(icicle); if (icicle == null && getIntent().getBooleanExtra(EXTRA_SHOW_PRIVATE_SPACE_UNLOCKED, false)) { diff --git a/src/com/android/settings/privatespace/PrivateSpaceEducation.java b/src/com/android/settings/privatespace/PrivateSpaceEducation.java index 4c99873c20d..cf22895a70b 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceEducation.java +++ b/src/com/android/settings/privatespace/PrivateSpaceEducation.java @@ -43,7 +43,8 @@ public class PrivateSpaceEducation extends InstrumentedFragment { LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return null; } GlifLayout rootView = diff --git a/src/com/android/settings/privatespace/PrivateSpaceMaintainer.java b/src/com/android/settings/privatespace/PrivateSpaceMaintainer.java index 2d38ae2007f..3fb9b153b8f 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceMaintainer.java +++ b/src/com/android/settings/privatespace/PrivateSpaceMaintainer.java @@ -78,7 +78,8 @@ public class PrivateSpaceMaintainer { */ @VisibleForTesting public final synchronized boolean createPrivateSpace() { - if (!Flags.allowPrivateProfile()) { + if (!Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return false; } // Check if Private space already exists @@ -146,7 +147,8 @@ public class PrivateSpaceMaintainer { /** Returns true if the Private space exists. */ public synchronized boolean doesPrivateSpaceExist() { - if (!Flags.allowPrivateProfile()) { + if (!Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return false; } if (mUserHandle != null) { @@ -322,6 +324,7 @@ public class PrivateSpaceMaintainer { private boolean isPrivateSpaceAutoLockSupported() { return android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.supportAutolockForPrivateSpace(); + && android.multiuser.Flags.supportAutolockForPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures(); } } diff --git a/src/com/android/settings/privatespace/PrivateSpaceSafetySource.java b/src/com/android/settings/privatespace/PrivateSpaceSafetySource.java index 6729830ab67..4e1741a7cda 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceSafetySource.java +++ b/src/com/android/settings/privatespace/PrivateSpaceSafetySource.java @@ -51,7 +51,8 @@ public final class PrivateSpaceSafetySource { return; } - if (!Flags.allowPrivateProfile()) { + if (!Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { // Setting null safetySourceData so that an old entry gets cleared out and this way // provide a response since SC always expects one on rescan. SafetyCenterManagerWrapper.get().setSafetySourceData( diff --git a/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java b/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java index 4a1e29b2452..399c2c82fbb 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java +++ b/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java @@ -51,7 +51,8 @@ public class PrivateSpaceSetLockFragment extends InstrumentedFragment { LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return null; } GlifLayout rootView = diff --git a/src/com/android/settings/privatespace/PrivateSpaceSetupActivity.java b/src/com/android/settings/privatespace/PrivateSpaceSetupActivity.java index 78c96dcc5f3..ec7132adf0e 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceSetupActivity.java +++ b/src/com/android/settings/privatespace/PrivateSpaceSetupActivity.java @@ -42,7 +42,8 @@ public class PrivateSpaceSetupActivity extends FragmentActivity { @Override protected void onCreate(Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return; } setTheme(SetupWizardUtils.getTheme(this, getIntent())); diff --git a/src/com/android/settings/privatespace/SetupSuccessFragment.java b/src/com/android/settings/privatespace/SetupSuccessFragment.java index 13de1fc94fc..cf63b22fead 100644 --- a/src/com/android/settings/privatespace/SetupSuccessFragment.java +++ b/src/com/android/settings/privatespace/SetupSuccessFragment.java @@ -47,7 +47,8 @@ public class SetupSuccessFragment extends InstrumentedFragment { LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return null; } GlifLayout rootView = diff --git a/src/com/android/settings/privatespace/autolock/AutoLockPreferenceController.java b/src/com/android/settings/privatespace/autolock/AutoLockPreferenceController.java index a7a12a4950c..3416e143d65 100644 --- a/src/com/android/settings/privatespace/autolock/AutoLockPreferenceController.java +++ b/src/com/android/settings/privatespace/autolock/AutoLockPreferenceController.java @@ -40,7 +40,8 @@ public class AutoLockPreferenceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { return android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.supportAutolockForPrivateSpace() + && android.multiuser.Flags.supportAutolockForPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } diff --git a/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragment.java b/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragment.java index 4380c534a04..cb332d1e515 100644 --- a/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragment.java +++ b/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragment.java @@ -47,7 +47,8 @@ public class AutoLockSettingsFragment extends RadioButtonPickerFragment { @Override public void onCreate(@NonNull Bundle icicle) { if (android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.supportAutolockForPrivateSpace()) { + && android.multiuser.Flags.supportAutolockForPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(icicle); } } diff --git a/src/com/android/settings/privatespace/delete/DeletePrivateSpaceController.java b/src/com/android/settings/privatespace/delete/DeletePrivateSpaceController.java index af4535ec43a..a2fc6f81d67 100644 --- a/src/com/android/settings/privatespace/delete/DeletePrivateSpaceController.java +++ b/src/com/android/settings/privatespace/delete/DeletePrivateSpaceController.java @@ -34,7 +34,10 @@ public class DeletePrivateSpaceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { - return android.os.Flags.allowPrivateProfile() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + ? AVAILABLE + : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteActivity.java b/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteActivity.java index a4109b868bc..b483aa3a460 100644 --- a/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteActivity.java +++ b/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteActivity.java @@ -35,7 +35,8 @@ public class PrivateSpaceDeleteActivity extends InstrumentedActivity { @Override protected void onCreate(Bundle savedInstanceState) { - if (!android.os.Flags.allowPrivateProfile()) { + if (!android.os.Flags.allowPrivateProfile() + || !android.multiuser.Flags.enablePrivateSpaceFeatures()) { return; } setTheme(SetupWizardUtils.getTheme(this, getIntent())); diff --git a/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragment.java b/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragment.java index 7dd3a5b0102..bcc220f1813 100644 --- a/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragment.java +++ b/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragment.java @@ -56,7 +56,8 @@ public class PrivateSpaceDeleteFragment extends InstrumentedFragment { @Override public void onCreate(@Nullable Bundle icicle) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(icicle); } } diff --git a/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragment.java b/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragment.java index 3a166413565..33f0a3ee362 100644 --- a/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragment.java +++ b/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragment.java @@ -62,7 +62,8 @@ public class PrivateSpaceDeletionProgressFragment extends InstrumentedFragment { @Override public void onCreate(@Nullable Bundle savedInstanceState) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(savedInstanceState); } } diff --git a/src/com/android/settings/privatespace/onelock/FaceFingerprintUnlockController.java b/src/com/android/settings/privatespace/onelock/FaceFingerprintUnlockController.java index 2e3f2840b70..04f489401ed 100644 --- a/src/com/android/settings/privatespace/onelock/FaceFingerprintUnlockController.java +++ b/src/com/android/settings/privatespace/onelock/FaceFingerprintUnlockController.java @@ -42,6 +42,7 @@ public class FaceFingerprintUnlockController extends CombinedBiometricStatusPref protected boolean isUserSupported() { return android.os.Flags.allowPrivateProfile() && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && mProfileUserId != UserHandle.USER_NULL; } diff --git a/src/com/android/settings/privatespace/onelock/PrivateSpaceBiometricSettings.java b/src/com/android/settings/privatespace/onelock/PrivateSpaceBiometricSettings.java index dc00885cf87..827f0b72b60 100644 --- a/src/com/android/settings/privatespace/onelock/PrivateSpaceBiometricSettings.java +++ b/src/com/android/settings/privatespace/onelock/PrivateSpaceBiometricSettings.java @@ -34,7 +34,8 @@ public class PrivateSpaceBiometricSettings extends BiometricsSettingsBase { @Override public void onAttach(Context context) { if (android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace()) { + && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onAttach(context); UserHandle privateProfileHandle = PrivateSpaceMaintainer.getInstance(context).getPrivateProfileHandle(); diff --git a/src/com/android/settings/privatespace/onelock/PrivateSpaceFacePreferenceController.java b/src/com/android/settings/privatespace/onelock/PrivateSpaceFacePreferenceController.java index b841d9aded5..583a093dbc2 100644 --- a/src/com/android/settings/privatespace/onelock/PrivateSpaceFacePreferenceController.java +++ b/src/com/android/settings/privatespace/onelock/PrivateSpaceFacePreferenceController.java @@ -45,6 +45,7 @@ public class PrivateSpaceFacePreferenceController extends BiometricFaceStatusPre protected boolean isUserSupported() { return android.os.Flags.allowPrivateProfile() && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && getUserId() != UserHandle.USER_NULL; } @@ -63,7 +64,8 @@ public class PrivateSpaceFacePreferenceController extends BiometricFaceStatusPre @Override public int getAvailabilityStatus() { return android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } diff --git a/src/com/android/settings/privatespace/onelock/PrivateSpaceFingerprintPreferenceController.java b/src/com/android/settings/privatespace/onelock/PrivateSpaceFingerprintPreferenceController.java index d48490460b5..f88c9facccc 100644 --- a/src/com/android/settings/privatespace/onelock/PrivateSpaceFingerprintPreferenceController.java +++ b/src/com/android/settings/privatespace/onelock/PrivateSpaceFingerprintPreferenceController.java @@ -47,6 +47,7 @@ public class PrivateSpaceFingerprintPreferenceController protected boolean isUserSupported() { return android.os.Flags.allowPrivateProfile() && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() && getUserId() != UserHandle.USER_NULL; } @@ -65,7 +66,8 @@ public class PrivateSpaceFingerprintPreferenceController @Override public int getAvailabilityStatus() { return android.os.Flags.allowPrivateProfile() - && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enableBiometricsToUnlockPrivateSpace() + && android.multiuser.Flags.enablePrivateSpaceFeatures() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } diff --git a/src/com/android/settings/privatespace/onelock/PrivateSpaceLockController.java b/src/com/android/settings/privatespace/onelock/PrivateSpaceLockController.java index efbe9f9200d..e0f376e1007 100644 --- a/src/com/android/settings/privatespace/onelock/PrivateSpaceLockController.java +++ b/src/com/android/settings/privatespace/onelock/PrivateSpaceLockController.java @@ -74,7 +74,8 @@ public class PrivateSpaceLockController extends AbstractPreferenceController { @Override public boolean isAvailable() { - return android.os.Flags.allowPrivateProfile(); + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures(); } @Override diff --git a/src/com/android/settings/privatespace/onelock/UseOneLockController.java b/src/com/android/settings/privatespace/onelock/UseOneLockController.java index 31634b9ea00..1af36b333b6 100644 --- a/src/com/android/settings/privatespace/onelock/UseOneLockController.java +++ b/src/com/android/settings/privatespace/onelock/UseOneLockController.java @@ -45,7 +45,10 @@ public class UseOneLockController extends BasePreferenceController { } @Override public int getAvailabilityStatus() { - return android.os.Flags.allowPrivateProfile() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + ? AVAILABLE + : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java b/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java index fd7d02b6c7a..680f5c7de0e 100644 --- a/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java +++ b/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java @@ -95,7 +95,8 @@ public class UseOneLockControllerSwitch extends AbstractPreferenceController @Override public boolean isAvailable() { - return android.os.Flags.allowPrivateProfile(); + return android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures(); } @Override diff --git a/src/com/android/settings/privatespace/onelock/UseOneLockSettingsFragment.java b/src/com/android/settings/privatespace/onelock/UseOneLockSettingsFragment.java index 413e02a16f8..ce017e31152 100644 --- a/src/com/android/settings/privatespace/onelock/UseOneLockSettingsFragment.java +++ b/src/com/android/settings/privatespace/onelock/UseOneLockSettingsFragment.java @@ -39,7 +39,8 @@ public class UseOneLockSettingsFragment extends DashboardFragment { @Override public void onCreate(Bundle icicle) { - if (android.os.Flags.allowPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures()) { super.onCreate(icicle); } } diff --git a/src/com/android/settings/safetycenter/BiometricsSafetySource.java b/src/com/android/settings/safetycenter/BiometricsSafetySource.java index 8e1c78644d9..c93ced1a50d 100644 --- a/src/com/android/settings/safetycenter/BiometricsSafetySource.java +++ b/src/com/android/settings/safetycenter/BiometricsSafetySource.java @@ -62,7 +62,9 @@ public final class BiometricsSafetySource { } final Context profileParentContext = context.createContextAsUser(profileParentUserHandle, 0); - if (android.os.Flags.allowPrivateProfile() && userManager.isPrivateProfile()) { + if (android.os.Flags.allowPrivateProfile() + && android.multiuser.Flags.enablePrivateSpaceFeatures() + && userManager.isPrivateProfile()) { // SC always expects a response from the source if the broadcast has been sent for this // source, therefore, we need to send a null SafetySourceData. SafetyCenterManagerWrapper.get().setSafetySourceData( diff --git a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java index b6af0f908cc..46e4ea5d117 100644 --- a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java +++ b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java @@ -174,7 +174,8 @@ public class ProfileSelectFragmentTest { @Test public void getTabId_setPrivateId_getCorrectTab() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final Bundle bundle = new Bundle(); bundle.putInt(EXTRA_USER_ID, 11); mUserManager.setPrivateProfile(11, "private", 0); @@ -204,7 +205,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenOnlyPersonal_returnsOneFragment() { - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); Fragment[] fragments = ProfileSelectFragment.getFragments( @@ -239,7 +241,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenPrivateEnabled_returnsTwoFragments() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -261,7 +264,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenManagedProfile_returnsTwoFragments() { - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -283,7 +287,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenAllProfiles_returnsThreeFragments() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -307,7 +312,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenAvailableBundle_returnsFragmentsWithCorrectBundles() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( diff --git a/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt b/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt index b5a4fe989cc..b792959acba 100644 --- a/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt +++ b/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt @@ -49,7 +49,8 @@ class SecuritySettingsTest { } @Test - @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) + @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES) fun privateSpace_ifFlagON() { device.assertHasTexts(listOf("Private Space")) } diff --git a/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt b/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt index 8eadd9dde92..14feb49adc1 100644 --- a/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt +++ b/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt @@ -38,7 +38,8 @@ import org.junit.runner.RunWith @RunWith(AndroidJUnit4::class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES) class PrivateSpaceAuthenticationActivityTest { private val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()) diff --git a/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java b/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java index a671a45b448..3a330f21a23 100644 --- a/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java +++ b/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java @@ -310,7 +310,8 @@ public class CombinedBiometricStatusUtilsTest { when(mFaceManager.hasEnrolledTemplates(anyInt())).thenReturn(false); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mCombinedBiometricStatusUtils.getPrivateProfileSettingsClassName()) .isEqualTo(Settings.PrivateSpaceBiometricSettingsActivity.class.getName()); diff --git a/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java index f1da363b5e9..857135f419f 100644 --- a/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java @@ -75,7 +75,8 @@ public class FaceFingerprintUnlockControllerTest { public void getAvailabilityStatus_whenFlagsEnabled_returnsAvailable() { mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(true); } @@ -83,18 +84,33 @@ public class FaceFingerprintUnlockControllerTest { /** Tests that the controller is not available when Biometrics flag is not enabled. */ @Test public void getAvailabilityStatus_whenBiometricFlagDisabled_returnsFalse() { - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mSetFlagsRule.disableFlags( android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); } - /** Tests that the controller is not available when private feature flag is not enabled. */ + /** + * Tests that the controller is not available when the main private space flag is not + * enabled. + */ @Test - public void getAvailabilityStatus_whenPrivateFlagDisabled_returnsFalse() { + public void getAvailabilityStatus_whenPsMainFlagDisabled_returnsFalse() { mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); mSetFlagsRule.enableFlags( + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); + + assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); + } + + /** Tests that the controller is not available when private features flag is not enabled. */ + @Test + public void getAvailabilityStatus_whenPsFeaturesFlagDisabled_returnsFalse() { + mSetFlagsRule.disableFlags(android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); @@ -106,7 +122,8 @@ public class FaceFingerprintUnlockControllerTest { doReturn(false).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFaceFingerprintUnlockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isFalse(); @@ -119,7 +136,8 @@ public class FaceFingerprintUnlockControllerTest { doReturn(true).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFaceFingerprintUnlockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java index 0abe3146f4f..b71547b65e2 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java @@ -40,7 +40,8 @@ import org.junit.Test; import org.junit.runner.RunWith; @RunWith(AndroidJUnit4.class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public class HidePrivateSpaceControllerTest { @Rule public final CheckFlagsRule mCheckFlagsRule = diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java index 1430dfd1736..88503a525b6 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java @@ -67,7 +67,8 @@ public class HidePrivateSpaceSensitiveNotificationsControllerTest { mSetFlagsRule.enableFlags( android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateProfileId = PrivateSpaceMaintainer.getInstance( mContext).getPrivateProfileHandle().getIdentifier(); @@ -143,7 +144,8 @@ public class HidePrivateSpaceSensitiveNotificationsControllerTest { public void getAvailabilityStatus_flagDisabled() { mSetFlagsRule.disableFlags( android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); - mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS, 1); Settings.Secure.putInt(mContext.getContentResolver(), diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java index 39f7b9cbfa8..ed072d32587 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java @@ -40,7 +40,8 @@ import org.junit.Test; import org.junit.runner.RunWith; @RunWith(AndroidJUnit4.class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public class HidePrivateSpaceSummaryControllerTest { @Rule public final CheckFlagsRule mCheckFlagsRule = diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java index 4c6feea36ab..8a7bd70e0ed 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java @@ -88,7 +88,8 @@ public class PrivateSpaceAuthenticationActivityTest { /** Tests that when Private does not exist setup flow is started. */ //TODO(b/307729746) Plan to add more tests for complete setup flow @Test - @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) + @RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public void whenPrivateProfileDoesNotExist_triggersSetupFlow() { when(mPrivateSpaceMaintainer.doesPrivateSpaceExist()).thenReturn(false); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java index 0d9db7e477b..c203a3cd72f 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java @@ -80,7 +80,8 @@ public class PrivateSpaceLockControllerTest { /** Tests that the controller is always available. */ @Test public void getAvailabilityStatus_returnsAvailable() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mPrivateSpaceLockController.isAvailable()).isEqualTo(true); } @@ -89,7 +90,8 @@ public class PrivateSpaceLockControllerTest { @Test public void getSummary_whenScreenLock() { doReturn(false).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isFalse(); @@ -103,7 +105,8 @@ public class PrivateSpaceLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PATTERN) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); @@ -115,7 +118,8 @@ public class PrivateSpaceLockControllerTest { public void getSummary_whenProfileLockPin() { doReturn(true).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PIN).when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); @@ -129,7 +133,8 @@ public class PrivateSpaceLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PASSWORD) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java index 8510b11c9c6..50f67d3c55b 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java @@ -148,7 +148,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psDoesNotExist_setsDefaultPsSensitiveNotificationsValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); + android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); privateSpaceMaintainer.deletePrivateSpace(); @@ -259,7 +260,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psDoesNotExist_resetsPSAutoLockSettings() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final int autoLockOption = 2; PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); @@ -282,7 +284,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psExists_doesNotResetPSAutoLockSettings() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final int privateSpaceAutLockValue = 1; PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java index cf9ea051ebf..940f70d58f4 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java @@ -86,7 +86,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void onDeviceRebootedEvent_whenSafetyCenterEnabled_setsData() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -98,7 +99,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_whenFeatureDisabled_setsNullData() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -113,7 +115,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_setsEnabled() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -129,7 +132,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_setsPsAuthenticatorIntent() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); diff --git a/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java index 744a8ec8882..5c2a15cbd05 100644 --- a/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java @@ -74,7 +74,8 @@ public class UseOneLockControllerTest { /** Tests that the controller is always available. */ @Test public void getAvailabilityStatus_returnsAvailable() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mUseOneLockController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -87,7 +88,8 @@ public class UseOneLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PATTERN) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("Pattern"); @@ -99,7 +101,8 @@ public class UseOneLockControllerTest { doReturn(true) .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PIN).when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("PIN"); @@ -112,7 +115,8 @@ public class UseOneLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PASSWORD) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("Password"); diff --git a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java index 01381d8320b..45c2c7562ff 100644 --- a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java @@ -75,7 +75,8 @@ public class AutoLockPreferenceControllerTest { public void getAvailabilityStatus_withAutoLockFlagEnabled_returnsAvailable() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mAutoLockPreferenceController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -83,7 +84,8 @@ public class AutoLockPreferenceControllerTest { /** Tests that the controller is not available when auto lock flag is off. */ @Test public void getAvailabilityStatus_withAutoLockFlagDisabled_returnsNull() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mSetFlagsRule.disableFlags(android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); assertThat(mAutoLockPreferenceController.getAvailabilityStatus()) @@ -98,7 +100,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionEveryTimeDeviceLocks_returnsEveryTimeDeviceLocks() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, @@ -116,7 +119,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionAfter5MinutesOfInactivity_returnsAfter5MinutesOfInactivity() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, @@ -131,7 +135,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionNever_returnsNever() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, diff --git a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java index 971ca40c8e1..1c620c068f3 100644 --- a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java @@ -94,7 +94,8 @@ public class AutoLockSettingsFragmentTest { public void verifyMetricsConstant() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } @@ -103,7 +104,8 @@ public class AutoLockSettingsFragmentTest { public void getCandidates_returnsCandidateInfoListWithAllKeys() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); final List candidates = mFragment.getCandidates(); @@ -120,7 +122,8 @@ public class AutoLockSettingsFragmentTest { public void getDefaultKey_returnsStoredAutoLockOptionsValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); @@ -144,7 +147,8 @@ public class AutoLockSettingsFragmentTest { public void setDefaultKey_storesCorrectAutoLockOptionValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); mFragment.setDefaultKey("2"); diff --git a/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java index 371ca240039..ed8decddf0e 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java @@ -58,7 +58,8 @@ public class DeletePrivateSpaceControllerTest { /** Tests that the controller is available when private space flag is enabled. */ @Test public void getAvailabilityStatus_whenPrivateFlagEnabled_returnsAvailable() { - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mDeletePrivateSpaceController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -66,7 +67,8 @@ public class DeletePrivateSpaceControllerTest { /** Tests that the controller is not available when private space flag is disabled. */ @Test public void getAvailabilityStatus_whenPrivateFlagDisabled_returnsUnsupportedOnDevice() { - mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mDeletePrivateSpaceController.getAvailabilityStatus()) .isEqualTo(UNSUPPORTED_ON_DEVICE); diff --git a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java index 16ccbc451fc..5c48375c209 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java @@ -39,7 +39,8 @@ public class PrivateSpaceDeleteFragmentTest { @Test @UiThreadTest public void verifyMetricsConstant() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment = spy(new PrivateSpaceDeleteFragment()); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } diff --git a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java index 5c2ef23564b..ffc1edf0c28 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java @@ -77,7 +77,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { @Test @UiThreadTest public void verifyMetricsConstant() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } @@ -87,7 +88,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { public void deletePrivateSpace_deletesPS() { PrivateSpaceDeletionProgressFragment spyFragment = spy(mFragment); doNothing().when(spyFragment).showSuccessfulDeletionToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceMaintainer.createPrivateSpace(); spyFragment.deletePrivateSpace(); @@ -100,7 +102,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { public void deletePrivateSpace_onDeletion_showsDeletedToast() { PrivateSpaceDeletionProgressFragment spyFragment = spy(mFragment); doNothing().when(spyFragment).showSuccessfulDeletionToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceMaintainer.createPrivateSpace(); spyFragment.deletePrivateSpace(); @@ -123,7 +126,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { spyFragment.setPrivateSpaceMaintainer(injector); doReturn(DELETE_PS_ERROR_INTERNAL).when(mPrivateSpaceMaintainerMock).deletePrivateSpace(); doNothing().when(spyFragment).showDeletionInternalErrorToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); spyFragment.deletePrivateSpace(); diff --git a/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java b/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java index 85bd0e2e7c6..cd4c3c64fe7 100644 --- a/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java +++ b/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java @@ -247,7 +247,8 @@ public class SafetySourceBroadcastReceiverTest { @Test public void onReceive_onRefresh_withPrivateSpaceFeatureDisabled_setsNullData() { when(mSafetyCenterManagerWrapper.isEnabled(mApplicationContext)).thenReturn(true); - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Intent intent = new Intent()