From b7e4380cd27ffd8a060ecb61201057fb6843e408 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Mon, 6 Jun 2016 16:01:58 -0400 Subject: [PATCH] Remove PreferenceActivity Its broken and isn't worth maintaining, instead port the few things using it over to SettingsPreferenceActivity with wrapping blank Activities like the rest of Settings. Change-Id: Ic82f0dcb63ed9b4078f7da6a79c0c52f0130e8d1 Fixes: 28779941 --- AndroidManifest.xml | 39 ++++++--- res/layout/icc_lock_tabs.xml | 2 +- res/xml/device_info_settings.xml | 2 +- res/xml/device_info_status.xml | 4 +- res/xml/security_settings_misc.xml | 2 +- res/xml/testing_settings.xml | 2 +- res/xml/testing_wifi_settings.xml | 2 +- src/com/android/settings/ApnEditor.java | 86 ++++++++++--------- src/com/android/settings/IccLockSettings.java | 66 ++++++++------ .../InstrumentedPreferenceActivity.java | 45 ---------- .../android/settings/PreferenceActivity.java | 82 ------------------ src/com/android/settings/Settings.java | 10 +++ .../android/settings/SettingsActivity.java | 15 ++++ .../settings/SettingsPreferenceFragment.java | 27 +++++- src/com/android/settings/TestingSettings.java | 12 ++- .../TestingSettingsBroadcastReceiver.java | 4 +- .../settings/accounts/AddAccountSettings.java | 3 +- .../accounts/ChooseAccountActivity.java | 33 +++---- .../settings/deviceinfo/ImeiInformation.java | 8 +- .../settings/deviceinfo/SimStatus.java | 51 +++++++---- .../android/settings/deviceinfo/Status.java | 24 +++--- .../android/settings/wifi/WifiAPITest.java | 29 ++++--- src/com/android/settings/wifi/WifiInfo.java | 11 ++- 23 files changed, 282 insertions(+), 277 deletions(-) delete mode 100644 src/com/android/settings/InstrumentedPreferenceActivity.java delete mode 100644 src/com/android/settings/PreferenceActivity.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index e8271a8e4c2..5cde21c11a2 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -327,7 +327,7 @@ android:value="true" /> - @@ -336,6 +336,8 @@ + - + - @@ -1457,6 +1461,8 @@ + - @@ -1748,10 +1754,12 @@ + - @@ -1760,10 +1768,12 @@ + - @@ -1772,6 +1782,8 @@ + - @@ -1890,6 +1902,8 @@ + - + + @@ -2319,10 +2335,13 @@ android:value="true" /> - + android:theme="@style/Theme.SubSettingsDialogWhenLarge"> + + + android:targetClass="com.android.settings.Settings$StatusActivity" /> diff --git a/res/xml/device_info_status.xml b/res/xml/device_info_status.xml index 2cb5c6d736f..a0b7590509e 100644 --- a/res/xml/device_info_status.xml +++ b/res/xml/device_info_status.xml @@ -33,13 +33,13 @@ android:title="@string/sim_status_title" android:persistent="false"> + android:targetClass="com.android.settings.Settings$SimStatusActivity" /> + android:targetClass="com.android.settings.Settings$ImeiInformationActivity" /> + android:targetClass="com.android.settings.Settings$IccLockSettingsActivity"/> diff --git a/res/xml/testing_settings.xml b/res/xml/testing_settings.xml index 4e5c5ddf284..bce03e5aa06 100644 --- a/res/xml/testing_settings.xml +++ b/res/xml/testing_settings.xml @@ -37,7 +37,7 @@ + android:targetClass="com.android.settings.Settings$WifiInfoActivity" />