PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Potential fix for NPE in Running services.

Browse Source 
Bug: 5698270

Loop was removing items from the list being iterated.

Change-Id: I39e98c554b2fe6024381afbe79b737b812e78f08
This commit is contained in:
Amith Yamasani
2011-12-02 10:15:27 -08:00
parent e9b79e3aad
commit b71efad62e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/applications/RunningState.java
View File

@@ -815,7 +815,7 @@ public class RunningState {
// Build the chains from client processes to the process they are // Build the chains from client processes to the process they are
// dependent on; also remove any old running processes. // dependent on; also remove any old running processes.
int NRP = mRunningProcesses.size(); int NRP = mRunningProcesses.size();
for (int i=0; i<NRP; i++) { for (int i = 0; i < NRP;) {
ProcessItem proc = mRunningProcesses.valueAt(i); ProcessItem proc = mRunningProcesses.valueAt(i);
if (proc.mRunningSeq == mSequence) { if (proc.mRunningSeq == mSequence) {
int clientPid = proc.mRunningProcessInfo.importanceReasonPid; int clientPid = proc.mRunningProcessInfo.importanceReasonPid;
@@ -833,9 +833,11 @@ public class RunningState {
// we will detect the change. // we will detect the change.
proc.mClient = null; proc.mClient = null;
} }
i++;
} else { } else {
changed = true; changed = true;
mRunningProcesses.remove(mRunningProcesses.keyAt(i)); mRunningProcesses.remove(mRunningProcesses.keyAt(i));
NRP--;
} }
} }