Fix app crash while adding new user
Settings app crashes when tapping Home key while adding new user because UserSettings#showDialog() is called after onSaveInstanceState(). To fix this issue, a dialog should not be shown after onPause(). Fixes: 68485787 Test: manual - tap Home key while adding new user Change-Id: I2ddd119b6558927798a52c7977e6fd8137734c93
This commit is contained in:
committed by
Yoshinori Hirano
parent
3d8b442e8d
commit
b6fa43d980
@@ -450,6 +450,10 @@ public class UserSettings extends SettingsPreferenceFragment
|
|||||||
private void onUserCreated(int userId) {
|
private void onUserCreated(int userId) {
|
||||||
mAddedUserId = userId;
|
mAddedUserId = userId;
|
||||||
mAddingUser = false;
|
mAddingUser = false;
|
||||||
|
if (!isResumed()) {
|
||||||
|
Log.w(TAG, "Cannot show dialog after onPause");
|
||||||
|
return;
|
||||||
|
}
|
||||||
if (mUserManager.getUserInfo(userId).isRestricted()) {
|
if (mUserManager.getUserInfo(userId).isRestricted()) {
|
||||||
showDialog(DIALOG_SETUP_PROFILE);
|
showDialog(DIALOG_SETUP_PROFILE);
|
||||||
} else {
|
} else {
|
||||||
|
Reference in New Issue
Block a user